Function to return an aggregate

Question

I have the following function
create or replace function get_sum_costs3 (v_ID_COUNTER in number) return number
Return sum escalated costs based on filters filename: create_display_functions.sql -- -- History -- 06/04/06 SDR Created
is
v_escalated_cost number(20,2);
v_SC_1 varchar2(100);
v_SC_2 varchar2(100);
v_SC_3 varchar2(100);
v_SC_4 varchar2(100);
v_SC_5 varchar2(100);
v_SC_6 varchar2(100);
v_SC_7 varchar2(100);
v_SC_1PER number (10);
v_SC_2PER number (10);
v_SC_3PER number (10);
v_SC_4PER number (10);
v_SC_5PER number (10);
v_SC_6PER number (10);
v_SC_7PER number (10);
v_return number (12,2);
cursor c1 is
select curr_8, text_16, text_17, text_18, text_19, text_20, text_21, text_22, num_17, num_18, num_19, num_20, num_21, num_22, num_23
from areg
where areg.ID_COUNTER = v_ID_COUNTER ;
begin
v_return:= 0;
open c1;
fetch c1 into v_escalated_cost,v_SC_1,v_SC_2,v_SC_3, v_SC_4,v_SC_5,v_SC_6,v_SC_7,v_SC_1PER,v_SC_2PER,v_SC_3PER,v_SC_4PER,v_SC_5PER,v_SC_6PER,v_SC_7PER;
if
c1%notfound then v_return:= 0;
else
v_return:= (v_escalated_cost * (v_SC_1PER / 100))) + (v_escalated_cost * (v_SC_2PER / 100))) etc on through v_SC_7PER / 100 I haven't written this atm ;
end if;
close c1;
return v_return;
end;
It doesn't quite do what I need and I'm having trouble altering it. It uses the ID_Counter from another table (which is defined by other inputs) to reference records. I want to search these records for the occurence of a "catchment name" matching the session state of one of my inputs (SER_1).
This "catchment name" could occur in any of the variables v_SC_1 to v_SC_7 and there will be a corresponding % of the cost of that job that can be charged to the "catchment name" which is found in v_SC_1PER to v_SC_7PER. Where it finds a match for the name I want it to go and multiply the v_escalated_cost by the percentage applicable to give the cost of the job I can charge to that catchment.
Then I need it to total up these costs and return a total cost of all projects in that catchment. So if there's one job that's 100% in a catchment I need 100% of that cost, if there's one that's 25%in the same catchment I need to add 25% of the total cost of the job to the 100% of the first.
Clear as mud?
At present the function will only look for the occurence of the Catchment name somewhere in the record and return the entire value if the name is in there somewhere.
What I probably need to do is say IF the name is in SC_1 then times the cost by SC_1PER, if its in SC_2 do the same for SC_2PER and so on. Then return the sum. Anyone help? Do I need multiple cursors, one for each SC_x variable? How do I write an aggregate function like sum into the return clause, it doesn't seem to like that?
All help is greatly appreciated Thx

Answer 1

The first thing I would do is pass all your page items. This way you can debug your function independent from your Apex application. Something like:
CREATE OR REPLACE
FUNCTION get_sum_costs4 (p_SER_1  VARCHAR2,
                         p_CAT_1  VARCHAR2,
                         p_SUB_1  VARCHAR2,
                         p_PIPL_1 VARCHAR2,
                         p_PIPV_1 VARCHAR2) return number
IS
  CURSOR c1 IS
  SELECT
         CASE WHEN INSTR(text_16,p_SER_1) = 0 THEN 0 ELSE curr_8 * (num_17/100) END +
         CASE WHEN INSTR(text_17,p_SER_1) = 0 THEN 0 ELSE curr_8 * (num_18/100) END +
         CASE WHEN INSTR(text_18,p_SER_1) = 0 THEN 0 ELSE curr_8 * (num_19/100) END +
         CASE WHEN INSTR(text_19,p_SER_1) = 0 THEN 0 ELSE curr_8 * (num_20/100) END +
         CASE WHEN INSTR(text_20,p_SER_1) = 0 THEN 0 ELSE curr_8 * (num_21/100) END +
         CASE WHEN INSTR(text_21,p_SER_1) = 0 THEN 0 ELSE curr_8 * (num_22/100) END +
         CASE WHEN INSTR(text_22,p_SER_1) = 0 THEN 0 ELSE curr_8 * (num_23/100) END
  FROM areg
  WHERE category = p_CAT_1
    and (text_15 = p_PIPL_1 or p_PIPL_1 = 'ALL')
    and (text_10 = p_PIPV_1 or p_PIPV_1 = 'ALL')
    and (subcategory1 = p_SUB_1 or p_SUB_1 = 'ALL')
    and yesno5 <> 'Y';
  v_return NUMBER := 0;
BEGIN
  OPEN c1;
  FETCH c1 INTO v_return;
  CLOSE c1;
  RETURN (v_return);
END;
/Here is the test case I used:
CREATE TABLE areg
(category VARCHAR2(1),
subcategory1 VARCHAR(2),
text_15  VARCHAR2(20),
text_10  VARCHAR2(20),
yesno5   VARCHAR2(1),
text_16  VARCHAR2(20),
text_17  VARCHAR2(20),
text_18  VARCHAR2(20),
text_19  VARCHAR2(20),
text_20  VARCHAR2(20),
text_21  VARCHAR2(20),
text_22  VARCHAR2(20),
num_17   NUMBER,
num_18   NUMBER,
num_19   NUMBER,
num_20   NUMBER,
num_21   NUMBER,
num_22   NUMBER,
num_23   NUMBER,
curr_8   NUMBER);
INSERT INTO areg VALUES
('C','SC','BOGUS_15','BOGUS_10','N','BOGUS_16','BOGUS_17','BOGUS_18','BOGUS_19','BOGUS_20','BOGUS_21','BOGUS_23',
100,50,25,15,10,5,0,100);
/pre]
When ran via
[pre]
DECLARE
  v_value NUMBER;
BEGIN
  v_value := get_sum_costs4('BOGUS','C','SC','ALL','ALL');
  Dbms_Output.put_line(v_value);
END;
/it gave me (100*(100/100)) + (100*(50/100)) + (100*(25/100)) + (100*(15/100)) + (100*(10/100)) + (100*(5/100)) = 205.
Mike