Generic Data Access For All Class

Question

Hello
I am doing one experiment on Data Access. In traditional system We have to write each Insert, Update, Delete code in data access for each table.
My City Table Class:
public class TbCitiesModel
string _result;
int _cityID;
int _countryID;
string _name;
int _sortOrder;
bool _enable;
DateTime _createDate;
string _countryName;
public string result
get { return _result; }
set { _result = value; }
public int cityID
get { return _cityID; }
set { _cityID = value; }
public int countryID
get { return _countryID; }
set { _countryID = value; }
public string name
get { return _name; }
set { _name = value; }
public int sortOrder
get { return _sortOrder; }
set { _sortOrder = value; }
public bool enable
get { return _enable; }
set { _enable = value; }
public DateTime createDate
get { return _createDate; }
set { _createDate = value; }
public string countryName
get { return _countryName; }
set { _countryName = value; }
Traditional Code:
public List<TbCitiesModel> DisplayCities()
List<TbCitiesModel> lstCities = new List<TbCitiesModel>();
using (SqlConnection connection = GetDatabaseConnection())
using (SqlCommand command = new SqlCommand("STCitiesAll", connection))
command.CommandType = CommandType.StoredProcedure;
SqlDataReader reader = command.ExecuteReader();
while (reader.Read())
lstCities.Add(new TbCitiesModel());
lstCities[lstCities.Count - 1].cityID = Convert.ToInt32(reader["cityID"]);
lstCities[lstCities.Count - 1].countryID = Convert.ToInt32(reader["countryID"]);
lstCities[lstCities.Count - 1].name = Convert.ToString(reader["name"]);
lstCities[lstCities.Count - 1].sortOrder = Convert.ToInt32(reader["sortOrder"]);
lstCities[lstCities.Count - 1].enable = Convert.ToBoolean(reader["enable"]);
lstCities[lstCities.Count - 1].createDate = Convert.ToDateTime(reader["createDate"]);
return lstCities;
The above code is used to fetch all Cities in the table. But when There is another table e.g  "TBCountries" I have to write another method to get all countries. So each time almost same code but just table and parameters are changing.
So decided to work on only one global Method to fetch data from Database.
Generic Code:
public List<T> DisplayCitiesT<T>(T TB, string spName)
var categoryList = new List<T>();
using (SqlConnection connection = GetDatabaseConnection())
using (SqlCommand command = new SqlCommand(spName, connection))
command.CommandType = CommandType.StoredProcedure;
foreach (var prop in TB.GetType().GetProperties())
string Key = prop.Name;
string Value = Convert.ToString(prop.GetValue(TB, null));
if (!string.IsNullOrEmpty(Value) && Value.Contains(DateTime.MinValue.ToShortDateString()) != true)
command.Parameters.AddWithValue("@" + Key, prop.GetValue(TB, null));
SqlDataReader reader = command.ExecuteReader();
while (reader.Read())
int i = 0;
TB = Activator.CreateInstance<T>();
int colCount = reader.FieldCount;
foreach (var prop in TB.GetType().GetProperties())
if (prop.Name != "result" && i <= (colCount - 1))
prop.SetValue(TB, reader[prop.Name], null);
i++;
categoryList.Add(TB);
return categoryList.ToList();
Calling method:
TbCitiesModel c = new TbCitiesModel();
Program p = new Program();
List<TbCitiesModel> lstCities = p.DisplayCitiesT<TbCitiesModel>(c,"STCitiesAll");
foreach (TbCitiesModel item in lstCities)
Console.WriteLine("ID: {0}, Name: {1}", item.cityID, item.name);
Now Its working fine but I have tested with 10,00,000 Records in TBCities Table following are the result.
1. The Traditional method took almost 58 - 59 -  58 - 59 - 59 seconds for 5 time
2. The Generic Method is took 1.4 - 1.3 - 1.5 - 1.4 - 1.4  [minute.seconds]
So by the results of test is generic method is probably slower in performance [because its have 3 foreach loops] but the data is very big almost 10,00,000 lakes records. So it might work good in lower records.
1. So My question is can I used this method for real world applications ?? Or is there any performance optimization for this method?
2. Also we can use this for the ASP.NET C# projects??
Owner | Software Developer at NULLPLEX SOFTWARE SOLUTIONS http://nullplex.com

Answer 1

Hi
Mayur Lohite,
Q1:It is not reasonable compared Generic Code with Traditional Code. The main issue not Generic.
After take a look at your Generic Code.  Reflection code get slower in performance.
TB = Activator.CreateInstance<T>();
As Reflection is truly late bound approach to work with your types, the more Types you have for your single assembly the more slow you go on. Basically few people try to work everything based on Reflection. Using reflection unnecessarily will make your application
very costly.
Here is a good article about this issue, please take a look.
Reflection is Slow or Fast? A Practical Demo
Q2:Or is there any performance optimization for this method?
The article presents some .NET techniques for using Reflection optimally and efficiently.
optimizing object creation with reflection
Note optimize
reflection with Emit
method.
Best regards,
Kristin
We are trying to better understand customer views on social support experience, so your participation in this interview project would be greatly appreciated if you have time. Thanks for helping make community forums a great place.
Click
HERE to participate the survey.
Hello Kristin
Please can you tell how I optimize reflection in my code.
public List<T> DisplayCitiesT<T>(T TB, string spName)
var categoryList = new List<T>();
using (SqlConnection connection = GetDatabaseConnection())
using (SqlCommand command = new SqlCommand(spName, connection))
command.CommandType = CommandType.StoredProcedure;
foreach (var prop in TB.GetType().GetProperties())
string Key = prop.Name;
string Value = Convert.ToString(prop.GetValue(TB, null));
if (!string.IsNullOrEmpty(Value) && Value.Contains(DateTime.MinValue.ToShortDateString()) != true)
command.Parameters.AddWithValue("@" + Key, prop.GetValue(TB, null));
SqlDataReader reader = command.ExecuteReader();
while (reader.Read())
int i = 0;
TB = Activator.CreateInstance<T>();
int colCount = reader.FieldCount;
foreach (var prop in TB.GetType().GetProperties())
if (prop.Name != "result" && i <= (colCount - 1))
prop.SetValue(TB, reader[prop.Name], null);
i++;
categoryList.Add(TB);
return categoryList.ToList();
Thank you.
Owner | Software Developer at NULLPLEX SOFTWARE SOLUTIONS http://nullplex.com