Help changing to prepared statements for mysqli

Question

I am trying to change previously working php pages from mysql to mysqli using prepared statements.
I am having problems with an error message.
Basically the page I have just changed produces a set of database results depending on list menu and check box criteria from user input. I run 2 queries, one to find the total number of records, and the other to retrieve the required subset for pagination. All works fine. However if there are no actual results found from the requested input my php script then uses an includes file which basically runs the same 2 queries but with the user criteria narrowed down so that similar options are presented to the user. This is where my problem lies, for some unknown to me reason the second set of queries is producing no results and an error:
'Attempt to read a row while there is no result set associated with the statement'
If I run the second set of queries without running the first set then the second set works fine so I know that it is not the statements themselves but something in my new code. How can the first set of queries be affecting the results of the second set?
Here is the code below which produces the first 2 queries that work, and below it the same code for the second 2 queries (which is from an 'Includes' file and is the same code exactly except the EXPECTED parameters $expected have been narrowed down in the expected array and list of params for binding).
//list of possible field input by user
$expected = array('location'   => 'text',
                  'type' => 'text',
                  'beds' => 'text',
                  'price' => 'text',
'nbuild'     => 'int',
'resale'     => 'int',
'coastal'    => 'int',
'seaview'    => 'int',
'rural'      => 'int',
'golf'       => 'int',
'ppool'      => 'int',
'comp'       => 'int',                            
'garden'     => 'int',
'terrace'    => 'int',
'aircon'     => 'int',
'heating'    => 'int',
'garage'     => 'int',
'telephone'  => 'int',
'furnished'  => 'int',
'internet'   => 'int',
'dpaid'      => 'int',
'propid'     => 'text');
define('SHOWMAX', 10);
// prepare SQL to get total records
$getTotal = 'SELECT COUNT(*) FROM detailstable JOIN newloctable ON detailstable.location=newloctable.newlocid JOIN typetable ON detailstable.type=typetable.typeid JOIN pricetable ON detailstable.price=pricetable.priceid JOIN bedtable ON detailstable.beds=bedtable.bedid JOIN photossale ON detailstable.detailsid=photossale.propsaleid ';
// Set a flag to indicate whether the query has a WHERE clause
$where = false;
// Loop through the associatiave array of expected search values
foreach ($expected as $var => $type) {
  if (isset($_GET[$var])) {
    $value = trim(urldecode($_GET[$var]));
    if (!empty($value)) {
      // Check if the value begins with > or <
      // If so, use it as the operator, and extract the value
      if ($value[0] == '>' || $value[0] == '<') {
        $operator = $value[0];
        $value = ltrim(substr($value, 1));
      } elseif (strtolower($type) != 'like') {
        $operator = '=';
      // Check if the WHERE clause has been added yet
      if ($where) {
        $getTotal .= ' AND ';
      } else {
        $getTotal .= ' WHERE ';
        $where = true;
      // Build the SQL query using the right operator and data type
       $type = strtolower($type);
      switch($type) {
        case 'like':
          $getTotal .= "`$var` LIKE ? ";
          break;
        case 'int':
        case 'double':
        case 'date':
          $getTotal .= "`$var` $operator ? ";
          break;
        default:
        $getTotal .= "`$var` = ? ";
$getTotal .= ' ORDER BY ABS(detailstable.trueprice), bedtable.number, detailstable.propid ASC';
$stmt = $conn->stmt_init();
if ($stmt->prepare($getTotal)) {
$params = array($_GET['location'], $_GET['type'], $_GET['beds'], $_GET['price'], $_GET['nbuild'], $_GET['resale'], $_GET['coastal'], $_GET['seaview'], $_GET['rural'], $_GET['golf'], $_GET['ppool'], $_GET['comp'], $_GET['garden'], $_GET['terrace'],
$_GET['aircon'], $_GET['heating'], $_GET['garage'], $_GET['telephone'], $_GET['furnished'], $_GET['internet'], $_GET['dpaid'], $_GET['propid']);
$params = array_filter($params);
$params = array_values($params);
if (!empty($params)) {
            $types = '';
            foreach($params as $param) {
                // set param type
                if (is_string($param)) {
                    $types .= 's';  // strings
                } else if (is_int($param)) {
                    $types .= 'i';  // integer
                } else if (is_float($param)) {
                    $types .= 'd';  // double
                } else {
                    $types .= 'b';  // default: blob and unknown types
            $bind_names[] = $types;
            for ($i=0; $i<count($params);$i++) {
                $bind_name = 'bind' . $i;      
                $$bind_name = $params[$i];     
$bind_names[] = &$$bind_name;  
call_user_func_array(array(&$stmt,'bind_param'),$bind_names);
$stmt->execute();
$stmt->store_result();
$stmt->bind_result($total);
$stmt->fetch();
// sort paging
$totalRecords = $total;
$stmt->free_result();
$stmt->close();
// check that there is at least 1 result and if there is do the second part of the search
// if there is no result then I skip this second bit of code
if($totalRecords > '0') {
// check current page
if (isset($_GET['curPage'])) {
$curPage = $_GET['curPage'];
} else {
$curPage = 0;
// calculate the start row of the subset
$startRow = $curPage * SHOWMAX;        
$sql = "SELECT DISTINCT detailsid, trueprice, reduced, offers, `desc`, `propid`, `bathrooms`, `location`, `type`, `price`, `beds`, photossale.photo1, newloctable.newloc,   typetable.style, bedtable.`number` FROM detailstable JOIN newloctable ON detailstable.location=newloctable.newlocid JOIN typetable ON detailstable.type=typetable.typeid JOIN pricetable ON detailstable.price=pricetable.priceid JOIN bedtable ON detailstable.beds=bedtable.bedid JOIN photossale ON detailstable.detailsid=photossale.propsaleid ";
// Set a flag to indicate whether the query has a WHERE clause
$where = false;
// Loop through the associatiave array of expected search values
foreach ($expected as $var => $type) {
  if (isset($_GET[$var])) {
    $value = trim(urldecode($_GET[$var]));
    if (!empty($value)) {
      // Check if the value begins with > or <
      // If so, use it as the operator, and extract the value
      if ($value[0] == '>' || $value[0] == '<') {
        $operator = $value[0];
        $value = ltrim(substr($value, 1));
      } elseif (strtolower($type) != 'like') {
        $operator = '=';
      // Check if the WHERE clause has been added yet
      if ($where) {
        $sql .= ' AND ';
      } else {
        $sql .= ' WHERE ';
        $where = true;
      // Build the SQL query using the right operator and data type
       $type = strtolower($type);
      switch($type) {
        case 'like':
          $sql .= "`$var` LIKE  ? ";
          break;
        case 'int':
        case 'double':
        case 'date':
          $sql .= "`$var` $operator ? ";
          break;
        default:
        $sql .= "`$var` = ? ";
$sql .= " ORDER BY ABS(detailstable.trueprice), bedtable.number, detailstable.propid ASC LIMIT $startRow," . SHOWMAX;
$stmt = $conn->stmt_init();
if ($stmt->prepare($sql)) {
$nextparams = $params;
if (!empty($nextparams)) {
            $nexttypes = '';
foreach($nextparams as $nextparam) {
                // set param type
                if (is_string($nextparam)) {
$nexttypes .= 's';  // strings
                } else if (is_int($nextparam)) {
$nexttypes .= 'i';  // integer
                } else if (is_float($nextparam)) {
$nexttypes .= 'd';  // double
                } else {
$nexttypes .= 'b';  // default: blob and unknown types
            $newbind_names[] = $nexttypes;
            for ($i=0; $i<count($nextparams);$i++) {
$newbind_name = 'bind' . $i;      
$$newbind_name = $nextparams[$i];
$newbind_names[] = &$$newbind_name;
call_user_func_array(array(&$stmt,'bind_param'),$newbind_names);
$stmt->execute();
$stmt->store_result();
$stmt->bind_result($detailsid, $trueprice, $reduced, $offers, $desc, $propid, $bathrooms, $location, $type, $price, $beds, $photo1, $newloc, $style, $bednumber);
$numRows = $stmt->num_rows;
If a result was found in the part that checks the numbers of records then the second query is run and displayed using : while ($stmt->fetch()) { ...... to display the results and then I use $stmt->free_result();
$stmt->close();
All fine no problems.
If the first query did not find a result then the second query is skipped and instead the script then uses a php includes file with exactly the same script as above except the expected params are narrowed as below: THIS IS WHEN I GET NO RESULTS – when I do expect to get a result) AND AN ERROR OF :
Attempt to read a row while there is no result set associated with the statement.
Yet if I run the includes file and skip the whole of the above code the code in the includes file find the result no problem. Anyway code below:
$expected = array('location'   => 'text',
                  'type' => 'text',
                  'beds' => 'text',
                  'price' => 'text',
'dpaid'      => 'int',
'propid'     => 'text');
define('SHOWMAX', 10);
// prepare SQL to get total records
$getTotal = 'SELECT COUNT(*) FROM detailstable JOIN newloctable ON detailstable.location=newloctable.newlocid JOIN typetable ON detailstable.type=typetable.typeid JOIN pricetable ON detailstable.price=pricetable.priceid JOIN bedtable ON detailstable.beds=bedtable.bedid JOIN photossale ON detailstable.detailsid=photossale.propsaleid ';
// Set a flag to indicate whether the query has a WHERE clause
$where = false;
// Loop through the associatiave array of expected search values
foreach ($expected as $var => $type) {
  if (isset($_GET[$var])) {
    $value = trim(urldecode($_GET[$var]));
    if (!empty($value)) {
      // Check if the value begins with > or <
      // If so, use it as the operator, and extract the value
      if ($value[0] == '>' || $value[0] == '<') {
        $operator = $value[0];
        $value = ltrim(substr($value, 1));
      } elseif (strtolower($type) != 'like') {
        $operator = '=';
      // Check if the WHERE clause has been added yet
      if ($where) {
        $getTotal .= ' AND ';
      } else {
        $getTotal .= ' WHERE ';
        $where = true;
      // Build the SQL query using the right operator and data type
       $type = strtolower($type);
      switch($type) {
        case 'like':
          $getTotal .= "`$var` LIKE ? ";
          break;
        case 'int':
        case 'double':
        case 'date':
          $getTotal .= "`$var` $operator ? ";
          break;
        default:
        $getTotal .= "`$var` = ? ";
$getTotal .= ' ORDER BY ABS(detailstable.trueprice), bedtable.number, detailstable.propid ASC';
$stmt = $conn->stmt_init();
if ($stmt->prepare($getTotal)) {
$params = array($_GET['location'], $_GET['type'], $_GET['beds'], $_GET['price'], $_GET['dpaid'], $_GET['propid']);
$params = array_filter($params);
$params = array_values($params);
if (!empty($params)) {
            $types = '';
            foreach($params as $param) {
                // set param type
                if (is_string($param)) {
                    $types .= 's';  // strings
                } else if (is_int($param)) {
                    $types .= 'i';  // integer
                } else if (is_float($param)) {
                    $types .= 'd';  // double
                } else {
                    $types .= 'b';  // default: blob and unknown types
            $bind_names[] = $types;
            for ($i=0; $i<count($params);$i++) {
                $bind_name = 'bind' . $i;      
                $$bind_name = $params[$i];     
$bind_names[] = &$$bind_name;  
call_user_func_array(array(&$stmt,'bind_param'),$bind_names);
$stmt->execute();
$stmt->store_result();
$stmt->bind_result($total);
$stmt->fetch();
// sort paging
$totalRecords2 = $total;
echo $stmt->error;
$stmt->free_result();
$stmt->close();
// there is a result get the subset
if($totalRecords2 > '0') {
// check current page
if (isset($_GET['curPage'])) {
$curPage = $_GET['curPage'];
} else {
$curPage = 0;
// calculate the start row of the subset
$startRow = $curPage * SHOWMAX;        
$sql = "SELECT DISTINCT detailsid, trueprice, reduced, offers, `desc`, `propid`, `bathrooms`, `location`, `type`, `price`, `beds`, photossale.photo1, newloctable.newloc,   typetable.style, bedtable.`number` FROM detailstable JOIN newloctable ON detailstable.location=newloctable.newlocid JOIN typetable ON detailstable.type=typetable.typeid JOIN pricetable ON detailstable.price=pricetable.priceid JOIN bedtable ON detailstable.beds=bedtable.bedid JOIN photossale ON detailstable.detailsid=photossale.propsaleid ";
// Set a flag to indicate whether the query has a WHERE clause
$where = false;
// Loop through the associatiave array of expected search values
foreach ($expected as $var => $type) {
  if (isset($_GET[$var])) {
    $value = trim(urldecode($_GET[$var]));
    if (!empty($value)) {
      // Check if the value begins with > or <
      // If so, use it as the operator, and extract the value
      if ($value[0] == '>' || $value[0] == '<') {
        $operator = $value[0];
        $value = ltrim(substr($value, 1));
      } elseif (strtolower($type) != 'like') {
        $operator = '=';
      // Check if the WHERE clause has been added yet
      if ($where) {
        $sql .= ' AND ';
      } else {
        $sql .= ' WHERE ';
        $where = true;
      // Build the SQL query using the right operator and data type
       $type = strtolower($type);
      switch($type) {
        case 'like':
          $sql .= "`$var` LIKE  ? ";
          break;
        case 'int':
        case 'double':
        case 'date':
          $sql .= "`$var` $operator ? ";
          break;
        default:
        $sql .= "`$var` = ? ";
$sql .= " ORDER BY ABS(detailstable.trueprice), bedtable.number, detailstable.propid ASC LIMIT $startRow," . SHOWMAX;
$stmt = $conn->stmt_init();
if ($stmt->prepare($sql)) {
$nextparams = $params;
if (!empty($nextparams)) {
            $nexttypes = '';
foreach($nextparams as $nextparam) {
                // set param type
                if (is_string($nextparam)) {
$nexttypes .= 's';  // strings
                } else if (is_int($nextparam)) {
$nexttypes .= 'i';  // integer
                } else if (is_float($nextparam)) {
$nexttypes .= 'd';  // double
                } else {
$nexttypes .= 'b';  // default: blob and unknown types
            $newbind_names[] = $nexttypes;
            for ($i=0; $i<count($nextparams);$i++) {
$newbind_name = 'bind' . $i;      
$$newbind_name = $nextparams[$i];
$newbind_names[] = &$$newbind_name;
call_user_func_array(array(&$stmt,'bind_param'),$newbind_names);
$stmt->execute();
$stmt->store_result();
$stmt->bind_result($detailsid, $trueprice, $reduced, $offers, $desc, $propid, $bathrooms, $location, $type, $price, $beds, $photo1, $newloc, $style, $bednumber);
$numRows = $stmt->num_rows;
Again here I would then display the results before closing and freeing the stmt or display a message to say there were no results found from the criteria. But instead I get the error message and echoing the value of $totalRecords2 is empty.
I have been pulling my hair out for days and days over this and as it is one of the first pages I am converting from mysql to mysqli I wonder if I am missing something very obvious to someone with more experience with the code.  I will be very grateful for any help, thank you in advance.

Answer 1

You have intel graphics, that means the graphics cannot be upgraded.
Welcome to the Toshiba user forums.
For those of you who do not know what a user forum is, it is a community of users who volunteer time to help other users. Anyone can participate. It's 100% voluntary.
Being super active is never a requirement