Help Converting old AS2 code to AS3

Question

I just updated an old flash file with some new photos.  I don't know much about Flash - enough to change the photos and hit export BUT now I'm getting errors.  I had a _root issue which I fixed thanks to this forum but I'm still getting these errors:
Scene 1, Layer 'Actions', Frame 3, Line 14, Column 2
1120: Access of undefined property timer1.
Scene 1, Layer 'Actions', Frame 3, Line 18, Column 2
1120: Access of undefined property i.
Scene 1, Layer 'Actions', Frame 3, Line 29, Column 2
1120: Access of undefined property timer2.
Scene 1, Layer 'Actions', Frame 3, Line 33, Column 35
1120: Access of undefined property i.
Scene 1, Layer 'Actions', Frame 3, Line 34, Column 5
1120: Access of undefined property i.
Scene 1, Layer 'Actions', Frame 3, Line 35, Column 17
1120: Access of undefined property timer2.
Scene 1, Layer 'Actions', Frame 3, Line 40, Column 2
1120: Access of undefined property i.
Scene 1, Layer 'Actions', Frame 3, Line 40, Column 6
1120: Access of undefined property i.
Scene 1, Layer 'Actions', Frame 3, Line 44, Column 16
1120: Access of undefined property timer1.
Preloader, Layer 'Actions', Frame 1, Line 1, Column 1
1120: Access of undefined property bytes_loaded.
Preloader, Layer 'Actions', Frame 1, Line 2, Column 1
1120: Access of undefined property bytes_total.
Preloader, Layer 'Actions', Frame 1, Line 3, Column 1
1120: Access of undefined property getPercent.
Preloader, Layer 'Actions', Frame 1, Line 3, Column 14
1120: Access of undefined property bytes_loaded.
Preloader, Layer 'Actions', Frame 1, Line 3, Column 27
1120: Access of undefined property bytes_total.
Preloader, Layer 'Actions', Frame 1, Line 4, Column 25
1120: Access of undefined property getPercent.
Preloader, Layer 'Actions', Frame 1, Line 5, Column 30
1120: Access of undefined property getPercent.
Preloader, Layer 'Actions', Frame 1, Line 7, Column 5
1120: Access of undefined property bytes_loaded.
Preloader, Layer 'Actions', Frame 1, Line 7, Column 21
1120: Access of undefined property bytes_total.
Preloader, Layer 'Actions', Frame 1, Line 8, Column 24
1067: Implicit coercion of a value of type int to an unrelated type String.
I didn't originally write the code and I don't know nearly enough about Flash to fix them.  Here's the code:
stop();
var fadeSpeed = 40; //Sets fad-in speed of images, default is 30
var imageTime = 5; //Sets time each image is on screen, in seconds
MovieClip(root).attachMovie("mc_Images", "mcFader", 10, {x:0, y:0});
MovieClip(root).mcFader._alpha = 0;
MovieClip(root).mcFader._visible = false;
var imageNum = 1;
startShow();
function startShow(){
          timer1 = setInterval(loadImage, imageTime * 1000);
function loadImage(){
          i = 0;
          imageNum ++;
          if(imageNum == MovieClip(root).mcImages._totalFrames + 1){
                    imageNum = 1;
          MovieClip(root).mcImages._x = 0;
          MovieClip(root).mcImages._y = 0;
          MovieClip(root).mcFader._alpha = 0;
          MovieClip(root).mcFader._visible = true;
          MovieClip(root).mcFader.gotoAndStop(imageNum);
          MovieClip(root).nextImage = imageNum;
          timer2 = setInterval(fadeImage, fadeSpeed);
function fadeImage(){
          MovieClip(root).mcFader._alpha = i;
          if(i > 100){
                    clearInterval(timer2);
                    MovieClip(root).mcImages.gotoAndStop(MovieClip(root).nextImage);
                    MovieClip(root).mcFader._alpha = 0;
                    MovieClip(root).mcFader._visible = false;
          i = i + 10;
function goLink(fNum){
          clearInterval(timer1);
          MovieClip(root).mcImages.gotoAndStop(fNum);
ANY help would be GREATLY appreciated!! 

Answer 1

Ok, I researched a little.
The variable i is set to 0 in loadImage, which is called by a timed out function startShow, which is called directly.
So I was right to surmise I=0, but you don't even need to define it yet.
If you add
var i;
var timer1,timer2;
to the top of the program, all the variables are defined globally, which as far as I can see is the intention.
That leaves me with one undefined variable and curious syntax:
r36:
this.mcImages.gotoAndStop(this.nextImg age);
What is intended here? Age is never defined. I guess it might be defined by Flashvars, as in as2, these would be accesible as a root variable, but this doesn't mean much to me. I'd expect something like this.nextImg+age or something.
So I searched again: nextImg is not defined but I found this.nextImage = imageNum;
So there is just a space that got in there somehow.
Fixed that and it compiles, but immeadeately after compilation you get a problem with attachMovie
this.attachMovie("mc_Images", "mcFader", 10, {x:0, y:0});
This is a as2 way of taking things out of your library and placing them as a child of another.
The new way to do that is to make a clip accessible in your library and then instantiate a new class with:
var mcFader:mc_Images= new mc_Images();
this.setChildIndex(mcFader,10);
mcFader.x=0; // this is not needed, as it is default, as it was in as2, so it was obsolete there as well!
mcFader.y=0;// this is not needed, as it is default, as it was in as2, so it was obsolete there as well!
this.addChild(mcFader);
There are some other issues after that,
I would have to look at the source to fix them, because they have to do with the structure of mc_images. Which is not in code, but in your library.
The whole code would the look like this:
stop();
var fadeSpeed = 40; //Sets fad-in speed of images, default is 30
var imageTime = 5; //Sets time each image is on screen, in seconds
var mcFader:mc_Images= new mc_Images();
this.setChildIndex(mcFader,10);
mcFader.x=0; // this is not needed, as it is default, as it was in as2, so it was obsolete there as well!
mcFader.y=0;// this is not needed, as it is default, as it was in as2, so it was obsolete there as well!
this.addChild(mcFader);
this.mcFader._alpha = 0;
this.mcFader._visible = false;
var imageNum = 1;
var i=0;
var timer1,timer2;
startShow();
function startShow(){
         timer1 = setInterval(loadImage, imageTime * 1000);
function loadImage(){
          i = 0;
          imageNum ++;
          if(imageNum == this.mcImages._totalFrames + 1){
                    imageNum = 1;
          this.mcImages._x = 0;
          this.mcImages._y = 0;
          this.mcFader._alpha = 0;
          this.mcFader._visible = true;
          this.mcFader.gotoAndStop(imageNum);
          this.nextImage = imageNum;
          var timer2 = setInterval(fadeImage, fadeSpeed);
function fadeImage(){
          this.mcFader._alpha = i;
          if(i > 100){
                    clearInterval(timer2);
                    this.mcImages.gotoAndStop(this.nextImgage);
                    this.mcFader._alpha = 0;
                    this.mcFader._visible = false;
          i = i + 10;
function goLink(fNum){
          clearInterval(timer1);
          this.mcImages.gotoAndStop(fNum);
jencreates wrote:
I just updated an old flash file with some new photos.  I don't know much about Flash - enough to change the photos and hit export BUT now I'm getting errors.  I had a _root issue which I fixed thanks to this forum but I'm still getting these errors:
Scene 1, Layer 'Actions', Frame 3, Line 14, Column 2
1120: Access of undefined property timer1.
Scene 1, Layer 'Actions', Frame 3, Line 18, Column 2
1120: Access of undefined property i.
Scene 1, Layer 'Actions', Frame 3, Line 29, Column 2
1120: Access of undefined property timer2.
Scene 1, Layer 'Actions', Frame 3, Line 33, Column 35
1120: Access of undefined property i.
Scene 1, Layer 'Actions', Frame 3, Line 34, Column 5
1120: Access of undefined property i.
Scene 1, Layer 'Actions', Frame 3, Line 35, Column 17
1120: Access of undefined property timer2.
Scene 1, Layer 'Actions', Frame 3, Line 40, Column 2
1120: Access of undefined property i.
Scene 1, Layer 'Actions', Frame 3, Line 40, Column 6
1120: Access of undefined property i.
Scene 1, Layer 'Actions', Frame 3, Line 44, Column 16
1120: Access of undefined property timer1.
Preloader, Layer 'Actions', Frame 1, Line 1, Column 1
1120: Access of undefined property bytes_loaded.
Preloader, Layer 'Actions', Frame 1, Line 2, Column 1
1120: Access of undefined property bytes_total.
Preloader, Layer 'Actions', Frame 1, Line 3, Column 1
1120: Access of undefined property getPercent.
Preloader, Layer 'Actions', Frame 1, Line 3, Column 14
1120: Access of undefined property bytes_loaded.
Preloader, Layer 'Actions', Frame 1, Line 3, Column 27
1120: Access of undefined property bytes_total.
Preloader, Layer 'Actions', Frame 1, Line 4, Column 25
1120: Access of undefined property getPercent.
Preloader, Layer 'Actions', Frame 1, Line 5, Column 30
1120: Access of undefined property getPercent.
Preloader, Layer 'Actions', Frame 1, Line 7, Column 5
1120: Access of undefined property bytes_loaded.
Preloader, Layer 'Actions', Frame 1, Line 7, Column 21
1120: Access of undefined property bytes_total.
Preloader, Layer 'Actions', Frame 1, Line 8, Column 24
1067: Implicit coercion of a value of type int to an unrelated type String.
I didn't originally write the code and I don't know nearly enough about Flash to fix them.  Here's the code:
stop();
var fadeSpeed = 40; //Sets fad-in speed of images, default is 30
var imageTime = 5; //Sets time each image is on screen, in seconds
MovieClip(root).attachMovie("mc_Images", "mcFader", 10, {x:0, y:0});
MovieClip(root).mcFader._alpha = 0;
MovieClip(root).mcFader._visible = false;
var imageNum = 1;
startShow();
function startShow(){
          timer1 = setInterval(loadImage, imageTime * 1000);
function loadImage(){
          i = 0;
          imageNum ++;
          if(imageNum == MovieClip(root).mcImages._totalFrames + 1){
                    imageNum = 1;
          MovieClip(root).mcImages._x = 0;
          MovieClip(root).mcImages._y = 0;
          MovieClip(root).mcFader._alpha = 0;
          MovieClip(root).mcFader._visible = true;
          MovieClip(root).mcFader.gotoAndStop(imageNum);
          MovieClip(root).nextImage = imageNum;
          timer2 = setInterval(fadeImage, fadeSpeed);
function fadeImage(){
          MovieClip(root).mcFader._alpha = i;
          if(i > 100){
                    clearInterval(timer2);
                    MovieClip(root).mcImages.gotoAndStop(MovieClip(root).nextIm age);
                    MovieClip(root).mcFader._alpha = 0;
                    MovieClip(root).mcFader._visible = false;
          i = i + 10;
function goLink(fNum){
          clearInterval(timer1);
          MovieClip(root).mcImages.gotoAndStop(fNum);
ANY help would be GREATLY appreciated!!