Help in FOr cursor -

Question

hi all,
The follwoing is my req - Below the written proc - can anyone check it is correct .
1.     Write a procedure to compute the following using FOR cursor. Procedure should take 3 parameters. Empno - IN parameter, Empno IN parameter and this can be a default parameter. The OUT parameter should return the total cost to the company.
DA = 15% of sal
HRA = 20% of sal
TA = 8% of sal
Special Allowance will be decided based on the service in the company
< 1 year                Nil
1 year and < 2 years      10% of salSrividhya Maha...     >2 years and < 4 years      15% of sal
5 years           20% of salcreate or replace procedure testing(p_empno in number default 10,v_cost out number)
as
v_salary number;
v_months number;
cursor mycur is
  SELECT salary from emp where empno = p_empno;
begin
for emp_rec in mycur
LOOP
SELECT round(months_between(sysdate,hire_date))into v_months from emp
  WHERE empno= p_empno;
IF v_months < 12 then
v_salary := salary *12;
elsif
v_months >12 and v_months <24
v_salary := salary *12;
dbms_output.put_line('employee salary'||15/100*salary+20/100*salary+
                                   8/100*salary +v_salary);
end if;
end loop;
end;
[\pre]
cheers                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                           

Answer 1

1) consider using FUNCTION to return the cost result, rather than an out parameter; that would allow you to call it in SQL (for example in an UPDATE)
2) Your requirement says THREE parameters - but one of them is EMPNO (twice)
3) Why allow default of EMPNO to 10?
4) You have used ROUND - that means 11.6 months is treated as 1 year. You should use FLOOR instead (or jus compare real numbers)
5) Your requriement leaves out 4-5 years service entirely - was that intentional?
6) The whole section is incorrect:
- refer to cursor variables using the record name, eg:
v_salary := emp_rec.salary * 12;
- You have assigned to local variable v_salary, but not to OUT variable v_cost.
- your DBMS_OUTPUT.PUT_LINE gives you salary * (0.15+0.2+0.08) = 0.43*salary - why?
7) You could put the whole thing into a single piece of SQL
SELECT case
              when months_between(sysdate,hire_date) < 12.0 then null
              when months_between(sysdate,hire_date) < 24.0 then 0.10
              when months_between(sysdate,hire_date) < 48.0 then 0.15
              when months_between(sysdate,hire_date) >= 60.0 then 0.20
             else null
             end * salary  "Allowance"
from   emp
where {your where clause}
/(multiply by 12 if salary is monthly and you need annual allowance).
HTH
Regards Nigel