Help with bug

Question

Hello there,
I ve been trying to find an error in my code for several days with no success. Can anyone help me please?
I have used a JPasswordField to enter a password to recognize a user.
The class below uses the findUser method to find a user according to its user number aUserNo.
import java.util.*;
public class RestaurantLogInOut {
ArrayList users = new ArrayList();
char[] waiterPassword = {};
char[] managerPassword = {'3','3','3'};
public RestaurantLogInOut() {
users.add(new Waiter("MAX","10", waiterPassword));
users.add(new Waiter("TOM","11", waiterPassword));
users.add(new Waiter("KAYE","12", waiterPassword));
//the class Manager is a subclass of Waiter//
users.add(new Manager("ELLI", "1", managerPassword));
public Waiter findUser (String aUserNo) {
for (int i=0; i < users.size(); i++) {
Waiter aWaiter = (Waiter ) users.get(i);
if (aWaiter.getServerNo().equals(aUserNo))
return aWaiter;
return null;
When I click on the button that checks the password the following code is fired:
void passwordButton_actionPerformed(ActionEvent e) {
aWaiter = aRest.findUser(userNoTextField.getText());
serverPassword = aWaiter.getPassword();
String aString = new String(serverPassword);
System.out.println("The manager name is: "+ aWaiter.getServerName());
System.out.println("The manager user number is: "+ aWaiter.getServerNo());
System.out.println("The manager password is: "+ aString);
char[] inputPassword = passwordField.getPassword();
String bString = new String(inputPassword);
System.out.println("The input password is: "+ bString );
if(aWaiter.isPasswordCorrect(passwordField.getPassword(), serverPassword))
System.out.println("Password OK ");
else
JOptionPane.showMessageDialog(this,
"Incorrect password. Please re-enter password.",
"Input error",
JOptionPane.ERROR_MESSAGE);
//this method checks that the manager password and the input password match//
public boolean isPasswordCorrect(char[] input, char[] aServerPassword) {
boolean isCorrect = true;
if (input.length != aServerPassword.length) {
isCorrect = false;
} else {
for (int i = 0; i < input.length; i++) {
if (input[i] != aServerPassword) {
isCorrect = false;
//Zero out the password.
for (int i = 0; i < aServerPassword.length; i++) {
aServerPassword[i] = 0;
return isCorrect;
When I enter the wrong password for example: '2','2','2'
I get the correct output:
The manager name is: ELLI
The manager user number is: 1
The manager password is: 333
The input password is: 222
However if I attempt to re enter the correct password the manager password is not there anymore:
The manager name is: ELLI
The manager user number is: 1
The manager password is:
The input password is: 333
Can anyone explain to me what I am doing wrong?
Thanks a lot.
Max

Answer 1

Use code tags please
Your code is long enough - its even harder to read without the tags.
import java.util.*;
public class RestaurantLogInOut {
ArrayList users = new ArrayList();
char[] waiterPassword = {};
char[] managerPassword = {'3','3','3'};
public RestaurantLogInOut() {
users.add(new Waiter("MAX","10", waiterPassword));
users.add(new Waiter("TOM","11", waiterPassword));
users.add(new Waiter("KAYE","12", waiterPassword));
//the class Manager is a subclass of Waiter//
users.add(new Manager("ELLI", "1", managerPassword));
public Waiter findUser (String aUserNo) {
for (int i=0; i < users.size(); i++) {
Waiter aWaiter = (Waiter ) users.get(i);
if (aWaiter.getServerNo().equals(aUserNo))
return aWaiter;
return null;
When I click on the button that checks the password the following code is fired:
void passwordButton_actionPerformed(ActionEvent e) {
aWaiter = aRest.findUser(userNoTextField.getText());
serverPassword = aWaiter.getPassword();
String aString = new String(serverPassword);
System.out.println("The manager name is: "+ aWaiter.getServerName());
System.out.println("The manager user number is: "+ aWaiter.getServerNo());
System.out.println("The manager password is: "+ aString);
char[] inputPassword = passwordField.getPassword();
String bString = new String(inputPassword);
System.out.println("The input password is: "+ bString );
if(aWaiter.isPasswordCorrect(passwordField.getPassword(), serverPassword))
System.out.println("Password OK ");
else
JOptionPane.showMessageDialog(this,
"Incorrect password. Please re-enter password.",
"Input error",
JOptionPane.ERROR_MESSAGE);
//this method checks that the manager password and the input password match//
public boolean isPasswordCorrect(char[] input, char[] aServerPassword) {
boolean isCorrect = true;
if (input.length != aServerPassword.length) {
isCorrect = false;
} else {
for (int i = 0; i < input.length; i++) {
if (input != aServerPassword) {
isCorrect = false;
//Zero out the password.
for (int i = 0; i < aServerPassword.length; i++) {
aServerPassword = 0;
return isCorrect;
}