Help with util.zip up files... does not work

Question

I am writing a program so my mum can zip up new photos she takes and then send them to me. The program creates a html file for the webpage plus a smaller version of her original photo and places them all in a 1 folder with a new name. Al this part works... I want to afterwards place my files in a zipped up folder that she can e-mail me with her normal client. How... I picked up this code on the net and have changed it to incoporate my parameters. The files which are created ..paths are (String in an String[]) I then send to my zipping method.
The zip file is created but does not work when I try to extract from it ??? I also know that the String [] works becuse I have made a loop to check its properties at each index.
what am I doing wrong?
This is a modified code I found on the internet but with no author??
import java.io.File;
import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.IOException;
import java.util.zip.ZipEntry;
import java.util.zip.*;
public class Test{
    private File zipDir;
    private String[] filename;
    public Test(String[] recivedFilename){
        filename = recivedFilename;
        try {
            ZipOutputStream zos = new
                    ZipOutputStream(new FileOutputStream("c:\\curDir.zip"));
            from,
            zipDir("c:\\batviapictures\\", zos);
            zos.close();
        } catch(Exception e) {
            //handle exception
    public void zipDir(String dir2zip, ZipOutputStream zos) {
        try {File
            zipDir = new File(dir2zip);
            String[] dirList = filename;
            byte[] readBuffer = new byte[2156];
            int bytesIn = 0;
            //loop through dirList, and zip the files
            for(int i=0; i<dirList.length; i++) {
                File f = new File(zipDir, dirList);
if(f.isDirectory()) {
String filePath = f.getPath();
zipDir(filePath, zos);
continue;
FileInputStream fis = new FileInputStream(f);
ZipEntry anEntry = new ZipEntry(f.getPath());
zos.putNextEntry(anEntry);
while((bytesIn = fis.read(readBuffer)) != -1) {
zos.write(readBuffer, 0, bytesIn);
fis.close();
catch(Exception e) {

Answer 1

I make no guarantees that this will completely solve all your problems, but I just know these calls are needed but missing from your OP:
try {
    ZipOutputStream zos = new
                    ZipOutputStream(new FileOutputStream("c:\\curDir.zip"));
                    from,
                    zipDir("c:\\batviapictures\\", zos);
    zos.flush(); // ADD THIS after all files have been written to the zos
    zos.close();
} catch(Exception e) {
    //handle exception
}And
while((bytesIn = fis.read(readBuffer)) != -1) {
    zos.write(readBuffer, 0, bytesIn);
zos.closeEntry(); // ADD THIS after each file is written to the zos
fis.close();