Hi CPU usage in ABAP coding

Question

Hello,
I have a custom program (programmed by somebody else) which is churning away all day long and consuming between 50% and 70% CPU as seen in the 'top' command. I'm on HP-UX with 8 CPUs installed. The CPU usage is consistently at this level. (I matched the PID from SM50 with the PID in 'top')
I ran abap traces in ST12 which found that between 60% and 70% of the time was spent in the following coding:
773       IF SY-SUBRC <> 0.
774         LOOP AT GIT_ZTABLEA TRANSPORTING NO FIELDS
775           WHERE KUNNR      =  PC_KUNNR     "CUSTOMER CODEﾞ
776             AND ZZVCGRTNFG IN P_DRTNFG     "FLAGﾞ(SELECTION CRITEREA)
777             AND ZZVCGSTPFG IN P_DSPDFG .   "QUIT FLAGﾞ(SELECTION CRITEREA)
778           EXIT.
779         ENDLOOP .
780                                                                               
781     *  
782         PI_SUBRC = SY-SUBRC .
783         RETURN .
784                                                                               
785     *
786       ELSE.
787         LOOP AT GIT_ZTABLEA TRANSPORTING NO FIELDS
788           WHERE ZZVCGGRPID =  GFC_TABLEB-ZZVCGGRPID "GROUP ID
789             AND ZZVCGRTNFG IN P_DRTNFG               "FLAGﾞ(SELECTION CRITEREA)
790             AND ZZVCGSTPFG IN P_DSPDFG.              "STOP FLAGﾞ(SELECTION CRITEREA)
791           EXIT.
792         ENDLOOP .
I guess the idea here is to just find the number of rows in GIT_ZTABLEA for certain conditions.
Is there a simple and less intensive way of achieving this?
(apologies in advance for foreseen dumb questions. I'm very new to coding).
Peter

Answer 1

> LOOP AT GIT_ZTABLEA TRANSPORTING NO FIELDS
> 775 WHERE KUNNR = PC_KUNNR "CUSTOMER CODEﾞ
> 776 AND ZZVCGRTNFG IN P_DRTNFG "FLAGﾞ(SELECTION CRITEREA)
> 777 AND ZZVCGSTPFG IN P_DSPDFG . "QUIT FLAGﾞ(SELECTION CRITEREA)
sorted table ... is the usual answer but not in this case.
You should check the IN P_DRTNFG "FLAGﾞ(SELECTION CRITEREA) ?
What does it mean? I don`t undterstand the flag.
With the IN conditions I doubt that there is any optimziation possible, it will always scan.
If the two IN-flag are really flags then it should be possible to write equal condition
and get something
  WHERE k = a AND z1 = b AND z2 = c.
The can be solved with sorted tables.
And from the coding you show with will exit after the first solution, so a READ would then also
be enough. The LOOP is only used because the WHERE is only possible with the LOOP.
but a LOOP is not really necessary because it check only the first solution.
So please revise the logic.
Then it will become really fast.
Siegfried