How equals and hashCode fail here?

Question

I have a set of Address objects. The pair of equals and hashCode are generated by Eclipse as the following:
     @Override
     public int hashCode() {
          final int prime = 31;
          int result = super.hashCode();
          result = prime * result + ((city == null) ? 0 : city.hashCode());
          result = prime * result
                    + ((cityCode == null) ? 0 : cityCode.hashCode());
          result = prime * result + ((country == null) ? 0 : country.hashCode());
          result = prime * result + ((entry == null) ? 0 : entry.hashCode());
          result = prime * result + ((number == null) ? 0 : number.hashCode());
          result = prime * result + ((phone == null) ? 0 : phone.hashCode());
          result = prime * result
                    + ((postalCode == null) ? 0 : postalCode.hashCode());
          result = prime * result
                    + ((province == null) ? 0 : province.hashCode());
          result = prime * result + ((street == null) ? 0 : street.hashCode());
          return result;
     /* (non-Javadoc)
      * @see java.lang.Object#equals(java.lang.Object)
     @Override
     public boolean equals(Object obj) {
          if (this == obj)
               return true;
          if (!super.equals(obj))
               return false;
          if (getClass() != obj.getClass())
               return false;
          final AddressEntity other = (AddressEntity) obj;
          if (city == null) {
               if (other.city != null)
                    return false;
          } else if (!city.equals(other.city))
               return false;
          if (cityCode == null) {
               if (other.cityCode != null)
                    return false;
          } else if (!cityCode.equals(other.cityCode))
               return false;
          if (country == null) {
               if (other.country != null)
                    return false;
          } else if (!country.equals(other.country))
               return false;
          if (entry == null) {
               if (other.entry != null)
                    return false;
          } else if (!entry.equals(other.entry))
               return false;
          if (number == null) {
               if (other.number != null)
                    return false;
          } else if (!number.equals(other.number))
               return false;
          if (phone == null) {
               if (other.phone != null)
                    return false;
          } else if (!phone.equals(other.phone))
               return false;
          if (postalCode == null) {
               if (other.postalCode != null)
                    return false;
          } else if (!postalCode.equals(other.postalCode))
               return false;
          if (province == null) {
               if (other.province != null)
                    return false;
          } else if (!province.equals(other.province))
               return false;
          if (street == null) {
               if (other.street != null)
                    return false;
          } else if (!street.equals(other.street))
               return false;
          return true;
     }But, the following code fails on the removing an Address object
          boolean found = false;
          for(Address ae : entry.getAddresses()){
               if((int)ae.getId() == aId){
          if(!entry.removeAddress(address))
               logger.error("Fail to remove address with ID: " + address.getId());
                    found = true;
                    break;

Answer 1

warnerja wrote:
The removeAddress method is implemented as the following:
          address.setEntry(null);
          return addresses.remove(address);
So you set the entry property to null (and presumably it wasn't null beforehand), and then invoke remove with that object. Well, since entry is one of the properties included in the criteria for equality, don't you see a problem with that? It can't find an object "equal" to that one, since the only ones it finds don't match ALL of the fields included in the equality criteria anymore, since you just wiped out one of them on the target object to find.
Here's another thing that looks suspect:
for(Address ae : entry.getAddresses()){
if(!entry.removeAddress( address ))
...Note the bolded parts. Anything strike you as odd?warnerja spotted my careless code. I shouldn't have address.setEntry(null); before the removal. After one attribute is changed, the object definitely is not the same again.
BTW, sorry for little bit messy on the sample code. I put together code from various classes to illustrate the problem.