Improvement on this code?
can anyone make suggestions on improvments to the attached
code? I'm kinda new and don't see much wrong with it but know there
is most likely lots wrong ...
this looks like a mailer i'm going to get 50 copies of in
next few days.
You have to know it's crap- why are you making the pages and
PR stuff for
them??
BS.
> <th scope="col"><a
> href="
http://www.ontariogold.com/mailout/openec/openec_contact2.html"><img
Similar Messages
-
Can you please help me improve on this code
Here is code for a drag and drop activituy where there are 4 questions, each question is on a separate frame of a movieclip mentorquestions. I am trying to have the frame picked at random and then have either the yes target or the no target visible for the right answer to correspond with the question. yesplay is a little animation to let you know you got the correct answer. My code is a bit hit and miss I think.. I am doing something (or many things) wrong
any suggestions?
cheers
sub
import flash.events.MouseEvent;
yesplay.addEventListener(Event.ENTER_FRAME, checkit);
function checkit (myevent:Event):void {
if (yesplay.currentFrame == 27)
{reset1();
var incorrect:Number=0;
var correct:Number=0;
targetYes.visible=false;
targetNo.visible=false;
var Qmove:Array = [1,2,3,4];
var b:Number=4;
var a:Number;
var c:Number;
function pickquestion(){
a=Math.floor(Math.random() * b);
mentorquestions.gotoAndStop(Qmove[a]);
c=Qmove[a];
trace(c);
setanswer();
Qmove.splice(a,1);
b=b-1;
trace(a);
trace(Qmove);
trace(b);
pickquestion();
function setanswer(){;
if (c==3){
targetYes.visible=true;
targetNo.visible=false;
}else{
targetYes.visible=false;
targetNo.visible=true;
AbackBT.addEventListener(MouseEvent.CLICK, Abacker);
function Abacker(e:MouseEvent){
visible=false;
var Yx:Number=843;
var Yy:Number=295;
var Nx:Number=843;
var Ny:Number=394;
function reset1(){
yes.x=Yx;
yes.y=Yy;
no.x=Nx;
no.y=Ny;
pickquestion();
var startX:Number;
var startY:Number;
this.yes.addEventListener(MouseEvent.MOUSE_DOWN, pickMe);
this.yes.addEventListener(MouseEvent.MOUSE_UP,dropMe);
function pickMe(event:MouseEvent):void {
event.target.startDrag();
startX = event.target.x;
startY = event.target.y;
function dropMe(event:MouseEvent):void {
event.target.stopDrag();
var myTargetName:String = "yes" + event.target.name;
if (event.target.dropTarget != null && event.target.dropTarget.parent == targetYes){
event.target.x = targetYes.x;
event.target.y = targetYes.y;
yesplay.play();
}else{
event.target.x = startX;
event.target.y = startY;
wrongun.play();
this.yes.buttonMode = true;
this.no.addEventListener(MouseEvent.MOUSE_DOWN, pickMe1);
this.no.addEventListener(MouseEvent.MOUSE_UP,dropMe1);
function pickMe1(event:MouseEvent):void {
event.target.startDrag();
startX = event.target.x;
startY = event.target.y;
function dropMe1(event:MouseEvent):void {
event.target.stopDrag();
var myTargetName:String = "no" + event.target.name;
if (event.target.dropTarget != null && event.target.dropTarget.parent == targetNo){
event.target.x = targetNo.x;
event.target.y = targetNo.y;
yesplay.play();
}else{
event.target.x = startX;
event.target.y = startY;
wrongun.play();
this.no.buttonMode = true;You'll need to be more specific with presenting your problems insteasd of just putting up a bunch of code and asking others to fix it for you. Try to keep what you present focused on a specific problem.
-
How to improve the performance of this code
Hi gurus
code is given below with LDB
this code look big but most of lines are commented
plz help its urgent
thanks in advance
*& Report ZSALES_RECON
REPORT ZSALES_RECON.
TYPE-POOLS : SLIS.
nodes: bseg , bkpf.
data : begin of zbseg occurs 0,
kunnr like bseg-kunnr,
*lifnr like bseg-lifnr,
dmbtr like bseg-dmbtr,
*shkzg like bseg-shkzg,
*gsber like bseg-gsber,
bschl like bseg-bschl,
*sgtxt like bseg-sgtxt,
total like bseg-dmbtr,
hkont like bseg-hkont,
BUDAT LIKE Bkpf-BUDAT,
belnr LIKE BSEG-belnr,
cash like bseg-dmbtr,
credit like bseg-dmbtr,
abn_voucher like bseg-dmbtr,
barista_voucher like bseg-dmbtr,
accor like bseg-dmbtr,
sodexho like bseg-dmbtr,
gift like bseg-dmbtr,
corp like bseg-dmbtr,
card like bseg-dmbtr,
miscellaneous like bseg-dmbtr,
werks like bseg-werks,
gjahr like bseg-gjahr,
SR_NO TYPE I,
shkzg like bseg-shkzg,
end of zbseg,
TP_TBL_DATA like ZBSEG.
DATA : idx TYPE sy-tabix.
Report data to be shown.
data: it_data like ZBSEG.
Heading of the report.
data: t_heading type slis_t_listheader.
AT SELECTION-SCREEN.
get bkpf.
START-OF-SELECTION.
data : sum_mis like bseg-dmbtr,
sum_abn like bseg-dmbtr,
sum_cash like bseg-dmbtr,
sum_credit like bseg-dmbtr,
sum_card like bseg-dmbtr,
sum_barista_voucher like bseg-dmbtr,
sum_accor like bseg-dmbtr,
sum_sodexho like bseg-dmbtr,
sum_gift like bseg-dmbtr,
sum_corp like bseg-dmbtr.
data : wa1_total like bseg-dmbtr.
data : wa_belnr like bseg-belnr,
wa_kunnr like bseg-kunnr,
wa_werks like bseg-werks,
belnr1 like bseg-belnr,
wa_sr_no type i.
GET BSEG.
data : wa like line of zbseg.
data : count type i,
count1 type i.
move-corresponding bseg to zbseg.
*idx = sy-tabix.
on change of zbseg-belnr.
wa_kunnr = zbseg-kunnr.
wa_kunnr = wa_kunnr+6(4).
select single werks into wa_werks from bseg where belnr = zbseg-belnr
and kunnr = '' and gjahr = zbseg-gjahr.
if wa_kunnr = wa_werks.
if zbseg-bschl <> '01'.
clear: sum_mis,wa1_total,sum_abn,sum_cash,sum_credit,sum_card,
sum_barista_voucher,sum_accor,sum_sodexho,sum_gift,sum_corp.
wa-BUDAT = BKPF-BUDAT.
wa-bschl = zbseg-bschl.
wa-hkont = zbseg-hkont.
wa-belnr = zbseg-belnr.
wa_belnr = wa-belnr.
wa-shkzg = zbseg-shkzg.
wa-kunnr = zbseg-kunnr.
count = wa-sr_no.
*wa-sr_no = count + 1.
idx = idx + 1.
append wa to zbseg.
**count = wa-sr_no.
*wa-sr_no = wa-sr_no + 1.
clear wa-total.
endif.
endif.
endon.
*clear : wa1_total.
if wa_belnr = zbseg-belnr.
loop at zbseg into wa.
wa-total = wa1_total.
wa-bschl = zbseg-bschl.
wa-hkont = zbseg-hkont.
count = sy-tabix.
wa-sr_no = count.
count1 = count.
*wa_sr_no = count.
modify zbseg from wa transporting sr_no.
IF wa-bschl eq '40' and wa-hkont eq '0024013020'.
if sy-tabix = 1.
wa-cash = zbseg-dmbtr.
sum_cash = sum_cash + wa-cash.
wa-cash = sum_cash.
modify zbseg index idx from wa transporting cash.
endif.
endif.
IF wa-bschl eq '40' and wa-hkont eq '0026060010'.
if sy-tabix = 1.
wa-credit = zbseg-dmbtr.
sum_credit = sum_credit + wa-credit.
wa-credit = sum_credit.
modify zbseg index idx from wa transporting credit.
endif.
endif.
IF wa-bschl eq '40' and wa-hkont eq '0026060015'.
if sy-tabix = 1.
wa-abn_voucher = zbseg-dmbtr.
sum_abn = sum_abn + wa-abn_voucher.
wa-abn_voucher = sum_abn.
modify zbseg index idx from wa transporting abn_voucher.
endif.
endif.
IF wa-bschl eq '40' and wa-hkont eq '0026060017'.
if sy-tabix = 1.
wa-barista_voucher = zbseg-dmbtr.
sum_barista_voucher = sum_barista_voucher + wa-barista_voucher.
wa-barista_voucher = sum_barista_voucher.
modify zbseg index idx from wa transporting barista_voucher.
endif.
endif.
IF wa-bschl eq '40' and wa-hkont eq '0026060020'.
if sy-tabix = 1.
wa-sodexho = zbseg-dmbtr.
sum_sodexho = sum_sodexho + wa-sodexho.
wa-sodexho = sum_sodexho.
modify zbseg index idx from wa transporting sodexho.
endif.
endif.
IF wa-bschl eq '40' AND wa-hkont eq '0026060030'.
if sy-tabix = 1.
wa-accor = zbseg-dmbtr.
sum_accor = sum_accor + wa-accor.
wa-accor = sum_accor.
modify zbseg index idx from wa transporting accor.
endif.
endif.
IF wa-bschl eq '40' AND wa-hkont eq '0026070040'.
if sy-tabix = 1.
wa-gift = zbseg-dmbtr.
sum_gift = sum_gift + wa-gift.
wa-gift = sum_gift.
modify zbseg index idx from wa transporting gift.
endif.
endif.
IF wa-bschl eq '40' AND wa-hkont eq '0026060070'.
if sy-tabix = 1.
wa-card = zbseg-dmbtr.
sum_card = sum_card + wa-card.
wa-card = sum_card.
modify zbseg index idx from wa transporting card.
endif.
endif.
IF wa-bschl eq '40' AND wa-hkont eq '0026060018'.
if sy-tabix = 1.
wa-corp = zbseg-dmbtr.
sum_corp = sum_corp + wa-corp.
wa-corp = sum_corp.
modify zbseg index idx from wa transporting corp.
endif.
endif.
*IF wa-bschl eq '11' .
*wa-total = zbseg-dmbtr.
*modify zbseg index idx from wa transporting total.
*endif.
IF wa-bschl EQ '40' or wa-bschl = '01' .
if sy-tabix = 1.
wa-total = zbseg-dmbtr.
wa1_total = wa1_total + wa-total.
wa-total = wa1_total.
*if idx = 2.
*modify zbseg index 1 from wa transporting total.
*else.
modify zbseg index idx from wa transporting total.
*endif.
endif.
endif.
*IF zbseg-TOTAL NE zbseg-DMBTR.
IF wa-BSCHL NE '11' AND wa-BSCHL NE '40'. "AND wa-BSCHL NE '01'.
if sy-tabix = 1.
if wa-shkzg = 'S'.
wa-miscellaneous = - wa-miscellaneous.
endif.
wa-miscellaneous = ZBSEG-DMBTR.
sum_mis = sum_mis + wa-miscellaneous.
wa-miscellaneous = sum_mis.
modify zbseg index idx from wa transporting miscellaneous.
endif.
ENDIF.
*wa1-miscellaneous = wa-miscellaneous.
*modify zbseg index idx from wa.
*ENDIF.
*append wa to zbseg.
*clear:zbseg-dmbtr.
endloop.
endif.
*****endif.
*****endon.
*ENDFORM.
*append zbseg.
*endloop.
End-of-selection.
perform build_alv using zbseg t_heading.
*& Form build_alv
Builds and display the ALV Grid.
form build_alv using t_data
*tp_tbl_data
t_heading type slis_t_listheader.
ALV required data objects.
data: w_title type lvc_title,
w_repid type syrepid,
w_comm type slis_formname,
w_status type slis_formname,
x_layout type slis_layout_alv,
t_event type slis_t_event,
t_fieldcat type slis_t_fieldcat_alv,
t_sort type slis_t_sortinfo_alv.
refresh t_fieldcat.
refresh t_event.
refresh t_sort.
clear x_layout.
clear w_title.
Field Catalog
perform set_fieldcat2 using:
1 'SR_NO' 'SR_NO' 'BKPF' '5' space space 'SR NO' space space space
space space space space space t_fieldcat ,
2 'BELNR' 'BELNR' 'BKPF' '10' space space 'Document No' space space
space space space space space space t_fieldcat ,
3 'BUDAT' 'BUDAT' 'BKPF' '10' space space 'Document Date' space
space space space space space space space t_fieldcat ,
4 'KUNNR' space space space space space 'Site' space space
space space space space space space t_fieldcat ,
5 'TOTAL' space 'BSEG' space space space 'Total' space space space
space space space space 'X' t_fieldcat ,
6 'CASH' 'CASH' 'BSEG' space space space 'Cash Sales'
space space space space space space space 'X' t_fieldcat ,
7 'CREDIT' 'CREDIT' 'BSEG' space space space 'Credit Card'
space space space space space space space 'X' t_fieldcat ,
8 'ABN_VOUCHER' space 'BSEG' space space space 'ABN Voucher' space
space
space space space space space 'X' t_fieldcat ,
9 'BARISTA_VOUCHER' space 'BSEG' '15' space space 'BARISTA Voucher'
space space
space space space space space 'X' t_fieldcat ,
10 'CORP' 'CORP' 'BSEG' space space space 'ABN Corp' space space
space space space space space 'X' t_fieldcat ,
11 'SODEXHO' 'SODEXHO' 'BSEG' space space space 'Sodexho' space
space space space space space space 'X' t_fieldcat ,
12 'ACCOR' 'ACCOR' 'BSEG' space space space 'Accor'
space space space space space space space 'X' t_fieldcat ,
13 'GIFT' 'GIFT' 'BSEG' space space space 'Gift Coupon'
space space space space space space space 'X' t_fieldcat ,
14 'CARD' 'CARD' 'BSEG' space space space 'Diners Card' space
space space space space space space 'X' t_fieldcat ,
15 'MISCELLANEOUS' space 'BKPF' '18' space space
'Miscellaneous Income' space space space space space space space 'X'
t_fieldcat .
*14 'KBETR' 'KBETR' 'KONP' '10' space space 'Tax %age' space space
*space space space space space space t_fieldcat ,
*15 'MWSKZ1' 'MWSKZ1' 'RBKP' space space space 'Tax Type' space
*space
space space space space space space t_fieldcat ,
*16 'AMT' 'AMT' 'RBKP' space space space 'Amount Payable' space
*space
space space space space space 'X' t_fieldcat ,
*17 'WERKS' 'SITE' 'RSEG' space space space 'State' space space
*space space space space space space t_fieldcat .
*18 'GSBER' 'GSBER' 'RBKP' space space space 'Business Area' space
*space space space space space space space t_fieldcat .
Layout
x_layout-zebra = 'X'.
Top of page heading
perform set_top_page_heading using t_heading t_event.
Events
perform set_events using t_event.
GUI Status
w_status = ''.
w_repid = sy-repid.
Title
w_title = <<If you want to set a title for
the ALV, please, uncomment and edit this line>>.
User commands
w_comm = 'USER_COMMAND'.
Order
Example
PERFORM set_order USING '<field>' 'IT_DATA' 'X' space space t_sort.
Displays the ALV grid
call function 'REUSE_ALV_GRID_DISPLAY'
exporting
i_callback_program = w_repid
it_fieldcat = t_fieldcat
is_layout = x_layout
it_sort = t_sort
i_callback_pf_status_set = w_status
i_callback_user_command = w_comm
i_save = 'X'
it_events = t_event
i_grid_title = w_title
tables
t_outtab = zbseg
t_data
exceptions
program_error = 1
others = 2.
if sy-subrc <> 0.
message id sy-msgid type sy-msgty number sy-msgno
with sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4.
endif.
endform. " build_alv.
*& Form set_top_page_heading
Creates the report headings.
form set_top_page_heading using t_heading type slis_t_listheader
t_events type slis_t_event.
data: x_heading type slis_listheader,
x_event type line of slis_t_event.
Report title
clear t_heading[].
clear x_heading.
x_heading-typ = 'H'.
x_heading-info = 'SALES RECONCILIATION REPORT'(001).
append x_heading to t_heading.
Top of page event
x_event-name = slis_ev_top_of_page.
x_event-form = 'TOP_OF_PAGE'.
append x_event to t_events.
endform.
*& Form set_events
Sets the events for ALV.
The TOP_OF_PAGE event is alredy being registered in
the set_top_page_heading subroutine.
form set_events using t_events type slis_t_event.
data: x_event type line of slis_t_event.
Example
clear x_event.
x_event-name = .
x_event-form = .
append x_event to t_event.
endform.
*& Form set_order
Adds an entry to the order table.
FORM set_order USING p_fieldname p_tabname p_up p_down p_subtot
t_sort TYPE slis_t_sortinfo_alv.
DATA: x_sort TYPE slis_sortinfo_alv.
CLEAR x_sort.
x_sort-fieldname = p_fieldname.
x_sort-tabname = p_tabname.
x_sort-up = p_up.
x_sort-down = p_down.
x_sort-subtot = p_subtot.
APPEND x_sort TO t_sort.
ENDFORM. "set_order
*& Form set_fieldcat2
Adds an entry to the field catalog.
p_colpos: Column position.
p_fieldname: Field of internal table which is being described by
* this record of the field catalog.
p_ref_fieldname: (Optional) Table field / data element which
* describes the properties of the field.
* If this field is not given, it is copied from
* the fieldname.
p_ref_tabname: (Optional) Table which holds the field referenced
* by <<p_ref_fieldname>>.
If this is not given, the parameter
<<p_ref_fieldname>> references a data element.
p_outputlen: (Optional) Column width.
p_noout: (Optional) If set to 'X', states that the field is not
* showed initially. If so, the field has to be
included in the report at runtime using the display
options.
p_seltext_m: (Optional) Medium label to be used as column header.
p_seltext_l: (Optional) Long label to be used as column header.
p_seltext_s: (Optional) Small label to be used as column header.
p_reptext_ddic: (Optional) Extra small (heading) label to be
* used as column header.
p_ddictxt: (Optional) Set to 'L', 'M', 'S' or 'R' to select
whether to use SELTEXT_L, SELTEXT_M, SELTEXT_S,
or REPTEXT_DDIC as text for column header.
p_hotspot: (Optional) If set to 'X', this field will be used
* as a hotspot area for cursor, alolowing the user
* to click on the field.
p_showasicon: (Optional) If set to 'X', this field will be shown
as an icon and the contents of the field will set
* which icon to show.
p_checkbox: (Optional) If set to 'X', this field will be shown
as a checkbox.
p_edit: (Optional) If set to 'X', this field will be editable.
p_dosum: (Optional) If set to 'X', this field will be summed
(aggregation function) according to the grouping set
by the order functions.
t_fieldcat: Table which contains the whole fieldcat.
FORM set_fieldcat2 USING
p_colpos p_fieldname p_ref_fieldname p_ref_tabname
p_outputlen p_noout
p_seltext_m p_seltext_l p_seltext_s p_reptext_ddic p_ddictxt
p_hotspot p_showasicon p_checkbox p_edit
p_dosum
t_fieldcat TYPE slis_t_fieldcat_alv.
DATA: wa_fieldcat TYPE slis_fieldcat_alv.
CLEAR wa_fieldcat.
General settings
wa_fieldcat-fieldname = p_fieldname.
wa_fieldcat-col_pos = p_colpos.
wa_fieldcat-no_out = p_noout.
wa_fieldcat-hotspot = p_hotspot.
wa_fieldcat-checkbox = p_checkbox.
wa_fieldcat-icon = p_showasicon.
wa_fieldcat-do_sum = p_dosum.
Set reference fieldname, tablenam and rollname.
If p_ref_tabname is not given, the ref_fieldname given
is a data element.
If p_ref_tabname is given, the ref_fieldname given is a
field of a table.
In case ref_fieldname is not given,
it is copied from the fieldname.
IF p_ref_tabname IS INITIAL.
wa_fieldcat-rollname = p_ref_fieldname.
ELSE.
wa_fieldcat-ref_tabname = p_ref_tabname.
IF p_ref_fieldname EQ space.
wa_fieldcat-ref_fieldname = wa_fieldcat-fieldname.
ELSE.
wa_fieldcat-ref_fieldname = p_ref_fieldname.
ENDIF.
ENDIF.
Set output length.
IF NOT p_outputlen IS INITIAL.
wa_fieldcat-outputlen = p_outputlen.
ENDIF.
Set text headers.
IF NOT p_seltext_m IS INITIAL.
wa_fieldcat-seltext_m = p_seltext_m.
ENDIF.
IF NOT p_seltext_l IS INITIAL.
wa_fieldcat-seltext_l = p_seltext_l.
ENDIF.
IF NOT p_seltext_s IS INITIAL.
wa_fieldcat-seltext_s = p_seltext_s.
ENDIF.
IF NOT p_reptext_ddic IS INITIAL.
wa_fieldcat-reptext_ddic = p_reptext_ddic.
ENDIF.
IF NOT p_ddictxt IS INITIAL.
wa_fieldcat-ddictxt = p_ddictxt.
ENDIF.
Set as editable or not.
IF NOT p_edit IS INITIAL.
wa_fieldcat-input = 'X'.
wa_fieldcat-edit = 'X'.
ENDIF.
APPEND wa_fieldcat TO t_fieldcat.
ENDFORM. "set_fieldcat2
======================== Subroutines called by ALV ================
*& Form top_of_page
Called on top_of_page ALV event.
Prints the heading.
form top_of_page.
call function 'REUSE_ALV_COMMENTARY_WRITE'
exporting
i_logo = <<If you want to set a logo, please,
uncomment and edit this line>>
it_list_commentary = t_heading.
endform. " alv_top_of_page
*& Form user_command
Called on user_command ALV event.
Executes custom commands.
form user_command using r_ucomm like sy-ucomm
rs_selfield type slis_selfield.
Example Code
Executes a command considering the sy-ucomm.
CASE r_ucomm.
WHEN '&IC1'.
Set your "double click action" response here.
Example code: Create and display a status message.
DATA: w_msg TYPE string,
w_row(4) TYPE n.
w_row = rs_selfield-tabindex.
CONCATENATE 'You have clicked row' w_row
'field' rs_selfield-fieldname
'with value' rs_selfield-value
INTO w_msg SEPARATED BY space.
MESSAGE w_msg TYPE 'S'.
ENDCASE.
End of example code.
endform. "user_command
*********************************ldb code start from here *************************************************************
DATABASE PROGRAM OF LOGICAL DATABASE ZBRM_3
top-include and nxxx-include are generated automatically
Do NOT change their names manually!!!
*include DBZBRM_3TOP . " header
*include DBZBRM_3NXXX . " all system routines
include DBZBRM_3F001 . " user defined include
PROGRAM SAPDBZBRM_3 DEFINING DATABASE ZBRM_3.
TABLES:
BKPF,
BSEG.
Hilfsfelder
DATA:
BR_SBUKRS LIKE BKPF-BUKRS,
BR_SBELNR LIKE BKPF-BELNR,
BR_SGJAHR LIKE BKPF-GJAHR,
BR_SBUDAT LIKE BKPF-BUDAT,
BR_SGSBER LIKE BSEG-GSBER.
BR_SBUZEI LIKE BSEG-BUZEI,
BR_SEBELN LIKE BSEG-EBELN,
BR_SEBELP LIKE BSEG-EBELP,
BR_SZEKKN LIKE BSEG-ZEKKN.
working areas for the authority check "n435991
for the company code "n435991
*TYPES : BEGIN OF STYPE_BUKRS, "n435991
BUKRS LIKE T001-BUKRS, "n435991
WAERS LIKE T001-WAERS, "n435991
RETCODE TYPE N, "n435991
END OF STYPE_BUKRS. "n435991
"n435991
*DATA : G_S_BUKRS TYPE STYPE_BUKRS, "n435991
G_T_BUKRS TYPE STYPE_BUKRS OCCURS 0. "n435991
"n435991
for the document type "n435991
*TYPES : BEGIN OF STYPE_BLART, "n435991
BLART LIKE BKPF-BLART, "n435991
RETCODE TYPE N, "n435991
END OF STYPE_BLART. "n435991
"n435991
*DATA : G_S_BLART TYPE STYPE_BLART, "n435991
G_T_BLART TYPE STYPE_BLART OCCURS 0. "n435991
"n435991
for the business area "n435991
*TYPES : BEGIN OF STYPE_GSBER, "n435991
GSBER LIKE BSEG-GSBER, "n435991
RETCODE TYPE N, "n435991
END OF STYPE_GSBER. "n435991
"n435991
*DATA : G_S_GSBER TYPE STYPE_GSBER, "n435991
G_T_GSBER TYPE STYPE_GSBER OCCURS 0. "n435991
"n435991
for the purchasing organization "n435991
*TYPES : BEGIN OF STYPE_EKORG, "n435991
EKORG LIKE EKKO-EKORG, "n435991
RETCODE TYPE N, "n435991
END OF STYPE_EKORG. "n435991
"n435991
*DATA : G_S_EKORG TYPE STYPE_EKORG, "n435991
G_T_EKORG TYPE STYPE_EKORG OCCURS 0. "n435991
"n435991
for the plant "n435991
*TYPES : BEGIN OF STYPE_WERKS, "n435991
WERKS LIKE EKPO-WERKS, "n435991
RETCODE TYPE N, "n435991
END OF STYPE_WERKS. "n435991
"n435991
*DATA : G_S_WERKS TYPE STYPE_WERKS, "n435991
G_T_WERKS TYPE STYPE_WERKS OCCURS 0. "n435991
"n435991
*DATA : G_F_TABIX LIKE SY-TABIX. "n435991
"n435991
working tables for array database access "n934526
*types : begin of stype_key, "n934526
bukrs type bkpf-bukrs, "n934526
belnr type bkpf-belnr, "n934526
gjahr type bkpf-gjahr, "n934526
end of stype_key, "n934526
"n934526
stab_key type standard table of "n934526
stype_key "n934526
with default key. "n934526
Initialwerte setzen
FORM INIT.
ENDFORM.
Selection Screen: Process before output
FORM PBO.
ENDFORM.
Selection Screen: Process after input
FORM PAI USING FNAME MARK.
CHECK MARK = SPACE.
ENDFORM.
Lesen BKPF und Uebergabe an den Selektionsreport
FORM PUT_BKPF.
define locla working areas "n934526
data : l_t_key type stab_key, "n934526
l_t_key_block type stab_key, "n934526
l_t_bkpf type standard table of bkpf. "n934526
"n934526
----------------------------------------------------------"n934526
"n934526
database seletion improved "n934526
at first read all FI doc keys into a lean table "n934526
data: wa like bkpf-belnr.
SELECT * FROM BKPF
where budat in br_budat
AND GJAHR EQ BR_GJAHR-LOW
AND BLART = 'RV'.
AND BLART IN BR_BLAR "n934526
"n934526
check sy-subrc is initial. "n934526
"n934526
then process the found FI doc keys in small blocks "n934526
do. "n934526
if l_t_key[] is initial. "n934526
exit. " no more keys -> leave this DO loop "n934526
endif. "n934526
"n934526
form small blocks with 100 FI docs each "n934526
refresh l_t_key_block. "n934526
append lines of l_t_key from 1 to 100 "n934526
to l_t_key_block. "n934526
delete l_t_key from 1 to 100. "n934526
"n934526
read the complete FI doc headers for the block "n934526
SELECT * FROM BKPF "n934526
into corresponding fields of table l_t_bkpf "n934526
for all entries in l_t_key_block "n934526
WHERE BUKRS = l_t_key_block-BUKRS "n934526
AND BELNR = l_t_key_block-BELNR "n934526
AND GJAHR = l_t_key_block-GJAHR. "n934526
"n934526
provide the complete structure for the PUT "n934526
loop at l_t_bkpf into bkpf. "n934526
process this company code : authority and read T001 "n934526
PERFORM F1000_COMPANY_CODE. "n934526
"n934526
go on if the first authority check was successful "n934526
CHECK : G_S_BUKRS-RETCODE IS INITIAL. "n934526
"n934526
set the currency key and save the keys "n934526
MOVE : G_S_BUKRS-WAERS TO T001-WAERS, "n934526
BKPF-BUKRS TO BR_SBUKRS, "n934526
MOVE BKPF-BELNR TO BR_SBELNR.
MOVE BKPF-GJAHR TO BR_SGJAHR . "n934526
BKPF-GJAHR TO BR_SGJAHR. "n934526
PUT BKPF. "n934526
endloop. "n934526
enddo. "n934526
ENDSELECT.
ENDFORM.
Lesen BSEG und Uebergabe an den Selektionsreport
FORM PUT_BSEG.
define local working areas "n934526
data : l_t_bseg type standard table of bseg. "n934526
"n934526
----------------------------------------------------------"n934526
BR_SGSBER = BR_GSBER-LOW.
"n934526
SELECT * FROM BSEG "n934526
WHERE BELNR EQ BR_SBELNR
AND GJAHR EQ BR_SGJAHR
AND GSBER EQ BR_SGSBER.
check sy-subrc is initial. "n934526
"n934526
loop at l_t_bseg into bseg. "n934526
MOVE BSEG-BUZEI TO BR_SBUZEI.
MOVE BSEG-EBELN TO BR_SEBELN.
MOVE BSEG-EBELP TO BR_SEBELP.
MOVE BSEG-ZEKKN TO BR_SZEKKN.
PUT BSEG.
endSELECT. "n934526
ENDFORM.
"n435991
FORM AUTHORITYCHECK_BKPF "n435991
"n435991
"n435991
*FORM AUTHORITYCHECK_BKPF. "n435991
"n435991
the authority-check for the company code was successful; "n435991
check authority for the document type here "n435991
"n435991
does the buffer contain this document type ? "n435991
READ TABLE G_T_BLART INTO G_S_BLART "n435991
WITH KEY BLART = BKPF-BLART BINARY SEARCH. "n435991
"n435991
CASE SY-SUBRC. "n435991
WHEN 0. "document type is known "n435991
"n435991
WHEN 4. "docment type is new --> insert "n435991
MOVE SY-TABIX TO G_F_TABIX. "n435991
PERFORM F1200_CREATE_BLART_ENTRY. "n435991
INSERT G_S_BLART INTO G_T_BLART "n435991
INDEX G_F_TABIX. "n435991
"n435991
WHEN 8. "document type is new --> append "n435991
PERFORM F1200_CREATE_BLART_ENTRY. "n435991
APPEND G_S_BLART TO G_T_BLART. "n435991
ENDCASE. "n435991
"n435991
set the return code "n435991
MOVE G_S_BLART-RETCODE TO SY-SUBRC. "n435991
"n435991
*ENDFORM. "authoritycheck_bkpf "n435991
"n435991
"n435991
FORM AUTHORITYCHECK_BSEG "n435991
"n435991
"n435991
*FORM AUTHORITYCHECK_BSEG. "n435991
"n435991
does the buffer contain this document type ? "n435991
READ TABLE G_T_GSBER INTO G_S_GSBER "n435991
WITH KEY GSBER = BSEG-GSBER BINARY SEARCH. "n435991
"n435991
CASE SY-SUBRC. "n435991
WHEN 0. "business area is known "n435991
"n435991
WHEN 4. "business area is new --> insert "n435991
MOVE SY-TABIX TO G_F_TABIX. "n435991
PERFORM F1300_CREATE_GSBER_ENTRY. "n435991
INSERT G_S_GSBER INTO G_T_GSBER "n435991
INDEX G_F_TABIX. "n435991
"n435991
WHEN 8. "business area is new --> append "n435991
PERFORM F1300_CREATE_GSBER_ENTRY. "n435991
APPEND G_S_GSBER TO G_T_GSBER. "n435991
ENDCASE. "n435991
"n435991
set the return code "n435991
MOVE G_S_GSBER-RETCODE TO SY-SUBRC. "n435991
"n435991
*ENDFORM. "authoritycheck_bseg "n435991
"n435991ABAP provides few tools to analyse the perfomance of the objects, which was developed by us.
Run time analysis transaction SE30
This transaction gives all the analysis of an ABAP program with respect to the database and the non-database processing.
SQL Trace transaction ST05
by using this tool we can analyse the perfomance issues related to DATABASE calls.
Perfomance Techniques for improve the perfomance of the object.
1) ABAP/4 programs can take a very long time to execute, and can make other processes have to wait before executing. Here are some tips to speed up your programs and reduce the load your programs put on the system:
2) Use the GET RUN TIME command to help evaluate performance. It's hard to know whether that optimization technique REALLY helps unless you test it out.
3) Using this tool can help you know what is effective, under what kinds of conditions. The GET RUN TIME has problems under multiple CPUs, so you should use it to test small pieces of your program, rather than the whole program.
4) Generally, try to reduce I/O first, then memory, then CPU activity. I/O operations that read/write to hard disk are always the most expensive operations. Memory, if not controlled, may have to be written to swap space on the hard disk, which therefore increases your I/O read/writes to disk. CPU activity can be reduced by careful program design, and by using commands such as SUM (SQL) and COLLECT (ABAP/4).
5) Avoid 'SELECT *', especially in tables that have a lot of fields. Use SELECT A B C INTO instead, so that fields are only read if they are used. This can make a very big difference.
6) Field-groups can be useful for multi-level sorting and displaying. However, they write their data to the system's paging space, rather than to memory (internal tables use memory). For this reason, field-groups are only appropriate for processing large lists (e.g. over 50,000 records). If you have large lists, you should work with the systems administrator to decide the maximum amount of RAM your program should use, and from that, calculate how much space your lists will use. Then you can decide whether to write the data to memory or swap space.
Use as many table keys as possible in the WHERE part of your select statements.
7)Whenever possible, design the program to access a relatively constant number of records (for instance, if you only access the transactions for one month, then there probably will be a reasonable range, like 1200-1800, for the number of transactions inputted within that month). Then use a SELECT A B C INTO TABLE ITAB statement.
8) Get a good idea of how many records you will be accessing. Log into your productive system, and use SE80 -> Dictionary Objects (press Edit), enter the table name you want to see, and press Display. Go To Utilities -> Table Contents to query the table contents and see the number of records. This is extremely useful in optimizing a program's memory allocation.
9) Try to make the user interface such that the program gradually unfolds more information to the user, rather than giving a huge list of information all at once to the user.
10) Declare your internal tables using OCCURS NUM_RECS, where NUM_RECS is the number of records you expect to be accessing. If the number of records exceeds NUM_RECS, the data will be kept in swap space (not memory).
11) Use SELECT A B C INTO TABLE ITAB whenever possible. This will read all of the records into the itab in one operation, rather than repeated operations that result from a SELECT A B C INTO ITAB... ENDSELECT statement. Make sure that ITAB is declared with OCCURS NUM_RECS, where NUM_RECS is the number of records you expect to access.
12) If the number of records you are reading is constantly growing, you may be able to break it into chunks of relatively constant size. For instance, if you have to read all records from 1991 to present, you can break it into quarters, and read all records one quarter at a time. This will reduce I/O operations. Test extensively with GET RUN TIME when using this method.
13) Know how to use the 'collect' command. It can be very efficient.
14) Use the SELECT SINGLE command whenever possible.
15) Many tables contain totals fields (such as monthly expense totals). Use these avoid wasting resources by calculating a total that has already been calculated and stored.
Some tips:
1) Use joins where possible as redundant data is not fetched.
2) Use select single where ever possible.
3) Calling methods of a global class is faster than calling function modules.
4) Use constants instead of literals
5) Use WHILE instead of a DO-EXIT-ENDDO.
6) Unnecessary MOVEs should be avoided by using the explicit work area operations
see the follwing links for a brief insifght into performance tuning,
http://www.thespot4sap.com/Articles/SAPABAPPerformanceTuning_Introduction.asp
1. Debuggerhttp://help.sap.com/saphelp_47x200/helpdata/en/c6/617ca9e68c11d2b2ab080009b43351/content.htm
2. Run Time Analyser
http://help.sap.com/saphelp_47x200/helpdata/en/c6/617cafe68c11d2b2ab080009b43351/content.htm
3. SQL trace
http://help.sap.com/saphelp_47x200/helpdata/en/d1/801f7c454211d189710000e8322d00/content.htm
4. CATT - Computer Aided Testing Too
http://help.sap.com/saphelp_47x200/helpdata/en/b3/410b37233f7c6fe10000009b38f936/frameset.htm
5. Test Workbench
http://help.sap.com/saphelp_47x200/helpdata/en/a8/157235d0fa8742e10000009b38f889/frameset.htm
6. Coverage Analyser
http://help.sap.com/saphelp_47x200/helpdata/en/c7/af9a79061a11d4b3d4080009b43351/content.htm
7. Runtime Monitor
http://help.sap.com/saphelp_47x200/helpdata/en/b5/fa121cc15911d5993d00508b6b8b11/content.htm
8. Memory Inspector
http://help.sap.com/saphelp_47x200/helpdata/en/a2/e5fc84cc87964cb2c29f584152d74e/content.htm
9. ECATT - Extended Computer Aided testing tool.
http://help.sap.com/saphelp_47x200/helpdata/en/20/e81c3b84e65e7be10000000a11402f/frameset.htm
Performance tuning for Data Selection Statement
http://www.sap-img.com/abap/performance-tuning-for-data-selection-statement.htm -
Is There any way to improve the performance on this code
Hi all can any one tell me how to improve the performance of this below code.
Actually i need to calculate opening balance of gl account so instead of using bseg am using bsis
So is there any way to improve this code performance.
Any help would be appreciated.
REPORT ZTEMP5 NO STANDARD PAGE HEADING LINE-SIZE 190.
data: begin of collect occurs 0,
MONAT TYPE MONAT,
HKONT TYPE HKONT,
BELNR TYPE BELNR_D,
BUDAT TYPE BUDAT,
WRBTR TYPE WRBTR,
SHKZG TYPE SHKZG,
SGTXT TYPE SGTXT,
AUFNR TYPE AUFNR_NEU,
TOT LIKE BSIS-WRBTR,
end of collect.
TYPES: BEGIN OF TY_BSIS,
MONAT TYPE MONAT,
HKONT TYPE HKONT,
BELNR TYPE BELNR_D,
BUDAT TYPE BUDAT,
WRBTR TYPE WRBTR,
SHKZG TYPE SHKZG,
SGTXT TYPE SGTXT,
AUFNR TYPE AUFNR_NEU,
END OF TY_BSIS.
DATA: IT_BSIS TYPE TABLE OF TY_BSIS,
WA_BSIS TYPE TY_BSIS.
DATA: TOT TYPE WRBTR,
SUMA TYPE WRBTR,
VALUE TYPE WRBTR,
VALUE1 TYPE WRBTR.
SELECTION-SCREEN: BEGIN OF BLOCK B1.
PARAMETERS: S_HKONT LIKE WA_BSIS-HKONT DEFAULT '0001460002' .
SELECT-OPTIONS: S_BUDAT FOR WA_BSIS-BUDAT,
S_AUFNR FOR WA_BSIS-AUFNR DEFAULT '200020',
S_BELNR FOR WA_BSIS-BELNR.
SELECTION-SCREEN: END OF BLOCK B1.
AT SELECTION-SCREEN OUTPUT.
LOOP AT SCREEN.
IF SCREEN-NAME = 'S_HKONT'.
SCREEN-INPUT = 0.
MODIFY SCREEN.
ENDIF.
ENDLOOP.
START-OF-SELECTION.
SELECT MONAT
HKONT
BELNR
BUDAT
WRBTR
SHKZG
SGTXT
AUFNR
FROM BSIS
INTO TABLE IT_BSIS
WHERE HKONT EQ S_HKONT
AND BELNR IN S_BELNR
AND BUDAT IN S_BUDAT
AND AUFNR IN S_AUFNR.
* if sy-subrc <> 0.
* message 'No Data' type 'I'.
* endif.
SELECT SUM( WRBTR )
FROM BSIS
INTO COLLECT-TOT
WHERE HKONT EQ S_HKONT
AND BUDAT < S_BUDAT-LOW
AND AUFNR IN S_AUFNR.
END-OF-SELECTION.
CLEAR: S_BUDAT, S_AUFNR, S_BELNR, S_HKONT.
LOOP AT IT_BSIS INTO WA_BSIS.
IF wa_bsis-SHKZG = 'H'.
wa_bsis-WRBTR = 0 - wa_bsis-WRBTR.
ENDIF.
collect-MONAT = wa_bsis-monat.
collect-HKONT = wa_bsis-hkont.
collect-BELNR = wa_bsis-belnr.
collect-BUDAT = wa_bsis-budat.
collect-WRBTR = wa_bsis-wrbtr.
collect-SHKZG = wa_bsis-shkzg.
collect-SGTXT = wa_bsis-sgtxt.
collect-AUFNR = wa_bsis-aufnr.
collect collect into collect.
CLEAR: COLLECT, WA_BSIS.
ENDLOOP.
LOOP AT COLLECT.
AT end of HKONT.
WRITE:/65 'OpeningBalance',
85 collect-tot.
skip 1.
ENDAT.
WRITE:/06 COLLECT-BELNR,
22 COLLECT-BUDAT,
32 COLLECT-WRBTR,
54 COLLECT-SGTXT.
AT end of MONAT.
SUM.
WRITE:/ COLLECT-MONAT COLOR 1.
WRITE:32 COLLECT-WRBTR COLOR 1.
VALUE = COLLECT-WRBTR.
SKIP 1.
ENDAT.
VALUE1 = COLLECT-TOT + VALUE.
AT end of MONAT.
WRITE:85 VALUE1.
ENDAT.
endloop.
CLEAR: COLLECT, SUMA, VALUE, VALUE1.
TOP-OF-PAGE.
WRITE:/06 'Doc No',
22 'Post Date',
39 'Amount',
54 'Text'.
Moderator message : See the Sticky threads (related for performance tuning) in this forum. Thread locked.
Edited by: Vinod Kumar on Oct 13, 2011 11:12 AMHi Ben,
both BSIS selects would become faster if you can add Company Code BUKRS as 1st field of WHERE clause, because it's the 1st field of primary key and HKONT is the 2nd field of primary key.
If you have no table index with HKONT as 1st field it's a full database access.
If possible, try to add BUKRS as 1st field of WHERE clause, otherwise ask for an additional BSIS index at your basis team.
Regards,
Klaus -
Please make suggestions on how to improve this code.
Hello Experts,
I am currently modifying a report where a certain code is giving
me run time error. When I debugged the program, the internal table
has 20,000+ records. Now, is there any alternative to this code?
I really need to speed this up. Help would be greatly appreciated and rewarded.
LOOP AT it_cdpos INTO wa_cdpos.
l_matnr = wa_cdpos-objectid+00(18).
l_charg = wa_cdpos-objectid+22(10).
l_zustd = wa_cdpos-value_new+00(01).
READ TABLE it_batch INTO wa_batch
WITH KEY matnr = l_matnr
charg = l_charg.
IF sy-subrc EQ 0.
l_tabix = sy-tabix.
wa_batch-zustd = l_zustd.
MODIFY it_batch FROM wa_batch INDEX l_tabix
TRANSPORTING zustd.
ELSE.
wa_batch-matnr = l_matnr.
wa_batch-charg = l_charg.
wa_batch-zustd = l_zustd.
wa_batch-code = 'A'. "selected within period
APPEND wa_batch TO it_batch.
ENDIF.
ENDLOOP.Check the SQL statement from which u get the result otherwise
the code which u sent is optimized or u can use the binary search option for the Read statement for MATNR
while the rest of the code is optimized....
or u can use
loop at it_cdpos assinging <fs>.
<FS>-cols = value.
<b>note: in this case <FS>-col = value</b>
u wont have to use <b>modify</b> statement for internal table for updating the line contents
since assinging it to field-symbol will dynamically modifies the contents.
<b>this method is faster than the below modify process </b>
endloop. -
Need a small change in this code, GUI_DOWNLOAD. FILE NAME ??
Hi All,
I want to write a program to download data from VBAK. I have tried this and working fine but I have made my file name constant. Instead I want user to make a choice of file name and its location to save.
Also please review this code and let me know, how can I improve my programming skills...
*& Report ZSAI1
REPORT ZSAI1.
tables : vbak.
data : begin of it_vbak occurs 0,
vbeln like vbak-vbeln,
auart like vbak-auart,
audat like vbak-audat,
end of it_vbak.
data : i_filename type string value 'C:\Documents and Settings\venki\Desktop\text.xls'.
selection-screen begin of block sc1 with frame.
select-options : s_vbeln for vbak-vbeln.
selection-screen Skip 3.
parameters : i_excel radiobutton group Rb1,
i_text radiobutton group Rb1.
selection-screen end of block sc1.
perform select_dt.
if i_excel = 'X'.
perform download_excel.
endif.
*& Form download_excel
FORM download_excel .
CALL FUNCTION 'GUI_DOWNLOAD'
EXPORTING
BIN_FILESIZE =
FILENAME = i_filename
FILETYPE = 'ASC'
APPEND = ' '
WRITE_FIELD_SEPARATOR = ' '
HEADER = '00'
TRUNC_TRAILING_BLANKS = ' '
WRITE_LF = 'X'
COL_SELECT = ' '
COL_SELECT_MASK = ' '
DAT_MODE = ' '
CONFIRM_OVERWRITE = ' '
NO_AUTH_CHECK = ' '
CODEPAGE = ' '
IGNORE_CERR = ABAP_TRUE
REPLACEMENT = '#'
WRITE_BOM = ' '
TRUNC_TRAILING_BLANKS_EOL = 'X'
WK1_N_FORMAT = ' '
WK1_N_SIZE = ' '
WK1_T_FORMAT = ' '
WK1_T_SIZE = ' '
IMPORTING
FILELENGTH =
TABLES
DATA_TAB = it_vbak
FIELDNAMES =
EXCEPTIONS
FILE_WRITE_ERROR = 1
NO_BATCH = 2
GUI_REFUSE_FILETRANSFER = 3
INVALID_TYPE = 4
NO_AUTHORITY = 5
UNKNOWN_ERROR = 6
HEADER_NOT_ALLOWED = 7
SEPARATOR_NOT_ALLOWED = 8
FILESIZE_NOT_ALLOWED = 9
HEADER_TOO_LONG = 10
DP_ERROR_CREATE = 11
DP_ERROR_SEND = 12
DP_ERROR_WRITE = 13
UNKNOWN_DP_ERROR = 14
ACCESS_DENIED = 15
DP_OUT_OF_MEMORY = 16
DISK_FULL = 17
DP_TIMEOUT = 18
FILE_NOT_FOUND = 19
DATAPROVIDER_EXCEPTION = 20
CONTROL_FLUSH_ERROR = 21
OTHERS = 22
IF SY-SUBRC <> 0.
MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.
ENDIF.
ENDFORM. " download_excel
*& Form download_text
FORM download_text .
ENDFORM. " download_text
*& Form select_dt
FORM select_dt .
select vbeln auart audat from vbak
into table it_vbak where
vbeln in s_vbeln.
ENDFORM. " select_dt
Thank You once gain.
Regards
Venkat
Message was edited by:
venkat KumbhamCheck the below code :
REPORT ZSAI1.
tables : vbak.
data : begin of it_vbak occurs 0,
vbeln like vbak-vbeln,
auart like vbak-auart,
audat like vbak-audat,
end of it_vbak.
data v_file type string.
*data : i_filename type string value
*'C:\Documents and Settings\venki\Desktop\text.xls'.
selection-screen begin of block sc1 with frame.
select-options : s_vbeln for vbak-vbeln.
selection-screen Skip 3.
parameters p_file like rlgrap-filename.
parameters : i_excel radiobutton group Rb1,
i_text radiobutton group Rb1.
selection-screen end of block sc1.
at selection-screen on value-request for p_file.
F4 value for file
perform file_get.
start-of-selection.
perform select_dt.
if i_excel = 'X'.
perform download_excel.
endif.
*& Form download_excel
FORM download_excel .
v_file = p_file.
CALL FUNCTION 'GUI_DOWNLOAD'
EXPORTING
BIN_FILESIZE =
FILENAME = v_file
FILETYPE = 'ASC'
APPEND = ' '
WRITE_FIELD_SEPARATOR = ' '
HEADER = '00'
TRUNC_TRAILING_BLANKS = ' '
WRITE_LF = 'X'
COL_SELECT = ' '
COL_SELECT_MASK = ' '
DAT_MODE = ' '
CONFIRM_OVERWRITE = ' '
NO_AUTH_CHECK = ' '
CODEPAGE = ' '
IGNORE_CERR = ABAP_TRUE
REPLACEMENT = '#'
WRITE_BOM = ' '
TRUNC_TRAILING_BLANKS_EOL = 'X'
WK1_N_FORMAT = ' '
WK1_N_SIZE = ' '
WK1_T_FORMAT = ' '
WK1_T_SIZE = ' '
IMPORTING
FILELENGTH =
TABLES
DATA_TAB = it_vbak
FIELDNAMES =
EXCEPTIONS
FILE_WRITE_ERROR = 1
NO_BATCH = 2
GUI_REFUSE_FILETRANSFER = 3
INVALID_TYPE = 4
NO_AUTHORITY = 5
UNKNOWN_ERROR = 6
HEADER_NOT_ALLOWED = 7
SEPARATOR_NOT_ALLOWED = 8
FILESIZE_NOT_ALLOWED = 9
HEADER_TOO_LONG = 10
DP_ERROR_CREATE = 11
DP_ERROR_SEND = 12
DP_ERROR_WRITE = 13
UNKNOWN_DP_ERROR = 14
ACCESS_DENIED = 15
DP_OUT_OF_MEMORY = 16
DISK_FULL = 17
DP_TIMEOUT = 18
FILE_NOT_FOUND = 19
DATAPROVIDER_EXCEPTION = 20
CONTROL_FLUSH_ERROR = 21
OTHERS = 22
IF SY-SUBRC <> 0.
MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.
ENDIF.
ENDFORM. " download_excel
*& Form download_text
FORM download_text .
ENDFORM. " download_text
*& Form select_dt
FORM select_dt .
select vbeln auart audat from vbak
into table it_vbak where
vbeln in s_vbeln.
ENDFORM. " select_dt
*& Form file_get
text
--> p1 text
<-- p2 text
FORM file_get.
CALL FUNCTION 'WS_FILENAME_GET'
EXPORTING
DEF_PATH = 'C:\Temp\'
MASK = ',.,..'
MODE = 'O'
TITLE = 'Select File'(007)
IMPORTING
FILENAME = P_file
EXCEPTIONS
INV_WINSYS = 1
NO_BATCH = 2
SELECTION_CANCEL = 3
SELECTION_ERROR = 4
OTHERS = 5.
ENDFORM. " file_get
Thanks
Seshu -
I would like your comments on this code. Doesn't it have a few oppertunities? I know it's jsp, but question is not directed toward the jsp, just the logic/syntax/etc. How about the == for starters?
<%
String z_Desc = (((String)hshipTrackSummaryDocList.get("Z_DESC")) == null) ? "" : (String)hshipTrackSummaryDocList.get("Z_DESC");
if (z_Desc == "" ) {
%>
<%
}else {
%>
<%=(((String)hshipTrackSummaryDocList.get("Z_DESC")) == null) ? "" : (String)hshipTrackSummaryDocList.get("Z_DESC")%></font>
<%
%>Hi mlovern! This code has several opportunities for "improvement". I noticed that the get("Z_DESC") method is called on hshipTrackSummaryDocList object several times. Each time, it returns the very same value. Hence, in the interests of efficiency, it's a better idea to call it once, save the return value and then use the latter.
Also, I'm not too clear about exactly what you intended to do in the else clause. As it stands, your else clause will cause the JSP to fail.
Be very careful while using the "==" operator while comparing strings. That causes object comparison, not object content comparison. The latter is the required test most of the time. Also, while comparing the contents of the strings, it's better to call the equals() method on the empty string or a constant string. So, if I needed to compare a test value against an empty string or a constant, here's how.
if ( "".equals( testString ) )
// do something
else if ( SOME_CONSTANT.equals( testString ) )
// do something
}In the above code, even if testString was null, a runtime exception will not be generated. However, if the equals() method was called on testString and it happened to be null, you'd be looking at an exception.
Here's how I would have written the code you supplied.
String zDescValue = (String) hshipTrackSummaryDocList.get( "Z_DESC" );
if ( zDescValue == null ) zDescValue = "";
if ( "".equals( zDescValue ) )
// do something useful
else
// do something else
}I've also come across similar situations. In order not to repeat the same code everywhere, I've wound up writing a couple of utility methods to assign "" to a string if it's null. Here are those methods.
public static String processStringValue( String inputString, String defaultValue )
return ( inputString == null ? defaultValue : inputString );
public static String processStringValue( String inputString )
return processStringValue( inputString, "" );
}Finally, you may want to be careful about the code fragments you post. From your post and profile, I can guess where you work. Your employer may or may not care if parts of their code start showing up on the Internet. It's better to create a general piece of code that approximates what you want to convey. However, it's better to be safe than sorry.
Hope this helps!
Cheers! -
I have a code and the question is how do i make these three improvements to the code. Here is the code...
import javax.swing.JOptionPane;
public class FibonacciNumber
public static void main (String[] args)
String inputString;
String outputString;
int previous1;
int previous2;
int current = 0;
int counter;
int nthFibonacci;
inputString =
JOptionPane.showInputDialog("Enter the first "
+ "Fibonacci number:");
previous1 = Integer.parseInt(inputString);
inputString =
JOptionPane.showInputDialog("Enter the second "
+ "Fibonacci number: ");
previous2 = Integer.parseInt(inputString);
outputString = "The first two numbers of the "
+ "Fibonacci sequence are: "
+ previous1 + " and " + previous2;
inputString =
JOptionPane.showInputDialog("Enter the position "
+ "of the desired number in "
+ "the Fibonacci sequence: ");
nthFibonacci = Integer.parseInt(inputString);
if (nthFibonacci == 1)
current = previous1;
else if (nthFibonacci == 2)
current = previous2;
else
counter = 3;
while (counter <= nthFibonacci)
current = previous2 + previous1;
previous1 = previous2;
previous2 = current;
counter++;
outputString = outputString + "\nThe "
+ nthFibonacci
+ "th Fibonacci number of "
+ "the sequence is: "
+ current;
JOptionPane.showMessageDialog(null, outputString,
"Fibonacci Number",
JOptionPane.INFORMATION_MESSAGE);
System.exit(0);
The three improvements are...
1. check whether the first number entered by the use is less or equal to the second number.
2. check that both numbers are nonnegative.
3. Check whether the user entered a valid value for the position of the desired number in the Fibonacci sequence.
Could someone please help!So this is how I did it...
if (previous1 <= previous2)
System.out.println("Good number choice!")
else
System.out.println("Choose a different number!")
if (previous1 < 0)
previous1 = -previous1;
if (previous2 < 0)
previous2 = -previous2;
if (nthFibonacci == 1)
current = previous1;
else if (nthFibonacci == 2)
current = previous2;
else
Is that the correct way? For finding out whether the entered value is okay for the position of the number in the Fibonacci sequence..would I use an IF statement also? -
Hello
Need to tune this code.Its taking too much time.
REFRESH: T_BVOR.
IF NOT I_TEM[] IS INITIAL.
SELECT BVORG BUKRS GJAHR BELNR INTO
CORRESPONDING FIELDS OF
TABLE T_BVOR
FROM BVOR
FOR ALL ENTRIES IN I_TEM
WHERE BVORG = I_TEM-BVORG
AND GJAHR = I_TEM-GJAHR.
ENDIF.
IF SY-SUBRC EQ 0.
SORT T_BVOR BY BVORG GJAHR.
ENDIF.
CLEAR: WA_BVOR.
SORT I_TEM BY BVORG GJAHR.
LOOP AT T_BVOR INTO WA_BVOR.
CLEAR: I_TEM.
READ TABLE I_TEM WITH KEY BVORG = WA_BVOR-BVORG
GJAHR = WA_BVOR-GJAHR
BINARY SEARCH.
IF SY-SUBRC EQ 0.
MOVE I_TEM-BLART TO WA_BVOR-BLART.
ENDIF.
MODIFY T_BVOR FROM WA_BVOR TRANSPORTING BLART.
ENDLOOP.
SORT T_BVOR BY BUKRS BELNR GJAHR.
IF NOT T_BVOR[] IS INITIAL.
LOOP AT I_BVOR.
REFRESH: GT_BSEG.
SELECT BUKRS
BELNR GJAHR BSCHL KOSTL HKONT
EBELN PRCTR ZZINFO3 TXGRP
FROM BSEG
INTO CORRESPONDING FIELDS
OF TABLE GT_BSEG
FOR ALL ENTRIES IN T_BVOR
WHERE BUKRS = T_BVOR-BUKRS
AND BELNR = T_BVOR-BELNR
AND GJAHR = T_BVOR-GJAHR
AND NOT HKONT IN RANGE_HKONT.
ENDIF.
SORT GT_BSEG BY BUKRS BELNR GJAHR.
DELETE ADJACENT DUPLICATES FROM GT_BSEG
COMPARING BUKRS BELNR GJAHR.
CLEAR: WA_BSEG.
LOOP AT GT_BSEG INTO WA_BSEG.
CLEAR: WA_BVOR.
READ TABLE T_BVOR INTO WA_BVOR WITH KEY
BUKRS = WA_BSEG-BUKRS
BELNR = WA_BSEG-BELNR
GJAHR = WA_BSEG-GJAHR
BINARY SEARCH.
IF SY-SUBRC EQ 0.
MOVE WA_BVOR-BLART TO WA_BSEG-BLART.
MOVE WA_BVOR-BVORG TO WA_BSEG-BVORG.
ENDIF.
MODIFY GT_BSEG FROM WA_BSEG TRANSPORTING BLART BVORG.
ENDLOOP.
REFRESH: GT_BSEG1,GT_BSEG2.
SORT T_DOCS BY BSCHL BLART.
SORT GT_BSEG BY BVORG.
CLEAR: WA_BSEG.
LOOP AT GT_BSEG INTO WA_BSEG.
CLEAR: T_DOCS.
LOOP AT T_DOCS WHERE BSCHL = WA_BSEG-BSCHL
AND BLART = WA_BSEG-BLART.
IF T_DOCS-BSCHL = '40' OR T_DOCS-BSCHL = '50'
OR T_DOCS-BSCHL = '81' OR T_DOCS-BSCHL = '91'.
MOVE-CORRESPONDING WA_BSEG TO WA_BSEG1.
APPEND WA_BSEG1 TO GT_BSEG1.
CLEAR: WA_BSEG1.
ENDIF.
IF T_DOCS-BSCHL = '31' OR T_DOCS-BSCHL = '32'
OR T_DOCS-BSCHL = '21' OR T_DOCS-BSCHL = '22'
OR ( T_DOCS-ZDATATYP = 'TAXRPT02' AND
( T_DOCS-BSCHL = '40' OR T_DOCS-BSCHL = '50' ) ).
MOVE-CORRESPONDING WA_BSEG TO WA_BSEG1.
APPEND WA_BSEG2 TO GT_BSEG2.
CLEAR: WA_BSEG2.
ENDIF.
ENDLOOP.
ENDLOOP.
SORT GT_BSEG1 BY TXGRP.
SORT GT_BSEG2 BY BUKRS BELNR GJAHR.
LOOP AT i_bseg.
CLEAR: WA_BSEG2.
LOOP AT GT_BSEG2 INTO WA_BSEG2.
CLEAR : GT_ALV_ITEM.
LOOP AT GT_ALV_ITEM WHERE
BUKRS = WA_BSEG2-BUKRS AND
BELNR = WA_BSEG2-BELNR AND
GJAHR = WA_BSEG2-GJAHR.
CLEAR: WA_BSEG1.
LOOP AT GT_BSEG1 INTO WA_BSEG1
WHERE GJAHR = GT_ALV_ITEM-GJAHR AND
TXGRP = GT_ALV_ITEM-TXGRP AND
BVORG = WA_BSEG2-BVORG.
MOVE: WA_BSEG1-BUKRS TO GT_ALV_ITEM-BUKRS,
WA_BSEG1-EBELN TO GT_ALV_ITEM-EBELN,
WA_BSEG1-HKONT TO GT_ALV_ITEM-HKONT,
WA_BSEG1-BELNR TO GT_ALV_ITEM-BELNR,
WA_BSEG1-KOSTL TO GT_ALV_ITEM-KOSTL,
WA_BSEG1-PRCTR TO GT_ALV_ITEM-PRCTR,
WA_BSEG1-ZZINFO3 TO GT_ALV_ITEM-ZZINFO3." M003a
CLEAR: WA_BSEG1.
ENDLOOP.
MODIFY GT_ALV_ITEM INDEX SY-TABIX.
IF gt_alv_item-txjlv = 6.EXIT.ENDIF.
ENDIF.
ENDLOOP.
CLEAR: WA_BSEG2.
ENDLOOP.
Thanks
SunilWays of Performance Tuning
1. Selection Criteria
2. Select Statements
Select Queries
SQL Interface
Aggregate Functions
For all Entries
Select Over more than one internal table
Selection Criteria
1. Restrict the data to the selection criteria itself, rather than filtering it out using the ABAP code using CHECK statement.
2. Select with selection list.
SELECT * FROM SBOOK INTO SBOOK_WA.
CHECK: SBOOK_WA-CARRID = 'LH' AND
SBOOK_WA-CONNID = '0400'.
ENDSELECT.
The above code can be much more optimized by the code written below which avoids CHECK, selects with selection list
SELECT CARRID CONNID FLDATE BOOKID FROM SBOOK INTO TABLE T_SBOOK
WHERE SBOOK_WA-CARRID = 'LH' AND
SBOOK_WA-CONNID = '0400'.
Select Statements Select Queries
1. Avoid nested selects
SELECT * FROM EKKO INTO EKKO_WA.
SELECT * FROM EKAN INTO EKAN_WA
WHERE EBELN = EKKO_WA-EBELN.
ENDSELECT.
ENDSELECT.
The above code can be much more optimized by the code written below.
SELECT PF1 PF2 FF3 FF4 INTO TABLE ITAB
FROM EKKO AS P INNER JOIN EKAN AS F
ON PEBELN = FEBELN.
Note: A simple SELECT loop is a single database access whose result is passed to the ABAP program line by line. Nested SELECT loops mean that the number of accesses in the inner loop is multiplied by the number of accesses in the outer loop. One should therefore use nested SELECT loops only if the selection in the outer loop contains very few lines or the outer loop is a SELECT SINGLE statement.
2. Select all the records in a single shot using into table clause of select statement rather than to use Append statements.
SELECT * FROM SBOOK INTO SBOOK_WA.
CHECK: SBOOK_WA-CARRID = 'LH' AND
SBOOK_WA-CONNID = '0400'.
ENDSELECT.
The above code can be much more optimized by the code written below which avoids CHECK, selects with selection list and puts the data in one shot using into table
SELECT CARRID CONNID FLDATE BOOKID FROM SBOOK INTO TABLE T_SBOOK
WHERE SBOOK_WA-CARRID = 'LH' AND
SBOOK_WA-CONNID = '0400'.
3. When a base table has multiple indices, the where clause should be in the order of the index, either a primary or a secondary index.
To choose an index, the optimizer checks the field names specified in the where clause and then uses an index that has the same order of the fields. In certain scenarios, it is advisable to check whether a new index can speed up the performance of a program. This will come handy in programs that access data from the finance tables.
4. For testing existence, use Select.. Up to 1 rows statement instead of a Select-Endselect-loop with an Exit.
SELECT * FROM SBOOK INTO SBOOK_WA
UP TO 1 ROWS
WHERE CARRID = 'LH'.
ENDSELECT.
The above code is more optimized as compared to the code mentioned below for testing existence of a record.
SELECT * FROM SBOOK INTO SBOOK_WA
WHERE CARRID = 'LH'.
EXIT.
ENDSELECT.
5. Use Select Single if all primary key fields are supplied in the Where condition .
If all primary key fields are supplied in the Where conditions you can even use Select Single.
Select Single requires one communication with the database system, whereas Select-Endselect needs two.
Select Statements SQL Interface
1. Use column updates instead of single-row updates
to update your database tables.
SELECT * FROM SFLIGHT INTO SFLIGHT_WA.
SFLIGHT_WA-SEATSOCC =
SFLIGHT_WA-SEATSOCC - 1.
UPDATE SFLIGHT FROM SFLIGHT_WA.
ENDSELECT.
The above mentioned code can be more optimized by using the following code
UPDATE SFLIGHT
SET SEATSOCC = SEATSOCC - 1.
2. For all frequently used Select statements, try to use an index.
SELECT * FROM SBOOK CLIENT SPECIFIED INTO SBOOK_WA
WHERE CARRID = 'LH'
AND CONNID = '0400'.
ENDSELECT.
The above mentioned code can be more optimized by using the following code
SELECT * FROM SBOOK CLIENT SPECIFIED INTO SBOOK_WA
WHERE MANDT IN ( SELECT MANDT FROM T000 )
AND CARRID = 'LH'
AND CONNID = '0400'.
ENDSELECT.
3. Using buffered tables improves the performance considerably.
Bypassing the buffer increases the network considerably
SELECT SINGLE * FROM T100 INTO T100_WA
BYPASSING BUFFER
WHERE SPRSL = 'D'
AND ARBGB = '00'
AND MSGNR = '999'.
The above mentioned code can be more optimized by using the following code
SELECT SINGLE * FROM T100 INTO T100_WA
WHERE SPRSL = 'D'
AND ARBGB = '00'
AND MSGNR = '999'.
Select Statements Aggregate Functions
If you want to find the maximum, minimum, sum and average value or the count of a database column, use a select list with aggregate functions instead of computing the aggregates yourself.
Some of the Aggregate functions allowed in SAP are MAX, MIN, AVG, SUM, COUNT, COUNT( * )
Consider the following extract.
Maxno = 0.
Select * from zflight where airln = LF and cntry = IN.
Check zflight-fligh > maxno.
Maxno = zflight-fligh.
Endselect.
The above mentioned code can be much more optimized by using the following code.
Select max( fligh ) from zflight into maxno where airln = LF and cntry = IN.
Select Statements For All Entries
The for all entries creates a where clause, where all the entries in the driver table are combined with OR. If the number of entries in the driver table is larger than rsdb/max_blocking_factor, several similar SQL statements are executed to limit the length of the WHERE clause.
The plus
Large amount of data
Mixing processing and reading of data
Fast internal reprocessing of data
Fast
The Minus
Difficult to program/understand
Memory could be critical (use FREE or PACKAGE size)
Points to be must considered FOR ALL ENTRIES
Check that data is present in the driver table
Sorting the driver table
Removing duplicates from the driver table
Consider the following piece of extract
Loop at int_cntry.
Select single * from zfligh into int_fligh
where cntry = int_cntry-cntry.
Append int_fligh.
Endloop.
The above mentioned can be more optimized by using the following code.
Sort int_cntry by cntry.
Delete adjacent duplicates from int_cntry.
If NOT int_cntry[] is INITIAL.
Select * from zfligh appending table int_fligh
For all entries in int_cntry
Where cntry = int_cntry-cntry.
Endif.
Select Statements Select Over more than one Internal table
1. Its better to use a views instead of nested Select statements.
SELECT * FROM DD01L INTO DD01L_WA
WHERE DOMNAME LIKE 'CHAR%'
AND AS4LOCAL = 'A'.
SELECT SINGLE * FROM DD01T INTO DD01T_WA
WHERE DOMNAME = DD01L_WA-DOMNAME
AND AS4LOCAL = 'A'
AND AS4VERS = DD01L_WA-AS4VERS
AND DDLANGUAGE = SY-LANGU.
ENDSELECT.
The above code can be more optimized by extracting all the data from view DD01V_WA
SELECT * FROM DD01V INTO DD01V_WA
WHERE DOMNAME LIKE 'CHAR%'
AND DDLANGUAGE = SY-LANGU.
ENDSELECT
2. To read data from several logically connected tables use a join instead of nested Select statements. Joins are preferred only if all the primary key are available in WHERE clause for the tables that are joined. If the primary keys are not provided in join the Joining of tables itself takes time.
SELECT * FROM EKKO INTO EKKO_WA.
SELECT * FROM EKAN INTO EKAN_WA
WHERE EBELN = EKKO_WA-EBELN.
ENDSELECT.
ENDSELECT.
The above code can be much more optimized by the code written below.
SELECT PF1 PF2 FF3 FF4 INTO TABLE ITAB
FROM EKKO AS P INNER JOIN EKAN AS F
ON PEBELN = FEBELN.
3. Instead of using nested Select loops it is often better to use subqueries.
SELECT * FROM SPFLI
INTO TABLE T_SPFLI
WHERE CITYFROM = 'FRANKFURT'
AND CITYTO = 'NEW YORK'.
SELECT * FROM SFLIGHT AS F
INTO SFLIGHT_WA
FOR ALL ENTRIES IN T_SPFLI
WHERE SEATSOCC < F~SEATSMAX
AND CARRID = T_SPFLI-CARRID
AND CONNID = T_SPFLI-CONNID
AND FLDATE BETWEEN '19990101' AND '19990331'.
ENDSELECT.
The above mentioned code can be even more optimized by using subqueries instead of for all entries.
SELECT * FROM SFLIGHT AS F INTO SFLIGHT_WA
WHERE SEATSOCC < F~SEATSMAX
AND EXISTS ( SELECT * FROM SPFLI
WHERE CARRID = F~CARRID
AND CONNID = F~CONNID
AND CITYFROM = 'FRANKFURT'
AND CITYTO = 'NEW YORK' )
AND FLDATE BETWEEN '19990101' AND '19990331'.
ENDSELECT.
1. Table operations should be done using explicit work areas rather than via header lines.
READ TABLE ITAB INTO WA WITH KEY K = 'X BINARY SEARCH.
IS MUCH FASTER THAN USING
READ TABLE ITAB INTO WA WITH KEY K = 'X'.
If TAB has n entries, linear search runs in O( n ) time, whereas binary search takes only O( log2( n ) ).
2. Always try to use binary search instead of linear search. But dont forget to sort your internal table before that.
READ TABLE ITAB INTO WA WITH KEY K = 'X'. IS FASTER THAN USING
READ TABLE ITAB INTO WA WITH KEY (NAME) = 'X'.
3. A dynamic key access is slower than a static one, since the key specification must be evaluated at runtime.
4. A binary search using secondary index takes considerably less time.
5. LOOP ... WHERE is faster than LOOP/CHECK because LOOP ... WHERE evaluates the specified condition internally.
LOOP AT ITAB INTO WA WHERE K = 'X'.
ENDLOOP.
The above code is much faster than using
LOOP AT ITAB INTO WA.
CHECK WA-K = 'X'.
ENDLOOP.
6. Modifying selected components using MODIFY itab TRANSPORTING f1 f2.. accelerates the task of updating a line of an internal table.
WA-DATE = SY-DATUM.
MODIFY ITAB FROM WA INDEX 1 TRANSPORTING DATE.
The above code is more optimized as compared to
WA-DATE = SY-DATUM.
MODIFY ITAB FROM WA INDEX 1.
7. Accessing the table entries directly in a "LOOP ... ASSIGNING ..." accelerates the task of updating a set of lines of an internal table considerably
Modifying selected components only makes the program faster as compared to Modifying all lines completely.
e.g,
LOOP AT ITAB ASSIGNING <WA>.
I = SY-TABIX MOD 2.
IF I = 0.
<WA>-FLAG = 'X'.
ENDIF.
ENDLOOP.
The above code works faster as compared to
LOOP AT ITAB INTO WA.
I = SY-TABIX MOD 2.
IF I = 0.
WA-FLAG = 'X'.
MODIFY ITAB FROM WA.
ENDIF.
ENDLOOP.
8. If collect semantics is required, it is always better to use to COLLECT rather than READ BINARY and then ADD.
LOOP AT ITAB1 INTO WA1.
READ TABLE ITAB2 INTO WA2 WITH KEY K = WA1-K BINARY SEARCH.
IF SY-SUBRC = 0.
ADD: WA1-VAL1 TO WA2-VAL1,
WA1-VAL2 TO WA2-VAL2.
MODIFY ITAB2 FROM WA2 INDEX SY-TABIX TRANSPORTING VAL1 VAL2.
ELSE.
INSERT WA1 INTO ITAB2 INDEX SY-TABIX.
ENDIF.
ENDLOOP.
The above code uses BINARY SEARCH for collect semantics. READ BINARY runs in O( log2(n) ) time. The above piece of code can be more optimized by
LOOP AT ITAB1 INTO WA.
COLLECT WA INTO ITAB2.
ENDLOOP.
SORT ITAB2 BY K.
COLLECT, however, uses a hash algorithm and is therefore independent
of the number of entries (i.e. O(1)) .
9. "APPEND LINES OF itab1 TO itab2" accelerates the task of appending a table to another table considerably as compared to LOOP-APPEND-ENDLOOP.
APPEND LINES OF ITAB1 TO ITAB2.
This is more optimized as compared to
LOOP AT ITAB1 INTO WA.
APPEND WA TO ITAB2.
ENDLOOP.
10. DELETE ADJACENT DUPLICATES accelerates the task of deleting duplicate entries considerably as compared to READ-LOOP-DELETE-ENDLOOP.
DELETE ADJACENT DUPLICATES FROM ITAB COMPARING K.
This is much more optimized as compared to
READ TABLE ITAB INDEX 1 INTO PREV_LINE.
LOOP AT ITAB FROM 2 INTO WA.
IF WA = PREV_LINE.
DELETE ITAB.
ELSE.
PREV_LINE = WA.
ENDIF.
ENDLOOP.
11. "DELETE itab FROM ... TO ..." accelerates the task of deleting a sequence of lines considerably as compared to DO -DELETE-ENDDO.
DELETE ITAB FROM 450 TO 550.
This is much more optimized as compared to
DO 101 TIMES.
DELETE ITAB INDEX 450.
ENDDO.
12. Copying internal tables by using ITAB2[ ] = ITAB1[ ] as compared to LOOP-APPEND-ENDLOOP.
ITAB2[] = ITAB1[].
This is much more optimized as compared to
REFRESH ITAB2.
LOOP AT ITAB1 INTO WA.
APPEND WA TO ITAB2.
ENDLOOP.
13. Specify the sort key as restrictively as possible to run the program faster.
SORT ITAB BY K. makes the program runs faster as compared to SORT ITAB.
Internal Tables contd
Hashed and Sorted tables
1. For single read access hashed tables are more optimized as compared to sorted tables.
2. For partial sequential access sorted tables are more optimized as compared to hashed tables
Hashed And Sorted Tables
Point # 1
Consider the following example where HTAB is a hashed table and STAB is a sorted table
DO 250 TIMES.
N = 4 * SY-INDEX.
READ TABLE HTAB INTO WA WITH TABLE KEY K = N.
IF SY-SUBRC = 0.
ENDIF.
ENDDO.
This runs faster for single read access as compared to the following same code for sorted table
DO 250 TIMES.
N = 4 * SY-INDEX.
READ TABLE STAB INTO WA WITH TABLE KEY K = N.
IF SY-SUBRC = 0.
ENDIF.
ENDDO.
Point # 2
Similarly for Partial Sequential access the STAB runs faster as compared to HTAB
LOOP AT STAB INTO WA WHERE K = SUBKEY.
ENDLOOP.
This runs faster as compared to
LOOP AT HTAB INTO WA WHERE K = SUBKEY.
ENDLOOP. -
Is this code need to be enhanced further? If yes,please give your inputs
Hai Coders,
The code below is a part of a java file for authentication. Its working version. I want to know how can i write optimized code for authentication of username and password. Comment on my code how can I improve it.
Is it up to Standard ( up to good java programmer )
Is it possible to optimize my coder further?
Any other alternatives that works better than this code for authentication?
As a java Programmer rate my code(1 to 10)..
try {
Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
Connection con=DriverManager.getConnection("jdbc:odbc:srcname","","");
Statement stmt=con.createStatement();
String str1="";//username & assume that getting input from user
String str2="";//password & assume that getting input from user
ResultSet rs=stmt.executeQuery("select * from tablename");
while(rs.next()) {
String s1=rs.getString(8);
String s2=rs.getString(1);
if((s1.equals(str1))&&(s2.equals(str2))) {
System.out.println("Success");
} catch(Exception e) {
System.out.println("Fail");
}Friends My new updated code,
Give comments to improve my code further,
package javaapplication1;
import java.sql.*;
* @author m.senthil kumar
public class Main {
public static void main(String[] yahoo) {
Connection con=null;
PreparedStatement pstmt=null;
ResultSet rs=null;
try {
Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
con = DriverManager.getConnection("jdbc:odbc:tecch", "uuu", "ppp");
String userName = "jav1a";//username & assume that getting input from user
String password = "java";//password & assume that getting input from user
pstmt = con.prepareStatement("select username from test where username=? and password=?");
pstmt.setString(1, userName);
pstmt.setString(2, password);
rs = pstmt.executeQuery();
boolean b = false;
while (rs.next()) {
b = true;
break;
if (b) {
System.out.print("Success");
} else {
throw new unauthorized();
} catch (Exception e) {
System.out.print(e);
} finally {
try{
if(rs!=null)
rs.close();
if (pstmt != null) {
pstmt.close();
if (con != null) {
con.close();
catch(Exception e)
System.out.print(e);
class unauthorized extends Exception {
public String toString() {
return "You are not authorized person";
} -
How can I use the old Apple TV with new iTunes? It tells me to input a code in iTunes but iTunes no longer has a spot to input this code to allow sync. I can access the iTunes Store fine, just none of my Library
read this
https://discussions.apple.com/message/20429789#20429789 -
At a total loss with this code...
So i'm working on this applet for work and im lost. in the end, this will be a cash register type app thats integrated with our web database. as of right now, the code to download an html page works fine when run by itself, independent of the main class. but when the download PageDownload class is called from the sales class (the main class), i get this error:
register/sales.java [245:1] unreported exception java.lang.Exception; must be caught or declared to be thrown
pagey.main(null);
what's my problem?
-------------------------SALES.java----------------------------
* sales.java
* Created on December 6, 2003, 1:34 PM
package register;
import javax.swing.* ;
import java.util.*;
import java.lang.*;
import java.text.*;
import javax.swing.table.AbstractTableModel;
import javax.swing.table.DefaultTableCellRenderer;
import javax.swing.table.TableCellRenderer;
import javax.swing.table.TableColumn;
import javax.swing.JComboBox.*;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.JScrollPane;
import javax.swing.JTable;
import javax.swing.table.AbstractTableModel;
import java.awt.Dimension;
import java.awt.GridLayout;
import java.net.*;
import java.io.*;
* @author Geoff
public class sales extends java.applet.Applet {
/** Initializes the applet sales */
public void init() {
initComponents();
//private boolean DEBUG = false;
//Set the lblDate to contain today's date in mm/dd/yy format
Date today;
String dateOut;
DateFormat dateFormatter;
dateFormatter = DateFormat.getDateInstance(DateFormat.SHORT);
today = new Date();
dateOut = dateFormatter.format(today);
lblDate.setText(dateOut);
//set up the payment method choice box
cmbPaymentMethod.add("American Express");
cmbPaymentMethod.add("Cash");
cmbPaymentMethod.add("Check");
cmbPaymentMethod.add("Discover");
cmbPaymentMethod.add("Gift Card");
cmbPaymentMethod.add("Master Card");
cmbPaymentMethod.add("Visa");
JTable table = new JTable(new MyTableModel());
table.setPreferredScrollableViewportSize(new Dimension(500, 70));
//Create the scroll pane and add the table to it.
JScrollPane scrollPane = new JScrollPane(table);
//Add the scroll pane to this panel.
add(scrollPane);
scrollPane.setBounds(0, 165, 600, 200);
scrollPane.setVisible(true);
TableColumn sysCol = table.getColumnModel().getColumn(0);
sysCol.setWidth(120);
sysCol.setMaxWidth(120);
TableColumn conCol = table.getColumnModel().getColumn(2);
conCol.setWidth(60);
conCol.setMaxWidth(60);
TableColumn qtyCol = table.getColumnModel().getColumn(3);
qtyCol.setWidth(40);
qtyCol.setMaxWidth(40);
TableColumn rateCol = table.getColumnModel().getColumn(4);
rateCol.setWidth(60);
rateCol.setMaxWidth(60);
TableColumn amtCol = table.getColumnModel().getColumn(5);
amtCol.setWidth(60);
amtCol.setMaxWidth(60);
class MyTableModel extends AbstractTableModel {
private String[] columnNames = {"System",
"Item",
"Contents",
"Qty.",
"Rate",
"Amount"};
private Object[][] data = {
public int getColumnCount() {
return columnNames.length;
public int getRowCount() {
return data.length;
public String getColumnName(int col) {
return columnNames[col];
public Object getValueAt(int row, int col) {
return data[row][col];
* JTable uses this method to determine the default renderer/
* editor for each cell. If we didn't implement this method,
* then the last column would contain text ("true"/"false"),
* rather than a check box.
public Class getColumnClass(int c) {
return getValueAt(0, c).getClass();
* Don't need to implement this method unless your table's
* editable.
public boolean isCellEditable(int row, int col) {
//Note that the data/cell address is constant,
//no matter where the cell appears onscreen.
if (col < 2) {
return false;
} else {
return true;
* Don't need to implement this method unless your table's
* data can change.
public void setValueAt(Object value, int row, int col) {
//if (DEBUG) {
System.out.println("Setting value at " + row + "," + col
+ " to " + value
+ " (an instance of "
+ value.getClass() + ")");
data[row][col] = value;
fireTableCellUpdated(row, col);
/** This method is called from within the init() method to
* initialize the form.
* WARNING: Do NOT modify this code. The content of this method is
* always regenerated by the Form Editor.
private void initComponents() {
label1 = new java.awt.Label();
txtSoldTo = new java.awt.TextArea();
label2 = new java.awt.Label();
lblDate = new java.awt.Label();
label4 = new java.awt.Label();
txtSoldBy = new java.awt.TextField();
label3 = new java.awt.Label();
lblSaleNumber = new java.awt.Label();
lblPaymentMethod = new java.awt.Label();
cmbPaymentMethod = new java.awt.Choice();
jButton1 = new javax.swing.JButton();
setLayout(null);
label1.setFont(new java.awt.Font("Dialog", 1, 12));
label1.setText("Sold To:");
add(label1);
label1.setBounds(10, 10, 50, 20);
add(txtSoldTo);
txtSoldTo.setBounds(10, 30, 180, 80);
label2.setFont(new java.awt.Font("Dialog", 1, 12));
label2.setText("Date:");
add(label2);
label2.setBounds(410, 10, 38, 20);
lblDate.setAlignment(java.awt.Label.CENTER);
lblDate.setText("dategoeshere");
add(lblDate);
lblDate.setBounds(390, 30, 90, 20);
label4.setFont(new java.awt.Font("Dialog", 1, 12));
label4.setText("Sold By:");
add(label4);
label4.setBounds(500, 70, 50, 20);
add(txtSoldBy);
txtSoldBy.setBounds(500, 90, 50, 20);
label3.setFont(new java.awt.Font("Dialog", 1, 12));
label3.setText("Sale No.");
add(label3);
label3.setBounds(500, 10, 50, 20);
lblSaleNumber.setAlignment(java.awt.Label.CENTER);
lblSaleNumber.setText("0");
add(lblSaleNumber);
lblSaleNumber.setBounds(490, 30, 70, 20);
lblPaymentMethod.setFont(new java.awt.Font("Dialog", 1, 12));
lblPaymentMethod.setText("Payment Method");
add(lblPaymentMethod);
lblPaymentMethod.setBounds(380, 70, 100, 20);
add(cmbPaymentMethod);
cmbPaymentMethod.setBounds(380, 90, 100, 20);
jButton1.setText("jButton1");
jButton1.setActionCommand("GO");
jButton1.addActionListener(new java.awt.event.ActionListener() {
public void actionPerformed(java.awt.event.ActionEvent evt) {
jButton1ActionPerformed(evt);
add(jButton1);
jButton1.setBounds(210, 100, 81, 26);
private void jButton1ActionPerformed(java.awt.event.ActionEvent evt) {
// Add your handling code here:
if( evt.getActionCommand().equals("GO")) {
PageDownload pagey = new PageDownload();
System.out.println("PageDownload created.");
pagey.main(null);
private String thepage;
// Variables declaration - do not modify
private java.awt.Choice cmbPaymentMethod;
private javax.swing.JButton jButton1;
private java.awt.Label label1;
private java.awt.Label label2;
private java.awt.Label label3;
private java.awt.Label label4;
private java.awt.Label lblDate;
private java.awt.Label lblPaymentMethod;
private java.awt.Label lblSaleNumber;
private java.awt.TextField txtSoldBy;
private java.awt.TextArea txtSoldTo;
// End of variables declaration
----------------------------PageDownload.java------------------------
package register;
* @author Geoff
import java.net.*;
import java.io.*;
import javax.swing.*;
import java.lang.Exception;
public class PageDownload extends java.applet.Applet {
/** Creates a new instance of PageDownload */
public PageDownload() {
public static void main(String[] args) throws Exception {
URL url = new URL("http://www.awebsite.com");
InputStream html = url.openStream();
int c = 0;
String a = "";
while(c != -1) {
a = "";
c = html.read();
if(c == (char)60) {
while(c != (char)62) {
a = a + (char)c;
c = html.read();
if(a == "") {}
else
System.out.println(a + ">");Your PageDownload code has no non-static code other than the blank class instantiator. You shouldn't be calling a static method from an instance of the class. You could just as easily say:
PageDownload.main(null);
instead of:
PageDownload pagey = new PageDownload();
pagey.main(null);
the PageDownload class needs no instance since it has no object code of any value.
Re-think the design a bit, the pattern looks bad.
If your intention for the PageDownload class was to create a singleton then search the tutorials for the proper way to construct singletons, also decide wether or not you need this class to be a singleton.
Also output some of the error information to help diagnose what exactly is wrong with the URL, ie, try to output the URL, maybe it's blank -
Why this code is not working??? java script
gen_validatorv2.js
JavaScript Form Validator
Version 2.0.2
Copyright 2003 JavaScript-coder.com. All rights reserved.
You use this script in your Web pages, provided these opening credit
lines are kept intact.
The Form validation script is distributed free from JavaScript-Coder.com
You may please add a link to JavaScript-Coder.com,
making it easy for others to find this script.
Checkout the Give a link and Get a link page:
http://www.javascript-coder.com/links/how-to-link.php
You may not reprint or redistribute this code without permission from
JavaScript-Coder.com.
JavaScript Coder
It precisely codes what you imagine!
Grab your copy here:
http://www.javascript-coder.com/
function Validator(frmname)
this.formobj=document.forms[frmname];
if(!this.formobj)
alert("BUG: couldnot get Form object "+frmname);
return;
if(this.formobj.onsubmit)
this.formobj.old_onsubmit = this.formobj.onsubmit;
this.formobj.onsubmit=null;
else
this.formobj.old_onsubmit = null;
this.formobj.onsubmit=form_submit_handler;
this.addValidation = add_validation;
this.setAddnlValidationFunction=set_addnl_vfunction;
this.clearAllValidations = clear_all_validations;
function set_addnl_vfunction(functionname)
this.formobj.addnlvalidation = functionname;
function clear_all_validations()
for(var itr=0;itr < this.formobj.elements.length;itr++)
this.formobj.elements[itr].validationset = null;
function form_submit_handler()
for(var itr=0;itr < this.elements.length;itr++)
if(this.elements[itr].validationset &&
!this.elements[itr].validationset.validate())
return false;
if(this.addnlvalidation)
str =" var ret = "+this.addnlvalidation+"()";
eval(str);
if(!ret) return ret;
return true;
function add_validation(itemname,descriptor,errstr)
if(!this.formobj)
alert("BUG: the form object is not set properly");
return;
}//if
var itemobj = this.formobj[itemname];
if(!itemobj)
alert("BUG: Couldnot get the input object named: "+itemname);
return;
if(!itemobj.validationset)
itemobj.validationset = new ValidationSet(itemobj);
itemobj.validationset.add(descriptor,errstr);
function ValidationDesc(inputitem,desc,error)
this.desc=desc;
this.error=error;
this.itemobj = inputitem;
this.validate=vdesc_validate;
function vdesc_validate()
if(!V2validateData(this.desc,this.itemobj,this.error))
this.itemobj.focus();
return false;
return true;
function ValidationSet(inputitem)
this.vSet=new Array();
this.add= add_validationdesc;
this.validate= vset_validate;
this.itemobj = inputitem;
function add_validationdesc(desc,error)
this.vSet[this.vSet.length]=
new ValidationDesc(this.itemobj,desc,error);
function vset_validate()
for(var itr=0;itr<this.vSet.length;itr++)
if(!this.vSet[itr].validate())
return false;
return true;
function validateEmailv2(email)
// a very simple email validation checking.
// you can add more complex email checking if it helps
if(email.length <= 0)
return true;
var splitted = email.match("^(.+)@(.+)$");
if(splitted == null) return false;
if(splitted[1] != null )
var regexp_user=/^\"?[\w-_\.]*\"?$/;
if(splitted[1].match(regexp_user) == null) return false;
if(splitted[2] != null)
var regexp_domain=/^[\w-\.]*\.[A-Za-z]{2,4}$/;
if(splitted[2].match(regexp_domain) == null)
var regexp_ip =/^\[\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}\]$/;
if(splitted[2].match(regexp_ip) == null) return false;
}// if
return true;
return false;
function V2validateData(strValidateStr,objValue,strError)
var epos = strValidateStr.search("=");
var command = "";
var cmdvalue = "";
if(epos >= 0)
command = strValidateStr.substring(0,epos);
cmdvalue = strValidateStr.substr(epos+1);
else
command = strValidateStr;
switch(command)
case "req":
case "required":
if(eval(objValue.value.length) == 0)
if(!strError || strError.length ==0)
strError = objValue.name + " : Required Field";
}//if
alert(strError);
return false;
}//if
break;
}//case required
case "maxlength":
case "maxlen":
if(eval(objValue.value.length) > eval(cmdvalue))
if(!strError || strError.length ==0)
strError = objValue.name + " : "+cmdvalue+" characters maximum ";
}//if
alert(strError + "\n[Current length = " + objValue.value.length + " ]");
return false;
}//if
break;
}//case maxlen
case "minlength":
case "minlen":
if(eval(objValue.value.length) < eval(cmdvalue))
if(!strError || strError.length ==0)
strError = objValue.name + " : " + cmdvalue + " characters minimum ";
}//if
alert(strError + "\n[Current length = " + objValue.value.length + " ]");
return false;
}//if
break;
}//case minlen
case "alnum":
case "alphanumeric":
var charpos = objValue.value.search("[^A-Za-z0-9]");
if(objValue.value.length > 0 && charpos >= 0)
if(!strError || strError.length ==0)
strError = objValue.name+": Only alpha-numeric characters allowed ";
}//if
alert(strError + "\n [Error character position " + eval(charpos+1)+"]");
return false;
}//if
break;
}//case alphanumeric
case "num":
case "numeric":
var charpos = objValue.value.search("[^0-9]");
if(objValue.value.length > 0 && charpos >= 0)
if(!strError || strError.length ==0)
strError = objValue.name+": Only digits allowed ";
}//if
alert(strError + "\n [Error character position " + eval(charpos+1)+"]");
return false;
}//if
break;
}//numeric
case "alphabetic":
case "alpha":
var charpos = objValue.value.search("[^A-Za-z]");
if(objValue.value.length > 0 && charpos >= 0)
if(!strError || strError.length ==0)
strError = objValue.name+": Only alphabetic characters allowed ";
}//if
alert(strError + "\n [Error character position " + eval(charpos+1)+"]");
return false;
}//if
break;
}//alpha
case "alnumhyphen":
var charpos = objValue.value.search("[^A-Za-z0-9\-_]");
if(objValue.value.length > 0 && charpos >= 0)
if(!strError || strError.length ==0)
strError = objValue.name+": characters allowed are A-Z,a-z,0-9,- and _";
}//if
alert(strError + "\n [Error character position " + eval(charpos+1)+"]");
return false;
}//if
break;
case "email":
if(!validateEmailv2(objValue.value))
if(!strError || strError.length ==0)
strError = objValue.name+": Enter a valid Email address ";
}//if
alert(strError);
return false;
}//if
break;
}//case email
case "lt":
case "lessthan":
if(isNaN(objValue.value))
alert(objValue.name+": Should be a number ");
return false;
}//if
if(eval(objValue.value) >= eval(cmdvalue))
if(!strError || strError.length ==0)
strError = objValue.name + " : value should be less than "+ cmdvalue;
}//if
alert(strError);
return false;
}//if
break;
}//case lessthan
case "gt":
case "greaterthan":
if(isNaN(objValue.value))
alert(objValue.name+": Should be a number ");
return false;
}//if
if(eval(objValue.value) <= eval(cmdvalue))
if(!strError || strError.length ==0)
strError = objValue.name + " : value should be greater than "+ cmdvalue;
}//if
alert(strError);
return false;
}//if
break;
}//case greaterthan
case "regexp":
if(objValue.value.length > 0)
if(!objValue.value.match(cmdvalue))
if(!strError || strError.length ==0)
strError = objValue.name+": Invalid characters found ";
}//if
alert(strError);
return false;
}//if
break;
}//case regexp
case "dontselect":
if(objValue.selectedIndex == null)
alert("BUG: dontselect command for non-select Item");
return false;
if(objValue.selectedIndex == eval(cmdvalue))
if(!strError || strError.length ==0)
strError = objValue.name+": Please Select one option ";
}//if
alert(strError);
return false;
break;
}//case dontselect
}//switch
return true;
Copyright 2003 JavaScript-coder.com. All rights reserved.
example.html
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<title>Example for Validator</title>
<script language="JavaScript" src="gen_validatorv2.js" type="text/javascript"></script>
</head>
<body>
<form action="" name="myform" >
<table cellspacing="2" cellpadding="2" border="0">
<tr>
<td align="right">First Name</td>
<td><input type="text" name="FirstName"></td>
</tr>
<tr>
<td align="right">Last Name</td>
<td><input type="text" name="LastName"></td>
</tr>
<tr>
<td align="right">EMail</td>
<td><input type="text" name="Email"></td>
</tr>
<tr>
<td align="right">Phone</td>
<td><input type="text" name="Phone"></td>
</tr>
<tr>
<td align="right">Address</td>
<td><textarea cols="20" rows="5" name="Address"></textarea></td>
</tr>
<tr>
<td align="right">Country</td>
<td>
<SELECT name="Country">
<option value="" selected>[choose yours]
<option value="008">Albania
<option value="012">Algeria
<option value="016">American Samoa
<option value="020">Andorra
<option value="024">Angola
<option value="660">Anguilla
<option value="010">Antarctica
<option value="028">Antigua And Barbuda
<option value="032">Argentina
<option value="051">Armenia
<option value="533">Aruba
</SELECT>
</td>
</tr>
<tr>
<td align="right"></td>
<td><input type="submit" value="Submit"></td>
</tr>
</table>
</form>
<script language="JavaScript" type="text/javascript">
//You should create the validator only after the definition of the HTML form
var frmvalidator = new Validator("myform");
frmvalidator.addValidation("FirstName","req","Please enter your First Name");
frmvalidator.addValidation("FirstName","maxlen=20",
"Max length for FirstName is 20");
frmvalidator.addValidation("FirstName","alpha");
frmvalidator.addValidation("LastName","req");
frmvalidator.addValidation("LastName","maxlen=20");
frmvalidator.addValidation("Email","maxlen=50");
frmvalidator.addValidation("Email","req");
frmvalidator.addValidation("Email","email");
frmvalidator.addValidation("Phone","maxlen=50");
frmvalidator.addValidation("Phone","numeric");
frmvalidator.addValidation("Address","maxlen=50");
frmvalidator.addValidation("Country","dontselect=0");
</script>
</body>
</html>
documentation.html
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<head>
<title>JavaScript Form Validator Documentation</title>
<Style>
BODY, P,TD{ font-family: Arial,Verdana,Helvetica, sans-serif; font-size: 10pt }
H1{ font-family: Arial,Verdana,Helvetica, sans-serif; font-size: 18pt; color : #000066}
H3{ font-family: Arial,Verdana,Helvetica, sans-serif; font-size: 12pt; color : #000066 }
A{font-family: Arial,Verdana,Helvetica, sans-serif;}
B { font-family : Arial, Helvetica, sans-serif; font-size : 12px; font-weight : bold;}
CODE {font-family : Courier,monospace;font-size: 10pt;color : #800000;}
CODE.htm {font-family : "Courier New", Courier, monospace; font-size : x-small; color : #000080;}
</Style>
</head>
<body>
<center>
<table cellspacing="2" cellpadding="2" border="0" width="600">
<tr><td>
<h1>JavaScript Form Validations Made Easy!</h1>
<h3>Documentation for JavaScript Form Validator</h3>
<HR size=1>
<P>
The Form validation script is distributed free from JavaScript-Coder.com<br>
You can use the script in your web pages for free.
</P>
<P>
You may please add a link to JavaScript-Coder.com,
making it easy for others to find this script.<br>
Checkout the <A href="http://www.javascript-coder.com/links/how-to-link.php
target="_blank">Give a Link & Get a Link!</A> page.
</P>
<P>
<B>JavaScript Coder</B><br>
It precisely codes what you imagine!<br>
Grab your copy here: http://www.javascript-coder.com
</P>
<HR size=1>
<P>
Using client side JavaScript is an efficient way to validate the user input
in web applications. When there are many fields in the form, the JavaScript
validation becomes too complex.
</P>
<P>
The JavaScript class presented here makes the form validations many times easier.
</P>
<P>
The idea is to create a set of "validation descriptors" associated with each element
in a form. The "validation descriptor" is nothing but a string specifying the type of
validation to be performed.
</P>
<P>
Each field in the form can have 0, 1, or more validations. For example, the input should
not be empty, should be less than 25 chars, should be alpha-numeric, etc
</P>
You can associate a set of validation descriptors for each input field in the form.
<a name="3"></a>
<h3>Using The Script</h3>
1.Include gen_validatorv2.js in your html file just before closing the HEAD tag<br><br>
<CODE>
<script language="JavaScript" src="gen_validatorv2.js" type="text/javascript"></script><BR>
</head><BR>
</CODE><br>
2. Just after defining your form,
Create a form validator object passing the name of the form<br><br>
<CODE class='htm'>
<FORM name='myform' action=""><BR>
<!----Your input fields go here --><BR>
</FORM><BR>
</CODE><CODE>
<SCRIPT language="JavaScript"><BR>
var frmvalidator = new Validator("myform");<BR>
</CODE>
<br>
<br>
3. Now add the validations required<br><br>
<CODE>
frmvalidator.addValidation("FirstName","alpha");
</CODE><br><br>
the first argument is the name of the field and the second argument is the
validation descriptor, which specifies the type of validation to be performed.<br>
You can add any number of validations.The list of validation descriptors are provided
at the end of the documentation.<br>
The optional third argument is the error string to be displayed if the validation
fails.<br>
<br>
<CODE>
frmvalidator.addValidation("FirstName","alpha");<br>
frmvalidator.addValidation("FirstName","req","Please enter your First Name");<br>
frmvalidator.addValidation("FirstName","maxlen=20",<br>
"Max length for FirstName is 20"); <br>
</CODE> <br>
<br>
4. Similarly, add validations for the fields where validation is required.<br>
That's it! You are ready to go.
<A name="3"></A>
<h3>Example</h3>
The example below will make the idea clearer<br>
<CODE class="htm">
<form action="" name="myform" ><BR>
<table cellspacing="2" cellpadding="2" border="0"><BR>
<tr><BR>
<td align="right">First Name</td><BR>
<td><input type="text" name="FirstName"></td><BR>
</tr><BR>
<tr><BR>
<td align="right">Last Name</td><BR>
<td><input type="text" name="LastName"></td><BR>
</tr><BR>
<tr><BR>
<td align="right">EMail</td><BR>
<td><input type="text" name="Email"></td><BR>
</tr><BR>
<tr><BR>
<td align="right">Phone</td><BR>
<td><input type="text" name="Phone"></td><BR>
</tr><BR>
<tr><BR>
<td align="right">Address</td><BR>
<td><textarea cols="20" rows="5" name="Address"></textarea></td><BR>
</tr><BR>
<tr><BR>
<td align="right">Country</td><BR>
<td><BR>
<SELECT name="Country"><BR>
<option value="" selected>[choose yours]<BR>
<option value="008">Albania<BR>
<option value="012">Algeria<BR>
<option value="016">American Samoa<BR>
<option value="020">Andorra<BR>
<option value="024">Angola<BR>
<option value="660">Anguilla<BR>
<option value="010">Antarctica<BR>
<option value="028">Antigua And Barbuda<BR>
<option value="032">Argentina<BR>
<option value="051">Armenia<BR>
<option value="533">Aruba <BR>
</SELECT><BR>
</td><BR>
</tr><BR>
<tr><BR>
<td align="right"></td><BR>
<td><input type="submit" value="Submit"></td><BR>
</tr><BR>
</table><BR>
</form><BR>
</CODE><CODE>
<script language="JavaScript" type="text/javascript"><BR>
var frmvalidator = new Validator("myform");<BR>
frmvalidator.addValidation("FirstName","req","Please enter your First Name");<BR>
frmvalidator.addValidation("FirstName","maxlen=20",<BR>
"Max length for FirstName is 20");<BR>
frmvalidator.addValidation("FirstName","alpha");<BR>
<BR>
frmvalidator.addValidation("LastName","req");<BR>
frmvalidator.addValidation("LastName","maxlen=20");<BR>
<BR>
frmvalidator.addValidation("Email","maxlen=50");<BR>
frmvalidator.addValidation("Email","req");<BR>
frmvalidator.addValidation("Email","email");<BR>
<BR>
frmvalidator.addValidation("Phone","maxlen=50");<BR>
frmvalidator.addValidation("Phone","numeric");<BR>
<BR>
frmvalidator.addValidation("Address","maxlen=50");<BR>
frmvalidator.addValidation("Country","dontselect=0");<BR>
</script><BR>
</CODE>
<A name="4"></A>
<h3>Some Additional Notes</h3>
<LI type="disc">The form validators should be created only after defining the HTML form
(only after the </form> tag. )<br>
<LI type="disc">Your form should have a distinguished name.
If there are more than one form
in the same page, you can add validators for each of them. The names of the
forms and the validators should not clash.
<LI type="disc">You can't use the javascript onsubmit event of the form if it you are
using this validator script. It is because the validator script automatically overrides the
onsubmit event. If you want to add a custom validation, see the section below
</LI>
<A name="5"></A>
<h3>Adding Custom Validation</h3>
If you want to add a custom validation, which is not provided by the validation descriptors,
you can do so. Here are the steps:
<LI type="disc">Create a javascript function which returns true or false depending on the validation.<br>
<CODE>
function DoCustomValidation()<BR>
{<BR>
var frm = document.forms["myform"];<BR>
if(frm.pwd1.value != frm.pwd2.value)<BR>
{<BR>
alert('The Password and verified password does not match!');<BR>
return false;<BR>
}<BR>
else<BR>
{<BR>
return true;<BR>
}<BR>
}<BR>
</CODE><br>
<LI type="disc">Associate the validation function with the validator object.<br>
<CODE>
frmvalidator.setAddnlValidationFunction("DoCustomValidation");
</CODE><br>
</LI>
<P>
The custom validation function will be called automatically after other validations.
</P>
<P>
If you want to do more than one custom validations, you can do all those
validations in the same function.
</P>
<CODE>
function DoCustomValidation()<BR>
{<BR>
var frm = document.forms["myform"];<BR>
if(false == DoMyValidationOne())<BR>
{<BR>
alert('Validation One Failed!');<BR>
return false;<BR>
}<BR>
else<BR>
if(false == DoMyValidationTwo())<BR>
{<BR>
alert('Validation Two Failed!');<BR>
return false;<BR>
}<BR>
else<BR>
{<BR>
return true;<BR>
}<BR>
}<BR>
</CODE><br>
where DoMyValidationOne() and DoMyValidationTwo() are custom functions for
validation.
<A name="6"></A>
<h3>Clear All Validations</h3>
In some dynamically programmed pages, it may be required to change the validations in the
form at run time. For such cases, a function is included which clears all validations in the
validator object.<br><br>
<CODE>
frmvalidator.clearAllValidations();
</CODE><br>
<br>
this function call clears all validations you set.<br>
You will not need this method in most cases.
<a name="7"></a>
<h3>Table of Validation Descriptors</h3>
<table cellspacing="2" cellpadding="2" border="1" width="520px">
<tr>
<td><FONT face=Arial size=2>
required<BR>
req </FONT>
</td>
<td><FONT face=Arial size=2>The field should not be
empty </FONT>
</td>
</tr>
<tr>
<td><FONT face=Arial size=2>
maxlen=???<BR>
maxlength=???
</td>
<td><FONT face=Arial size=2>checks the length entered data to the maximum. For
example, if the maximum size permitted is 25, give the validation descriptor as "maxlen=25"
</td>
</tr>
<tr>
<td><FONT face=Arial size=2>
minlen=???<BR>
minlength=???
</td>
<td><FONT face=Arial size=2>checks the length of the entered string to the
required minimum. example "minlen=5"
</td>
</tr>
<tr>
<td><FONT face=Arial size=2>
alphanumeric /<BR>
alnum </FONT>
</td>
<td><FONT face=Arial size=2>Check the data if it
contains any other characters other than alphabetic or numeric characters
</FONT>
</td>
</tr>
<tr>
<td><FONT face=Arial size=2>num <BR>
numeric </FONT>
</td>
<td><FONT face=Arial size=2>Check numeric data
</FONT>
</td>
</tr>
<tr>
<td><FONT face=Arial size=2>alpha <BR>
alphabetic </FONT>
</td>
<td><FONT face=Arial size=2>Check alphabetic data.
</FONT>
</td>
</tr>
<tr>
<td><FONT face=Arial size=2>email </FONT>
</td>
<td><FONT face=Arial size=2>The field is an email
field and verify the validity of the data. </FONT>
</td>
</tr>
<tr>
<td><FONT face=Arial size=2>lt=???<BR>
lessthan=???
</td>
<td><FONT face=Arial size=2>
Verify the data to be less than the value passed.
Valid only for numeric fields. <BR>
example: if the
value should be less than 1000 give validation description as "lt=1000"
</td>
</tr>
<tr>
<td><FONT face=Arial size=2>gt=???<BR>
greaterthan=??? </td>
<td><FONT face=Arial size=2>
Verify the data to be greater than the value passed.
Valid only for numeric fields. <BR>
example: if the
value should be greater than 10 give validation description as "gt=10"
</td>
</tr>
<tr>
<td><FONT face=Arial size=2>regexp=??? </FONT>
</td>
<td><FONT face=Arial size=2>
Check with a regular expression the value should match the regular expression.<BR>
example: "regexp=^[A-Za-z]{1,20}$" allow up to 20 alphabetic
characters.
</td>
</tr>
<tr>
<td><FONT face=Arial size=2>dontselect=?? </FONT>
</td>
<td><FONT face=Arial size=2>This
validation descriptor is valid only for select input items (lists)
Normally, the select list boxes will have one item saying 'Select One' or
some thing like that. The user should select an option other than this
option. If the index of this option is 0, the validation description
should be "dontselect=0"
</td>
</tr>
</table>
<P>
<table cellspacing="2" cellpadding="2" border="1" width="520">
<tr>
<td>
<B>NOTE:</B><br>
The HTML Form Wizard included in JavaScript Coder contains still more
number of validations
(comparison validations, check box & radio button validations and more)<br>
Using the wizard, you can add validations to your forms
without writing a single line of code! <br>
JavaScript Coder takes care of
generating the code and inserting the code in to the HTML file.<br>
<A href="http://www.javascript-coder.com/index.phtml
target="_blank">Read more about JavaScript Coder</A>
</td>
</tr>
</table>
</P>
<A name="8"></A>
<h3>Example Page</h3>
See the <a href="example.html target="_blank"
>JavaScript form validation example here</a>
</td>
</tr>
<tr><td align="center">
<HR><br>
Copyright © 2003 JavaScript-Coder.com. All rights reserved.
</td></tr>
</table>
</center>
</body>
</html>The code is not working because you made a mistake somewhere, duh! So figure out what (hint: firefox javascript console, it's your friend) and fix it!
And next time when you post code: use the [ code ] tags to pretty format your code, as it is now it's unreadable.
http://forum.java.sun.com/help.jspa?sec=formatting -
What is wrong with this code? on(release) gotoAndPlay("2")'{'
Please could someone tell me what is wrong with this code - on(release)
gotoAndPlay("2")'{'
this is the error that comes up and i have tried changing it but it is not working
**Error** Scene=Scene 1, layer=Layer 2, frame=1:Line 2: '{' expected
gotoAndPlay("2")'{'
Total ActionScript Errors: 1 Reported Errors: 1
ThanksIf you have a frame labelled "2" then it should be:
on (release) {
this._parent.gotoAndPlay("2");
or other wise just the following to go to frame 2:
on (release) {
this._parent.gotoAndPlay(2);
You just had a missing curly bracket... -
Can i add an if statement anywhere in this code?
I need to add an if statement anywhere in this code, it doesnt matter where, but if it is nested it would be better. any ideas?
import java.text.DecimalFormat;
import javax.swing.JOptionPane;
import javax.swing.*;
import java.util.*;
import static java.lang.System.out;
import java.util.Scanner;
//Defines the counter for the student count and the lists for students
//to be saved in
public class EdronProject {
private int studentCount;
private static final String USAGE = "Usage: java EdronProject <student count>";
private List<Student> list;
//Set up the counter fo the number of students and the list in which
//each student's information is saved once processed
public EdronProject(int count) {
studentCount = count;
list = new ArrayList<Student>();
//Checks the number or arguments, and it executes the rest of the code
//if there is 1 argument or more (the number of arguments = the number
//of students being processed)
public static void main( String args[] ) throws NumberFormatException {
int count = 0;
switch (args.length) {
case 1: count = Integer.parseInt(args[0]); break;
default: System.out.println(USAGE);
//Defines method for processing and printing students within the
//EdronProject class
EdronProject edp = new EdronProject(count);
edp.processStudents();
edp.printStudents();
class Student {
//Define integer values for the 5 subject's grades, the gradeCounter (used
//in the processing stage) and the student name string
private int
gradeCounter,
grade1,
grade2,
grade3,
grade4,
grade5;
private double total;
private String studentName;
//Use setter getter methods for the student name to be retrieved
public void setStudentName(String name) {
studentName = name;
public String getStudentName() {
return( studentName );
//Use setter getter methods for the grades inputted to be retrieved
//by the processing stage
public void setGrade(int gradeNo, int grade) throws IllegalArgumentException {
switch( gradeNo) {
case 1 : grade1 = grade; break;
case 2 : grade2 = grade; break;
case 3 : grade3 = grade; break;
case 4 : grade4 = grade; break;
case 5 : grade5 = grade; break;
default: throw new IllegalArgumentException("ERROR: Bad grade number passed!");
//Increase grade counter for it to register the number of grades inputted
//by user
gradeCounter++;
public int getGrade(int gradeNo) throws IllegalArgumentException {
int grade = 0;
switch( gradeNo) {
case 1 : grade = grade1; break;
case 2 : grade = grade2; break;
case 3 : grade = grade3; break;
case 4 : grade = grade4; break;
case 5 : grade = grade5; break;
default: throw new IllegalArgumentException("ERROR: Bad grade number passed!");
//Return grade values for them to be used by the processing stage
return( grade );
//Calculate the total by adding al 5 grade values
public double getTotal() {
total = (getGrade(1) + getGrade(2) + getGrade(3) + getGrade(4) + getGrade(5));
//Total value returned for it to be used to calculate the average
return total;
//Average is calculated by dividing the total over the grade
//counter (number of grades inputted)
public double getAverage() {
return ( (gradeCounter == 0) ? 0 : total / gradeCounter);//Get input from user for student's 5 grades which are set as Grade 1, 2, 3, 4, 5
//and each five inputs for the student are saved to their own list along with the
//student name
public void processStudents() {
for (int counter = 0; counter < studentCount; counter++) {
Student student = new Student();
student.setStudentName(JOptionPane.showInputDialog("Enter student's name:"));
student.setGrade(1, Integer.parseInt(JOptionPane.showInputDialog( "Enter the student's grade for Psychology \n(You may ONLY use whole positive numbers ranging from 0 to 10)")));
student.setGrade(2, Integer.parseInt(JOptionPane.showInputDialog( "Enter the student's grade for Math \n(You may ONLY use whole positive numbers ranging from 0 to 10)")));
student.setGrade(3, Integer.parseInt(JOptionPane.showInputDialog( "Enter the student's grade for Art \n(You may ONLY use whole positive numbers ranging from 0 to 10)")));
student.setGrade(4, Integer.parseInt(JOptionPane.showInputDialog( "Enter the student's grade for Science \n(You may ONLY use whole positive numbers ranging from 0 to 10) ")));
student.setGrade(5, Integer.parseInt(JOptionPane.showInputDialog( "Enter the student's grade for English \n(You may ONLY use whole positive numbers ranging from 0 to 10)")));
list.add(student);
//Begin printting stage for each student entered
public void printStudents() {
for ( int i = 0; i < list.size(); i++ ) {
Student s = list.get(i);
printStudent(s);
//Print the student name along with each grade entered separated by commas
//and the total and average values in separate lines
private void printStudent(Student student) {
System.out.println("Student Name: "+student.getStudentName()
+", Pych: "+student.getGrade(1)
+", Math: "+student.getGrade(2)
+", Art : "+student.getGrade(3)
+", Sci : "+student.getGrade(4)
+", Eng : "+student.getGrade(5)
+",\n Total : "+student.getTotal()
+",\n Average: "+student.getAverage()+"\n");
Maybe you are looking for
-
How can I prevent pages from opening documents from last session
During my last session using Pages I selected and opened several documents. These documents were image heavy and pages froze. Now I can't open any document without pages trying to open all these documents and freezing. I've spent two hours trying
-
How do I sync a voice memo from iphone to itunes?
I'm trying to sync a voice memo on my 3Gs before I set up my 4Gs but even when I select sync voice memos under Music in itunes it doesn't show up in itunes. I have two memos; one syncs, the other stays only on the iphone! What am I doing wrong? It
-
Website with list of phones that are isync compatible?
My mum is upgrading her mobile phone but wants to ensure she only upgrades to a handset that is compatible with isync, does anyone know of a website or something that lists phones that are compatible? She currently has a Nokia 6233 and it can't isync
-
Movie Inspector Does Not Appear
Movie Inspector Does Not Appear anymore...no matter what...anyone else ever have this problem, and found a solution??..tried repairing permisions, disc, etc etc.... running qt 7.5.5, and if possible, I do not want to update... Message was edited by:
-
Can't fit 73mb of songs on a 700mb disk?
I was asked to copy a disk for a friend, just 73.6MB of songs on a 700MB CD-R. The songs imported easily, but when I tried to burn the playlist, I was told they wouuldn't fit!??