Inserting Timestamp into a SQL database

Question

I am having a problem inserting a timestamp into a Sql Database. I keep getting this error or a different on when i format the timestamp differently. In the following code the timestamp is not formated at all.
java.sql.SQLException: [Microsoft][ODBC SQL Server Driver][SQL Server]Line 1: Incorrect syntax near '13'
this is the sql statement that is executed
insert into timesheet(IDNUM,TimeIn,TimeOut,HoursWorked) values (123 , 2005-07-15 13:20:06.062 , 2005-07-15 13:20:06.062 ,0)
the code is as follows:
     <%
     try
            SimpleDateFormat test = new SimpleDateFormat("yyyy-MM-dd hh:mm:ss");
            Timestamp stamp = new Timestamp(System.currentTimeMillis());
            java.util.Date date = new java.util.Date();
            String sql = "insert into timesheet(IDNUM,TimeIn,TimeOut,HoursWorked) values (" + session.getAttribute("IDNum") + " , " + stamp + " , " + stamp + " ,0)";
            Class.forName("sun.jdbc.odbc.JdbcOdbcDriver");
            Connection cnxn = DriverManager.getConnection("jdbc:odbc:EmployeeSystem");
            Statement stmt = cnxn.createStatement();
             stmt.execute(sql);
            response.sendRedirect("employee.jsp");
     catch(Exception dberr)
         SimpleDateFormat test = new SimpleDateFormat("yyyyMMddhhmm");
         Timestamp stamp = new Timestamp(System.currentTimeMillis());
         out.println(dberr);
         out.println("insert into timesheet(IDNUM,TimeIn,TimeOut,HoursWorked) values (" + session.getAttribute("IDNum") + " , " + stamp + " , " + stamp + " ,0)");
     %>please help.
The reason that i need the timestamps in there is that i am creating a time clock program for my school that they can put on a intranet so thier hourly employees can use instead of the current manual system they use.

Answer 1

even better would be to use prepared statements and set the fields via Timestamp objects.
String sql = "insert into timesheet(IDNUM ,TimeIn ,TimeOut ,HoursWorked ) values (?,?,?,?)";
Statement stmt = cnxn.prepareStatement(sql);
int idNum = (Integer)session.getAttribute("IDNum").intValue();
Timestamp stamp = new Timestamp(System.currentTimeMillis());
stmt.setInt(1, idNum);
stmt.setTimeStamp(2, stamp);
stmt.setTimeStamp(3, stamp);
stmt.setInt(4, 0);
stmt.execute();It makes your code much more portable, as you don't have to worry about the database having a TO_DATE function with that syntax.
Cheers,
evnafets