Isn't there a flaw in this query?

Question

I've been asked to review this stored proc (an SP with OUT parameter). If you look at the code below, After the UPDATE of RSP_RQ table, the developer is trying to pad the values into comma separated string. But p_rptReqstId is hardcoded to '1' , so, In line 45, the ELSE bit will never get executed and the coma separated string will never be formed. Am i right?
Another question on formatting for readability? Once i put the code ({}) tags, i can't seem to Bold the text inside the code tags for highlighing purposes? How can i make a word BOLD which is inside the code tags?
CREATE OR REPLACE PROCEDURE get_nxtprcId
(in_maxCnt          IN integer DEFAULT 5,
in_dynReqstr          IN VARCHAR2 DEFAULT NULL,
in_dynServType          IN varchar2 DEFAULT NULL,
in_rptTurnReqStr     IN varchar2 DEFAULT NULL,
p_rptReqstId          OUT varchar2
As
  TYPE rptid_type IS TABLE OF RSP_RQ.rpt_reqst_id%TYPE;
  v_stmt VARCHAR2(4096);
  rptid_array   rptid_type;
  v_rptid     RSP_RQ.rpt_reqst_id%TYPE;
  BEGIN
  p_rptReqstId := '1';   --Parameter hardcoded to '1'
  .code where v_stmt string is built
EXECUTE IMMEDIATE v_stmt BULK COLLECT
INTO rptid_array
using in_maxCnt;
-- For each Record...
FOR j IN 1 .. rptid_array.COUNT LOOP v_rptid := rptid_array(j);
     --Update the stat_code by 8
Update RSP_RQ rpq
SET rpq.STAT_CODE       = (rpq.STAT_CODE + 8),
rpq.mod_date_time   = sysdate
where rpq.RPT_REQST_ID = v_rptid;
-- Process only if a record has been updated...
if (SQL%ROWCOUNT > 0) then
     if (p_rptReqstId = '1') then
          -- Taking the first element from the associative array...
          p_rptReqstId := v_rptid;      
          else          -- LINE 45. this else bit won't be processed since  p_rptReqstId hardcoded to '1'          
          -- Add it to the list...
          p_rptReqstId := trim(p_rptReqstId) || ', ' || v_rptid;
     end if;
end if;
end loop;Edited by: user10633418 on Feb 16, 2009 4:44 AM
Edited by: user10633418 on Feb 16, 2009 6:21 AM

Answer 1

SQL> create or replace procedure get_nxtprcid(p_rptreqstid out varchar2)
as
begin
   p_rptreqstid := '1'; --Parameter hardcoded to '1'
   if (p_rptreqstid = '1')
   then
      dbms_output.put_line('You are right');
   else
      -- LINE 45. this else bit won't be processed since  p_rptReqstId hardcoded to '1'
      dbms_output.put_line('p_rptReqstId is ' || p_rptreqstid);
   end if;
end get_nxtprcid;
Procedure created.
SQL> set serveroutput on
SQL> declare
   my_id   varchar2(5) := 'a';
begin
   get_nxtprcid(my_id);
end;
You are right
PL/SQL procedure successfully completed.
SQL>Regards
Peter
Edit:
Ouch, missed the point that OP's code is executed in a LOOP. John Spencer got it correct below
Edited by: Peter on Feb 16, 2009 1:45 PM