Issue with Update Routine

Question

Hi Experts,
I tried the below code to calculate the no of days between Document Created date and System date. Also it is a condition that if a record is created yesterday and if its created time is greater than 17hrs, then the no of days shld be zero. But this code isn't working that way.
For any records created yesterday after 17hrs, the code still produces days as 1.
FYI - The Fuctional Module always adds one more to the differnce day and hence the line
  RESULT = OUT - 1.
Any Suggestions is highly appreciated.
Thanks,
DV
The code is
PROGRAM UPDATE_ROUTINE.
$$ begin of global - insert your declaration only below this line  -
TABLES: ...
DATA:   ...
TABLES: /BIC/PZCRM_ITM.
*DATA: IT_ZCRMITM LIKE /BIC/PZCRM_ITM OCCURS 0 WITH HEADER LINE.
DATA: BEGIN OF IT_ZCRMITM OCCURS 0,
          /BIC/ZCRM_ITM LIKE /BIC/PZCRM_ITM-/BIC/ZCRM_ITM,
          CREA_TIME LIKE /BIC/PZCRM_ITM-CREA_TIME,
      END    OF IT_ZCRMITM.
SELECT /BIC/ZCRM_ITM CREA_TIME FROM
/BIC/PZCRM_ITM INTO TABLE IT_ZCRMITM.
DATA: CUR_DATE LIKE SY-DATUM,
      PRE_DATE LIKE SY-DATUM,
      DOC_DATE LIKE SY-DATUM,
      TIME_CREA LIKE SY-UZEIT,
      OUT LIKE SY-TABIX.
$$ end of global - insert your declaration only before this line   -
FORM compute_key_field
  TABLES   MONITOR STRUCTURE RSMONITOR "user defined monitoring
  USING    COMM_STRUCTURE LIKE /BIC/CS80CRM_PRI
           RECORD_NO LIKE SY-TABIX
           RECORD_ALL LIKE SY-TABIX
           SOURCE_SYSTEM LIKE RSUPDSIMULH-LOGSYS
  CHANGING RESULT LIKE /BIC/VZCRM_PRI1T-/BIC/ZOPENDAYS
           RETURNCODE LIKE SY-SUBRC
           ABORT LIKE SY-SUBRC. "set ABORT <> 0 to cancel update
$$ begin of routine - insert your code only below this line        -
fill the internal table "MONITOR", to make monitor entries
  CLEAR: CUR_DATE.
  CLEAR: OUT.
  CLEAR: DOC_DATE.
  CLEAR: TIME_CREA.
result value of the routine
***Get Time Created***
READ TABLE IT_ZCRMITM WITH KEY
/BIC/ZCRM_ITM = COMM_STRUCTURE-/BIC/ZCRM_ITM.
IF SY-SUBRC = 0.
TIME_CREA  = IT_ZCRMITM-CREA_TIME.
ENDIF.
***Get Time Created***
***Get No of Days***
  CUR_DATE = SY-DATUM.
  DOC_DATE = COMM_STRUCTURE-calday.
  CALL FUNCTION 'Z_SELECT_FACTDAYS_FOR_PERIOD'
    EXPORTING
      I_DATAB  = DOC_DATE
      I_DATBI  = CUR_DATE
      I_FACTID = 'AU'
    IMPORTING
      OUT_DAYS = OUT.
***Get No of Days***
***Calculate appropriate No of Days for Yesterday's Records***
if time created is after 17.00 hrs then no of days for the records cre
otherwise the result will be OUT minus 1
  PRE_DATE = SY-DATUM - 1.
  IF DOC_DATE = PRE_DATE AND
    IT_ZCRMITM-CREA_TIME GT '170000'.
    RESULT = OUT - 2.
  ELSE.
    RESULT = OUT - 1.
  ENDIF.
***Calculate appropriate No of Days for Yesterday's Records***
if the returncode is not equal zero, the result will not be updated
  RETURNCODE = 0.
if abort is not equal zero, the update process will be canceled
  ABORT = 0.
$$ end of routine - insert your code only before this line         -

Answer 1

Hi Olivier,
Thanks for your response.
1. I will add the clause as u have suggested. But may I know teh scenario where we may find inactive master data- We load and activaet the master data daily.
2. The function module code is as below. This FM is similar to one in R3 I think u can find by searching with SELECT_FACTDAYS
FUNCTION Z_SELECT_FACTDAYS_FOR_PERIOD.
""Local Interface:
*"  IMPORTING
*"     REFERENCE(I_DATAB) LIKE  SY-DATUM
*"     REFERENCE(I_DATBI) LIKE  SY-DATUM
*"     REFERENCE(I_FACTID) LIKE  TFACT-IDENT
*"  EXPORTING
*"     REFERENCE(OUT_DAYS) LIKE  SY-TABIX
  DATA: L_V_AKTDAT LIKE SCAL-DATE.
  DATA: L_V_INDICATOR LIKE SCAL-INDICATOR.
CLEAR  : ETH_DATS.
REFRESH: ETH_DATS.
  L_V_AKTDAT = I_DATAB.
do it for all days in space of time
  WHILE L_V_AKTDAT <= I_DATBI.
    CALL FUNCTION 'DATE_CONVERT_TO_FACTORYDATE'
         EXPORTING
              DATE                         = L_V_AKTDAT
              FACTORY_CALENDAR_ID          = I_FACTID
         IMPORTING
              WORKINGDAY_INDICATOR         = L_V_INDICATOR
         EXCEPTIONS
              CALENDAR_BUFFER_NOT_LOADABLE = 1
              CORRECT_OPTION_INVALID       = 2
              DATE_AFTER_RANGE             = 3
              DATE_BEFORE_RANGE            = 4
              DATE_INVALID                 = 5
              FACTORY_CALENDAR_NOT_FOUND   = 6
              OTHERS                       = 7.
   IF SY-SUBRC NE 0.
     MESSAGE ID SY-MSGID TYPE SY-MSGTY NUMBER SY-MSGNO
             WITH SY-MSGV1 SY-MSGV2 SY-MSGV3 SY-MSGV4.
            RAISING DATE_CONVERSION_ERROR.
   ENDIF.
indicator is space if actual day is a working day
if indicator is not space the actual day isn't a working day
    IF L_V_INDICATOR EQ SPACE.
     CLEAR ETH_DATS.
     ETH_DATS-PERIODAT = L_V_AKTDAT.
     APPEND ETH_DATS.
      out_days = out_days + 1.
    ENDIF.
    L_V_AKTDAT = L_V_AKTDAT + 1.
  ENDWHILE.
ENDFUNCTION.
3. There will be always a masterr data record, coz we load them daily. and the load is a full update so no records gets deleted.
4. The load will be a Daily load. Business wants to capture the Snapshot for that day.  So apart from deciding the no of days based on created time, the other logic works fine.
So my suspecian is that the part which decides based on Time created is not actually working in the way we expeceted.
DV
Message was edited by:
        DVMC