Issues with IN clause...

Question

dear all,
I have following piece of code as shown below, as i have written
CREATE OR REPLACE Procedure p_test As
v_pamlg_plots_oprn1 Number := 1001;
v_pamlg_plots_oprn2 Number := 1011;
v_pamlg_plots_oprn3 Number := 1100;
v_pamlg_plots_oprn4 Number := 1110;
v_pamlg_plots_oprn5 Number := 1111;
v_pamlg_plots_oprn  Varchar2(30);
v_qty               Number;
Begin
Select v_pamlg_plots_oprn1||','||v_pamlg_plots_oprn2||','||v_pamlg_plots_oprn3||','||v_pamlg_plots_oprn4||','||v_pamlg_plots_oprn5
Into v_pamlg_plots_oprn
From dual;
dbms_output.put_line(' v_pamlg_plots_oprn -->>'||v_pamlg_plots_oprn);
Select Sum(d.Qty)
   Into v_Qty
   From Daily_Stock_Detail_Mal_Lpcs d
  Where d.Product = 65019216
    And d.Operation In (v_Pamlg_Plots_Oprn);
dbms_output.put_line ('v_qty -->>'||v_qty);
Exception
When Others Then
dbms_output.put_line(Substr(Sqlerrm, 1, 200));
End;
now the procedure is getting sucessfully compiled, and executed with no errors,
however i want to see the qty (v_qty and its always shown null) even though the record exists in the base table...
I am sorry as i cant post the data, but is this correct way of using in clause??
plz let me know,

Answer 1

Nicloei W wrote:
CREATE OR REPLACE Procedure p_test As
v_pamlg_plots_oprn1 Number := 1001;
v_pamlg_plots_oprn2 Number := 1011;
v_pamlg_plots_oprn3 Number := 1100;
v_pamlg_plots_oprn4 Number := 1110;
v_pamlg_plots_oprn5 Number := 1111;Not structured programming. What happens if there needs to be a 6th number? Or 7th? Add more variables and hack the code some more?
It is far easier and a lot more flexible, to deal with this as structured data, using intelligent and flexible data structures. In this case, you need an array of numbers. This is defined in SQL as an Advance Data Type:
create or replace type TNumbers as table of number;In your code, you can now define a single variable with all 5 number values:
create or replace procedure ....
   numList TNumbers := new TNumbers( 1001, 1011, 1100, 1110, 1111 );
..To use this collection/array in a SQL statement, you simply code something along the following lines (and note that no literal values are coded in the SQL in order to optimise cursor re-usability):
select
  sum(d.qty) into productQty
from daily_stock_detail  d
where d.product = productID
and d.operation in (select * from TABLE(numList));Easy.. with structured programming and structured data. To add more numbers is now simply an update to the array's initialisation. Remainder of the code remains unchanged. No new variables to define. No hacking.
As for this smelly brown gunk you're written:
Exception
When Others Then
dbms_output.put_line(Substr(Sqlerrm, 1, 200));
End;DON'T!!! This is NOT how exception handlers work. EVER!!