JSF 1.2 ValueExpressions error.

Question

Hello guys,
I have written a small JSF 1.2 component and I am running into all sorts of problems when using the expression langauge
here is my simple component with two properties text and icon. I am running this on glassfish and i made sure i am using the correct jars.
help anyone????
//component code
public class MyComponent extends UIComponentBase  {
//tag code
public class MyComponentTag extends UIComponentELTag{
  private ValueExpression text;
  private ValueExpression icon;
  //getters and setters
  //set properties method
  protected void setProperties(UIComponent component) {
    super.setProperties(component);
    MyComponent myComponent = (MyComponent)component
    if (null != text) {
      if (!text.isLiteralText()) {
        myComponent.setValueExpression("text", text);
      else {
        myComponent.setText(text.getExpressionString());
    if (null != icon) {
      if (!icon.isLiteralText()) {
        myComponent.setValueExpression("icon", icon);
      else {
        myComponent.setIcon(icon.getExpressionString());
}the JSP page
This is working no problem, if i want to use read only values
<w:mycomponent text="${myBean.text}" icon="${myBean.icon}" />this is not working i am getting the following error
<w:mycomponent text="My Component Text"  />trimmed error stack
org.apache.jasper.JasperException: jsp.error.beans.property.conversion
  org.apache.jasper.runtime.JspRuntimeLibrary.getValueFromPropertyEditorManager(JspRuntimeLibrary.java:890)but this is the work around, its working but it looks very very odd, i looked at the blue prints they are not using this kind of syntax.
<w:mycomponent text="${'My Component Text'}"  />this isn't working as well.
<w:mycomponent text="#{myBean.text}"  />

Answer 1

I'm not sure what tag class is being extended: UIComponentELTag? My component tag classes all extend UIComponentTag.
Furthermore, all of my tag attributes are defined as String. In reviewing your code, I wasn't sure why the tag attribute variables are being declared as ValueExpression type?
I think I see what you are trying to do... and would recommend the tag class be structured as follows. If you can provide more information regarding what HTML your component is supposed to generate, I would be happy to help more.
public class MyComponentTag extends UIComponentTag
public static final String COMPONENT_TYPE = "MyComponent";
String text;
String icon;
public void release()
super.release();
text = null;
icon = null;
protected void setProperties(UIComponent component)
super.setProperties(component);
if (text != null)
if (UIComponentTag.isValueReference(text))
FacesContext context = FacesContext.getCurrentInstance();
Application app = context.getApplication();
ValueBinding vb = app.createValueBinding(text);
component.setValueBinding("text", vb);
else
component.getAttributes().put("text", text);
// Something similar for icon attribute goes here.
public String getComponentType()
return COMPONENT_TYPE;
public String getRendererType()
return null;
// Getters and setters for text and icon go here.
}