Keeps printing done...

Question

I know why this code keeps printing done, its one my for loops. Currently this code does percisily what I want it to with a few hiccups that will be fixed. The current problem is that it keeps printing done for each row or record it places in the csv file. I need it to print to the file and then when it is truly done - print done. Also this is really slow....there are 1500+ records to pull from the cdata section, convert to comma delaminated and then place into the csv. the ripping and converting takes seconds. the writing's to the file takes .....well i never let it finish, every time I press stop its up to the 600th record and that's after a couple minutes.
I know I am missing something. I just need some eyes to look at it. its not the most efficient way to do this, I get that. All i care about right now is making it print done ONLY when it is truly DONE writing to the file - and it shouldn't take so long to write to a file. 600 records in 2 minutes? something is wrong.
Code is bellow. - prepare for a long read.
package xmlcsv;
import java.io.File;
import java.io.FileWriter;
import java.util.StringTokenizer;
import javax.xml.parsers.DocumentBuilder;
import javax.xml.parsers.DocumentBuilderFactory;
import org.w3c.dom.CDATASection;
import org.w3c.dom.CharacterData;
import org.w3c.dom.Document;
import org.w3c.dom.Element;
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;
* Essentially we take a xml file, find its cdata section and then
* process the information in there to then spit out to a csv file.
public class XmlCSV {
      * We need to process the data in the Cdata section and spit it out in a csv file.
      * This is the "main" part of the program which is run.
      * @param args
     public static void main(String[] args) throws Exception
          File file = new File("Data.xml");
          DocumentBuilder db = DocumentBuilderFactory.newInstance().newDocumentBuilder();
          Document doc = db.parse(file);
          doc.getDocumentElement().normalize();
          NodeList nodes = doc.getElementsByTagName("TransmissionWrapper");
          for (int i = 0; i< nodes.getLength(); i++)
               Element element = (Element) nodes.item(i);
               NodeList cData = element.getElementsByTagName("TransmissionData");
               Element line = (Element) cData.item(0);
               //test
               getInfo(getCData(line));
      * We want to get all the data out of the CData Section.
      * Pass it into the getInfo() method to then get the
      * the data which will be parsed and thrown into a csv file.
      * @param e
      * @return
     private static final String getCData(Element e)
          NodeList child = e.getChildNodes();
          if (child != null)
               for (int i = 0; i< child.getLength(); i++)
                    Node childNode = child.item(i);
                    if (childNode.getNodeType() == Node.CDATA_SECTION_NODE)
                         CDATASection cdata = (CDATASection) childNode;
                         String data = cdata.getData();
                         return data;
          return "Theres nothing there";
      * We want to remove all pipes then replace all those pipes with commas
      * the simple .replace() does not work. so we pass all the data into a string array and
      * pass it to a method that reforms the data and replaces pipes with commas
      * TODO: I didn't realize some information is comma deliminated so we have:
      * CHEVROLET,COBALT which may pose a problem later.
      * @throws Exception
     private static final String getInfo(String str) throws Exception
          StringTokenizer st = new StringTokenizer(str.trim());
          while (st.hasMoreTokens())
               String[] info = str.split("\\|", -1);
               for(int i = 0; i<info.length; i++)
                    returnComma(info);
          return "Nothing to return";
      * We take the String array of data and reform it back into
      * a comma deliminated peice of data that we can then use with CSV
      * @param str
      * @return
      * @throws Exception
     private static final String returnComma(String[] str) throws Exception
          StringBuffer sb = new StringBuffer();
          for (int i =0; str != null && i < str.length; i++)
               sb.append(str);
               if(i < str.length - 1)
                    sb.append(",");
          writeToFile(sb.toString(), "data2.csv");
          return null;
     * Write the data to a csv file.
     * @param st
     * @param filename
     * @throws Exception
     private static final void writeToFile(String st, String filename) throws Exception
          FileWriter fw = new FileWriter(filename);
          fw.append(st);
          fw.flush();
          fw.close();
          System.out.println("done");

Answer 1

The question(s) is: +"How do I make it write to the file and print done only when done?"+Move the print statement out of the loop?
+"Why is it taking up to 5-10 minutes to write 600 records to a file when it takes 30 seconds to parse the pipes, and put commas in and spit it out to the page"?+Because you are writing to the file every time you call returnComma(), and you are calling returnComma() lots of times. Most probably your entire file writing scheme is up the pole. You can't really want the file just to contain whatever the last invocation of returnComma() printed, and if you do why do all the preceding writes at all?
Also returnComma() doesn't return a comma. Poor naming. Fix its name to describe what it really does.