Killing an Updater Thread when I stop watch an JPanel

Question

Hi,
Firstly this is proably really bad code convention. What I am wondering is how to fix my problem and perhaps some guidance on what to do instead, I am unsurre as to how to model an Updater thread on a JPanel. What I am doing is updating the Icons in JTree when the data changes, this happens continally so there is no start finish defined.
I thought I could use isVisible() to work out when to terminate my updater thread, ut that doesnt seem to be the case. Any Ideas on what to do???
Thanks a Mill,
Anthony
public class MyTreePane extends TreePane {
     private boolean start = true;
     public XRiskHistoTreePane() throws Exception {
          super();
      * This threads jobs is to scan the
     private void startScannerThread() {
          Runnable  r = new Runnable(){
               public void run(){
                    int [] keys = getRiskKeys();
                    while(isVisible()){
                         for(int i = 0; i < keys.length; i++){
                              try {
                                   Reporter rep = UpdateClient.getPosition(keys);
                                   PercentageIcon icon = null;     
                                   if(rep != null){
                                        int per = (int) rep.getPercentage();
                                        icon = new PercentageIcon(per);
                                   setImageIcon(keys[i], icon);
                              } catch (Exception e) {
                                   e.printStackTrace();
          Thread t = new Thread(r);
          t.setName("Update Thread");
          t.start();
          t.setPriority(Thread.MIN_PRIORITY);
     public void paint(Graphics visible){
          super.paint(visible);
          if(start){
               startScannerThread();
               start = false;

Answer 1

Hi,<br> Firstly this is proably really bad code convention. What I am wondering is how to fix my problem and perhaps some guidance on what to do instead, I am unsurre as to how to model an Updater thread on a JPanel. What I am doing is updating the Icons in JTree when the data changes, this happens continally so there is no start finish defined. I thought I could use isVisible() to work out when to terminate my updater thread, ut that doesnt seem to be the case. Any Ideas on what to do???
<br>
Thanks a Mill, Anthony
<pre>
public class XTreePane extends TreePane (which extends JPanel) {
     private boolean start = true;
     public XTreePane() throws Exception {
          super();
     * This threads jobs is to scan the
     private void startScannerThread() {
          Runnable r = new Runnable(){
               public void run(){
                    int [] keys = getKeys();
                    while(isVisible()){
                         for(int i = 0; i < keys.length; i++){
                              try {
                                   Reporter rep = UpdateClient.aggregationPosition(keys);
                                   PercentageIcon icon = null;     
                                   if(rep != null){
                                        int per = (int) rep.getPercentage();
                                        icon = new PercentageIcon(per);
                                   setImageIcon(keys[i], icon);
                              } catch (Exception e) {
                                   e.printStackTrace();
          Thread t = new Thread(r);
          t.setName("Update Thread");
          t.start();
     public void paint(Graphics visible){
          super.paint(visible);
          if(start){
               startScannerThread();
               start = false;
</pre>