Learning... cursor and loop... suggestions?

Question

Although I'm looking for non version specific information...  Here is what I'm running on.
Oracle Database 11g Enterprise Edition Release 11.2.0.3.0 - 64bit Production
PL/SQL Release 11.2.0.3.0 - Production
CORE    11.2.0.3.0    Production
TNS for Solaris: Version 11.2.0.3.0 - Production
NLSRTL Version 11.2.0.3.0 - Production
I'm trying to figure out the whole relationship and execution of inserting data into a table, manipulating the table and anything else via a procedure using a cursor and a loop.
Sounds simple, but all the examples I find out there all deal with dbms_output..  obviously because it's 'safe'...
So I'm trying to use context that my mind makes quick sense of.
I built a simple table with vehicle makes, with the intention of using exercises to add models, trim levels, engines...pretty much all vehicle specifications.
CREATE TABLE VEH_COMP
  MAKE          VARCHAR2(20 BYTE),
  MODEL         VARCHAR2(50 BYTE),
  TRIM          VARCHAR2(50 BYTE),
  ENGINE        VARCHAR2(50 BYTE),
  TRANSMISSION  VARCHAR2(50 BYTE),
  HORSEPOWER    NUMBER,
  TORQUE        NUMBER
TABLESPACE USERS
RESULT_CACHE (MODE DEFAULT)
PCTUSED    0
PCTFREE    10
INITRANS   1
MAXTRANS   255
STORAGE    (
            INITIAL          80K
            NEXT             1M
            MINEXTENTS       1
            MAXEXTENTS       UNLIMITED
            PCTINCREASE      0
            BUFFER_POOL      DEFAULT
            FLASH_CACHE      DEFAULT
            CELL_FLASH_CACHE DEFAULT
LOGGING
NOCOMPRESS
NOCACHE
NOPARALLEL
MONITORING;
Next I tried to build a simple sql block to insert a handful of Auto makes into the table...  I know this is ugly, and here is where I'm looking for suggestions for improvement.
DECLARE
   CURSOR m1
   IS
   SELECT 'Ford' as make FROM DUAL
UNION ALL
SELECT 'Chevy' FROM DUAL
UNION ALL
SELECT 'Dodge' FROM DUAL
UNION ALL
SELECT 'BMW' FROM DUAL
UNION ALL
SELECT 'Audi' FROM DUAL
UNION ALL
SELECT 'Mercedes' FROM DUAL;
BEGIN
   FOR v_make IN m1
   LOOP
      dbms_output.put_line(v_make.make);
      insert into veh_comp (make) values (v_make.make);
   END LOOP;
END;
Now I'm looking to add models.  Like Ford Mustang, Ford Lightning, Chevy Corvette, Chevy Camaro, Dodge Charger, Dodge Challenger, Dodge Viper, BMW M5, BMW M3, BMW M6...
Then I need to add engine sizes...  I6, V8
Then I need to add transmission... M6, M5, A5, A6, A8
I'm a little confused as how I should execute this part.  Or better yet, I'm sure there is a better way to include it all at once...
I've been looking on line on how to do this and again...only really finding dbms_output.put_line.  And I did grasp how I could do something along this lines from using a spool file.  But I really want to learn to be more efficient.
What's the best way to do this?
Thanks.

Answer 1

From what I can gather from the code, if I create some example data, you just want a query that does something like...
SQL> select * from vw_ta;
       LID        SID         C0         C1         C2         C3
         1          1          1          2          3          4
         1          2          1          2          3          4
         1          3          1          2          3          4
         1          4          1          2          3          4
         1          5          1          2          3          4
         1          6          1          2          3          4
         2          1          1          2          3          4
         2          2          1          2          3          4
         2          3          1          2          3          4
         3          1          1          2          3          4
         3          2          1          2          3          4
         3          3          1          2          3          4
         3          4          1          2          3          4
         3          5          1          2          3          4
         3          6          1          2          3          4
         3          7          1          2          3          4
         4          1          1          2          3          4
         5          1          1          2          3          4
         5          2          1          2          3          4
19 rows selected.
SQL> ed
Wrote file afiedt.buf
  1      SELECT LID, SID, Cnt, Limits, dense_rank() over (order by lid) as grp, Iter
  2      FROM (SELECT LID
  3                  ,SID
  4                  ,COUNT(*) OVER (PARTITION BY LID) Cnt
  5                  ,TRUNC(COUNT(*) OVER (PARTITION BY LID)/4)*4 Limits
  6                  ,row_number() over (partition by LID order by SID desc) iter
  7            FROM VW_TA
  8            WHERE C0 > 0 AND C1 > 0 AND C2 > 0 AND C3 > 0
  9            ORDER BY LID, SID DESC
10           ) a
11*     WHERE ITER <= LIMITS
SQL> /
       LID        SID        CNT     LIMITS        GRP       ITER
         1          6          6          4          1          1
         1          5          6          4          1          2
         1          4          6          4          1          3
         1          3          6          4          1          4
         3          7          7          4          2          1
         3          6          7          4          2          2
         3          5          7          4          2          3
         3          4          7          4          2          4
8 rows selected.
You already had the iteration part in your query, you just needed the Group number which is achieved using a dense_rank on the result.