Loop won't complete process

Question

Good Morning,
I am reading about the execute immediate cmd here at my job and learning the syntax of it. I wrote this simple query but it hangs up after looping through 15 rows (tables). There are 137 rows (tables) that it needs to read in the schema. I don't understand why it doesn't continue until the end. Would someone please point out the short coming of this script? From what I remember yesterday the error message said something to the affect the table doesn't exist but yet when I look for it in toad it is there with information in it.
DECLARE
CURSOR c1 IS
select * from dba_tables
where owner = 'AL'
order by table_name;
BEGIN
FOR r1 in c1 LOOP
EXECUTE IMMEDIATE 'select '||r1.chain_cnt||','||r1.avg_row_len||
' from '|r1.table_name;
dbms_output.put_line (r1.table_name||','||r1.chain_cnt||','||r1.avg_row_len);
END LOOP;
END;
Thanks for your help in advance.
regards,
al

Answer 1

you really don't need execute immediate statement.Right. Taking it further there isn't really need for the cursor, the loop or the anonymous pl/sql block, either
select table_name, chain_cnt, avg_row_len
  from dba_tables
where owner = 'AL'
order by table_name;EXECUTE IMMEDIATE wouldn't be the first thing I'd read about. It's highly overrated, and used far too much because people want things to be "dynamic" and "flexible".
When you turn to dynamic SQL, rethink what you are doing. You might not need it, and if you don't need it, you don't want it.
Dynamic SQL is hard(er) to write, difficult to maintain, refer errors to runtime which could have been known at compile time, and causes both security and performance problems when used improperly.
Stick to static SQL whenever you can. But whatever you do, remember to use bind variables!
Regards
Peter