Looping through a list with an iterator

Question

Hi I have a list of objects allCrecords which I want to loop through using an iterator In the method printcoauthors I have to create another instance of class Extractdata because that's where the objects are added to the list allCrecords. The getauthor, getcoauthor and gettitle are methods in the Coauthorship class where this method printcoauthors is also
public void printcoauthors(String currentauthor){
         Extractdata ed = new Extractdata();
    for(Iterator it = ed.allCrecords.iterator();it.hasNext();){
        if(currentauthor.equals(getauthor()))
            System.out.println(getcoauthor());
        else if (currentauthor.equals(getcoauthor()))
            System.out.println(getauthor());
            System.out.println(gettitle());
           Object element = (Object)it.next();
    }thanks in advance

Answer 1

Here's the extractdata class it takes data from an xml file and stores it as strings or lists or arrays
public class Extractdata {
     public String name1, name2, TITLE;
          SNAnalyser sn = new SNAnalyser();
          Document doc = sn.extractDoc();
     public List allCrecords = new ArrayList();
  /** Creates a new instance of extractdata */
  public Extractdata(){
  public void extract(){ 
       List allauthors = new ArrayList();
       allauthors = Collections.synchronizedList(new ArrayList(allauthors));
       allCrecords = Collections.synchronizedList(new ArrayList(allCrecords));
       List alltitles = new ArrayList();
       alltitles = Collections.synchronizedList(new ArrayList(alltitles));
       String[] names = new String[20];
      NodeList records1 = doc.getElementsByTagName("record");
        for( int i = 0; i < records1.getLength();i++)
            Record records = null;
            Element record = (Element) records1.item(i);
            NodeList headers = record.getElementsByTagName("header");
            Element header = (Element) headers.item(0);
            NodeList ids = header.getElementsByTagName("identifier");       
                Element id = (Element) ids.item(0);
                String ID = getText(id);
                NodeList metadatas = record.getElementsByTagName("metadata");
                Element metadata = (Element) metadatas.item(0);
                NodeList citeseers = metadata.getElementsByTagName("oai_citeseer:oai_citeseer");
                Element citeseer = (Element) citeseers.item(0);
                NodeList titles = citeseer.getElementsByTagName("dc:title");
                Element title = (Element) titles.item(0);
                TITLE = getText(title);
                NodeList subjects = citeseer.getElementsByTagName("dc:subject");
                Element subject = (Element) subjects.item(0);
                String SUBJECT = getText(subject);    
                NodeList descriptions = citeseer.getElementsByTagName("dc:description");
                Element description = (Element) descriptions.item(0);
                String DESCRIPTION = getText(description);                
                //Writing data to class Record
                Record r = new Record(ID, TITLE, allauthors);
                //Write to text files
                writeTo(DESCRIPTION,SUBJECT, i);
                //Extract attributes authorname(s) from xml file
                NodeList authors = citeseer.getElementsByTagName("oai_citeseer:author");               
                for(int l = 0; l < authors.getLength(); l++){
                    Element author = (Element) authors.item(l);
                    names[l] = author.getAttribute("name");
                    allauthors.add(names[l]);
                //Checks if the document was cowritten
                if(authors.getLength() > 0)            
                            for(int z = 0; z < authors.getLength(); z++){
                           //Begin with the second author so not to include the author in the list of coauthors
                                    for(int w = 1; w < authors.getLength(); w++){
                                       //Ensures that the author is not counted as a co-author
                                        if(z != w){
                                            name1 = names[z];
                                            name2 = names[w]; 
                                        //Creates a new instance of Coauthorship
                                      Coauthorship c = new Coauthorship(name1, name2, TITLE);
                                      allCrecords.add(c);
  public void printallCrecords(){
      Iterator iter = allCrecords.iterator();
      while(iter.hasNext())
          System.out.println(iter.next());
  public String getname1() {
      return name1;
   public String getname2() {
      return name2;
    public String getTITLE() {
      return TITLE;
   public void writeTo(String DESCRIPTION, String SUBJECT, int i){
      try{
      //Write to text files 
      String testing = "test.txt";
      File dir = new File ("Description/" + i);
      dir.mkdirs();
      File file = new File(dir, testing);
      FileOutputStream fout = new FileOutputStream(file);
      Writer out = new OutputStreamWriter(fout, "UTF-8");
      out = new BufferedWriter(out);
      out.write(SUBJECT);
      out.write(" ");
      out.write(DESCRIPTION);
      out.flush();
      out.close();     
      catch (IOException e) {
      System.out.println(
       "Due to an IOException, the parser could not check citeseer.xml");
    public String getText(Node node) {
    // We need to retrieve the text from elements, entity
    // references, CDATA sections, and text nodes; but not
    // comments or processing instructions
    int type = node.getNodeType();
    if (type == Node.COMMENT_NODE
     || type == Node.PROCESSING_INSTRUCTION_NODE) {
       return "";
    StringBuffer text = new StringBuffer();
    String value = node.getNodeValue();
    if (value != null) text.append(value);
    if (node.hasChildNodes()) {
      NodeList children = node.getChildNodes();
      for (int i = 0; i < children.getLength(); i++) {
        Node child = children.item(i); 
        text.append(getText(child));
    return text.toString();
  }