Making Sound More Efficient

Question

I got this code to play some audio clips and it works alright. The only issue is that when I call the play method it lags the rest of my game pretty badly. Is there anything in the play method you guys think could be moved to the constructor to make it more efficient?
btw I know I posted this in the sound section already but it had like 17 views there and no responses after like a week on the front page so I decided to bring it here.
package main;
import java.io.*;
import javax.sound.sampled.*;
public class Sound
     private AudioFormat format;
    private byte[] samples;
    private String name;
     public Sound(String filename)
          name=filename;
          try
            AudioInputStream stream =AudioSystem.getAudioInputStream(new File("sounds/"+filename));
            format = stream.getFormat();
            samples = getSamples(stream);
        }catch (Exception e){System.out.println(e);}
     public byte[] getSamples()
        return samples;
    private byte[] getSamples(AudioInputStream audioStream)
        int length=(int)(audioStream.getFrameLength()*format.getFrameSize());
        byte[] samples = new byte[length];
        DataInputStream is = new DataInputStream(audioStream);
        try
            is.readFully(samples);
        }catch (Exception e){System.out.println(e);}
        return samples;
    public void play()
         InputStream stream =new ByteArrayInputStream(getSamples());
        int bufferSize = format.getFrameSize()*Math.round(format.getSampleRate() / 10);
        byte[] buffer = new byte[bufferSize];
        SourceDataLine line;
        try
            DataLine.Info info=new DataLine.Info(SourceDataLine.class, format);
            line=(SourceDataLine)AudioSystem.getLine(info);
            line.open(format, bufferSize);
        }catch (Exception e){System.out.println(e);return;}
        line.start();
        try
            int numBytesRead = 0;
            while (numBytesRead != -1)
                numBytesRead =
                    stream.read(buffer, 0, buffer.length);
                if (numBytesRead != -1)
                   line.write(buffer, 0, numBytesRead);
        }catch (Exception e){System.out.println(e);}
        line.drain();
        line.close();
    public String getName()
         return name;
}

Answer 1

BammRocket wrote:
I got this code to play some audio clips and it works alright. The only issue is that when I call the play method it lags the rest of my game pretty badly. Is there anything in the play method you guys think could be moved to the constructor to make it more efficient?you got this code from chapter 4 of [Developing Games in Java|http://www.brackeen.com/javagamebook/] right?
are you playing the sounds in a different thread?
if not, your program will just freeze until the sound is finished.