Migration Issues--Stored Procedure

Question

Hi,
After migrating sql server procedures into oracle using SQL DEVELOPER tool, I observed following things.
In sql server procedure was having follo. syntax at the end to denote its completion
select "ENDED dbo.s_p_fund_aff_ins_pers_seq_no : " , getdate()
return
This got converted into following,
OPEN cv_2 FOR
SELECT 'ENDED dbo.s_p_fund_aff_ins_pers_seq_no : ',
SYSDATE
FROM DUAL WHERE ROWNUM <= 1;
RETURN;
cv_2 is IN OUT SYS_REFCURSOR.
My question is
1) Is it ok to keep the converted code as it is?
2) Do I need to close the cursor?

Answer 1

It's all to do with scope - when a cursor* goes out of scope, then it will be closed automatically. So, your cursors defined within a procedure will automatically close when you exit that procedure and therefore you don't need to explicitly close them.
Ref cursors have scope outside the procedure / package though, so they must be closed explicitly when the process that's using them no longer needs them. (That's how I think of it, anyway!)
Edited by: Boneist on 07-Apr-2009 11:40
* actually, this applies to other things, such as variables, parameters, etc; once they've gone out of scope, they are trashed as they can't be accessed any more.