Mistake in codes

Question

Hello Experts,
I hav written a procedure to migrate data from one table into another. One issue is arising regarding this part. in my table i am getting the value of lookup fsr in most of the fsr column
begin
                               select a.rep_id into salesrep_id
                               from salesrep a ,
                               retailer_applicants_temp b
                               where UPPER(a.salesperson) like ('%'||UPPER(c1.FSR)||'%')
                               and a.active ='Y';
                               dbms_output.put_line('ERROR:'||c1.FSR);
                                exception
                                when others then
                                 l_msg := 'LOOKUP FSR';
                               raise no_chance;
                              end;I have attached my whole procedure too. I am making any mistakes???
CREATE OR REPLACE procedure LOTTO_BI.migrate_retailers IS
x_val varchar2(1000);
no_chance exception;
l_msg varchar2(1000);  
salesrep_id varchar2(10);
applicant_ID number;                        
begin
   for c1 in( SELECT TRADING_NAME,
                            RETAILER_NUMBER,
                            COMPANY_NAME,
                            ADDRESS_LINE1,
                            DISTRICT,
                            CONTACT_PERSON,
                            OFFICE_PHONE,
                            MOBILE_PHONE,
                            MORALITY_STATUS,
                            NIC_NUMBER,
                            OTHER_CONTACT,
                            BUSINESS_TYPE,
                            BUSINESS_REGISTRATION_NUMBER,
                            RETAILER_CODE,
                            UPLOADED,
                            FSR,
                            CITY,
                            INT_AUDIT,
                            CONTRACT_SIGNAGE,
                            SIGNAGE_AUDIT,
                            ESCONNECT,
                            PASSWORD,
                            TERMINAL,
                            PRINTERL,
                            MODEM,
                            SIMCARD,
                            BANKACCOUNT,
                            MESSAGE,
                            rowid
              FROM Retailer_applicants_temp
              WHERE nvl(uploaded,'N') != 'Y')
                loop--c1
                           declare           
                            l_cm_status varchar2(250);
                            code varchar2(25);
                            l_bu varchar2(50);
                            x char(1);
                             x_cnt number;
                             x_code varchar2(25);
                             x_status varchar2(25);
                             l_status varchar2(25);
                            begin
                              ---VALIDATE RECORD  find values
                              if c1.trading_name is null then
                               l_msg := 'Invalid trading';
                               raise no_chance;
                              end if;
                              if c1.address_line1 is null then
                               l_msg := 'Invalid address';
                               raise no_chance;
                              end if;
                              begin
                                select 'X'
                                into x
                                from lookup_header a ,
                                        lookup_lines b
                                where a.id =b.header_id
                                and a.code ='DISTRICT'
                                and b.code =c1.district;
                                exception
                                when others then
                                 l_msg := 'Invalid district';
                               raise no_chance;
                              end;
                              if c1.CONTACT_PERSON is null then
                                l_msg := 'Invalid Contact Person';
                                raise no_chance;
                              end if;
                               if c1.OFFICE_PHONE is null then
                                l_msg := 'Invalid office number';
                                raise no_chance;
                              end if;
                              if c1.MORALITY_STATUS like 'No CM%' then
                                l_cm_status := 'PENDING';
                              elsif c1.MORALITY_STATUS =  'CM-Pending' then
                                l_cm_status := 'PENDING';
                              elsif c1.morality_status = 'No CM - Was Rejected' then
                               l_cm_status :=  'REJECTED';
                              elsif c1.MORALITY_STATUS like 'CM%' then
                               l_cm_status := 'CM';
                              elsif c1.MORALITY_STATUS in ('Audit - Rejected','Terminated','FP - Minor Offence','Naturalized') then
                               l_cm_status := 'PENDING';
                              else
                               l_msg := 'CM pattern undefined';
                               raise no_chance;
                              end if;
                               if c1.NIC_NUMBER is null then
                               l_msg := 'Invalid NIC Number';
                               raise no_chance;
                              end if;
                              if c1.retailer_number ='200999' then
                                l_bu := 'INDEPENDENT';
                              else
                                l_bu := upper(c1.business_type);
                               end if;
                              if l_bu is null then
                                l_msg := ' Invalid bu';
                                raise no_chance;
                              end if; 
                               if c1.BUSINESS_REGISTRATION_NUMBER is null then
                               l_msg := 'Invalid BRN num';
                               raise no_chance;
                              end if;
                              if c1.FSR is null then
                               l_msg := 'Invalid FSR';
                               raise no_chance;
                              end if;
                              begin
                               select a.rep_id into salesrep_id
                               from salesrep a ,
                               retailer_applicants_temp b
                               where UPPER(a.salesperson) like ('%'||UPPER(c1.FSR)||'%')
                               and a.active ='Y';
                               dbms_output.put_line('ERROR:'||c1.FSR);
                                exception
                                when others then
                                 l_msg := 'LOOKUP FSR';
                               raise no_chance;
                              end;
                             if c1.CITY is null then
                               l_msg := 'Invalid City';
                               raise no_chance;
                              end if;
                              begin
                              x_code := upper(substr(rtrim(ltrim(c1.trading_name)),1,3));
                               Select ltrim(rtrim(to_char(count(*)+1,'0000'))) into x_cnt from retailer_applicants where
                               retailer_code like x_code||'%';
                               x_code := x_code||x_cnt;
                              exception
                              when others then
                              l_msg := 'Unable to gen code';
                              raise no_chance;
                              end;
                              begin
                                      if c1.retailer_number is not null then
                                          select agent_status
                                          into x_status
                                          from lotto_retailers
                                          where retailer_num =c1.retailer_number;
                                         if x_status = 'Terminated' then
                                            l_status := 'REJECTED';
                                        elsif x_status = 'Active' then
                                           l_status := 'APPROVED';
                                         elsif x_status = 'Inactive' then
                                            l_status := 'APPROVED';
                                         else
                                            l_msg := 'Invalid status';
                                            raise no_chance;
                                          end if;
                                    else
                                          l_status :='PENDING';
                                     end if;
                              end;
                              INSERT INTO retailer_applicants
                              (APPLICANT_ID,
                                RETAILER_CODE,
                                TRADING_NAME,
                                RETAILER_NAME,
                                ADDRESS_LINE1,
                                DISTRICT,
                                OFFICE_PHONE,
                                CONTACT_PERSON,
                                MORALITY_STATUS,
                                APPLICATION_STATUS,
                                FSR_ID,
                                RETAILER_NUMBER,
                                COMPANY_NAME,
                                CITY,
                                MOBILE_PHONE,
                                NIC_NUMBER,
                                BUSINESS_REGISTRATION_NUMBER,
                                BUSINESS_STRUCTURE,
                                MORALITY_STATUS_COMMENT,
                                CREATED_BY,
                                CREATED_DATE,
                                INTERNAL_AUDIT,
                                CONTRACT_SIGN,
                                ESCONNECT,
                                "PASSWORD",
                                TERMINAL,
                                PRINTER,
                                MODEM,
                                SIMCARD,
                                BANKACCOUNT)
                                values
                                (lotto_retappl_seq.nextval,
                                 x_code,
                                 c1.trading_name,
                                 c1.trading_name,
                                 c1.address_line1,
                                 c1.district,
                                 c1.office_phone,
                                 c1.contact_person,
                                 l_cm_status,
                                 x_status,
                                 salesrep_id,
                                 c1.retailer_number,
                                 c1.company_name,
                                 c1.city,
                                 c1.mobile_phone,
                                 c1.nic_number,
                                 c1.business_registration_number,
                                 l_bu,
                                 c1.morality_status,
                                 user,
                                 sysdate,
                                 c1.int_audit,
                                 c1.contract_signage,
                                 c1.esconnect,
                                 c1.password,
                                 c1.terminal,
                                 c1.printerl,
                                 c1.modem,
                                 c1.simcard,
                                 c1.bankaccount
                              --UPDATE Temp
                                Update retailer_applicants_temp
                                set uploaded = 'Y' ,
                                     message = 'Uploaded Successfully'
                                where rowid = c1.rowid;
                            exception
                            when no_chance then
                            update Retailer_applicants_temp
                            set message = l_msg,
                                 uploaded = 'E'
                            where rowid =c1.rowid;
                            end;
                end loop;--c1
exception
when others then
dbms_output.put_line('ERROR:'||sqlerrm);
rollback;
end;
/Edited by: Kevin CK on Sep 7, 2010 2:29 PM

Answer 1

I've made some progress. Now i am getting a no data found at the following line
       begin
                                      if c1.retailer_number is not null then
                                          select agent_status
                                          into x_status
                                          from lotto_retailers
                                          where retailer_num =c1.retailer_number;
                                         if x_status = 'Terminated' then
                                            l_status := 'REJECTED';
                                        elsif x_status = 'Active' then
                                           l_status := 'APPROVED';
                                         elsif x_status = 'Inactive' then
                                            l_status := 'APPROVED';
                                         else
                                            l_msg := 'Invalid status';
                                            raise no_chance;
                                          end if;
                                    else
                                          l_status :='PENDING';
                                     end if;
                              endI have checked and i have 3 status only.