Mouse events ignored in custom skin

Question

I created a custom skin for my spinner. While I managed to get the layout this time, it seems that all mouse click events are ignored.
package ch.sahits.game.javafx.control.skin;
import java.io.InputStream;
import javafx.beans.value.ChangeListener;
import javafx.beans.value.ObservableValue;
import javafx.collections.ObservableList;
import javafx.event.EventHandler;
import javafx.geometry.Dimension2D;
import javafx.scene.Group;
import javafx.scene.control.TextField;
import javafx.scene.image.Image;
import javafx.scene.image.ImageView;
import javafx.scene.input.MouseEvent;
import javafx.scene.layout.HBox;
import javafx.scene.layout.VBox;
import ch.sahits.game.javafx.control.OpenPatricianSpinner;
import ch.sahits.game.javafx.control.TextSizingUtility;
import com.sun.javafx.scene.control.skin.SkinBase;
public class OpenPatricianSpinnerSkin extends
        SkinBase<OpenPatricianSpinner, OpenPatricianSpinnerBehavior> {
    private TextSizingUtility sizing = new TextSizingUtility();
    public OpenPatricianSpinnerSkin(final OpenPatricianSpinner spinner) {
        super(spinner, new OpenPatricianSpinnerBehavior(spinner));
        Dimension2D dim4heigth = sizing.calculate(1, spinner.getFont());
        double width = 0;
        for (String word : spinner.getOptions()) {
            Dimension2D dim4width = sizing.calculate(word, spinner.getFont());
            if (dim4width.getWidth() > width) {
                width = dim4width.getWidth();
        Dimension2D dim = new Dimension2D(width, dim4heigth.getHeight());
        String firstValue = "";
        if (!spinner.getOptions().isEmpty()) {
            firstValue = spinner.getOptions().get(0);
            spinner.selectedIndexProperty().set(0);
        HBox hbox = new HBox();
        final TextField textField = new TextField(firstValue);
        textField.getStyleClass().add("openPatricianSpinner");
        textField.setMaxSize(dim.getWidth(), dim.getHeight());
        textField.setEditable(false);
        InputStream is = getClass().getResourceAsStream("SlabUp.png");
        Image img = new Image(is);
        double imgWidth = img.getWidth();
        final ImageView imgViewUp = new ImageView(img);
        is = getClass().getResourceAsStream("SlabDown.png");
        img = new Image(is);
        final ImageView imgViewDown = new ImageView(img);
        double additionalWidth = Math.max(img.getWidth(), imgWidth);
        is = getClass().getResourceAsStream("InputPlank.jpg");
        img = new Image(is,dim.getWidth()+additionalWidth, dim.getHeight(), false, true);
        final ImageView imgViewPlank = new ImageView(img);
        imgViewPlank.onMouseReleasedProperty().addListener(new ChangeListener<EventHandler<? super MouseEvent>>(){
            @Override
            public void changed(ObservableValue<? extends EventHandler<? super MouseEvent>> ov,
                    EventHandler<? super MouseEvent> oldValue,
                    EventHandler<? super MouseEvent> newValue) {
                System.out.println("Clicked on plank");
        Group textGroup = new Group(textField);
        VBox vbox = new VBox();
        vbox.getChildren().addAll(imgViewUp, imgViewDown);
        hbox.getChildren().addAll(textGroup, vbox);
        Group background = new Group(imgViewPlank,hbox);
        imgViewUp.onMouseReleasedProperty().addListener(new ChangeListener<EventHandler<? super MouseEvent>>(){
            @Override
            public void changed(ObservableValue<? extends EventHandler<? super MouseEvent>> ov,
                    EventHandler<? super MouseEvent> oldValue,
                    EventHandler<? super MouseEvent> newValue) {
                ObservableList<String> options = spinner.getOptions();
System.out.println("Clicked on slabUp");
                if (!options.isEmpty()) {
                    if (spinner.getSelectedIndex() > 0) {
                        spinner.selectedIndexProperty().subtract(1);
                        String newDisplayValue = options.get(spinner.getSelectedIndex());
                        textField.setText(newDisplayValue);
                    } else {
                        System.out.println("Selected index <= 0");
                } else {
                    System.out.println("Empty options list");
        }); // end up change listener
        imgViewDown.onMouseReleasedProperty().addListener(new ChangeListener<EventHandler<? super MouseEvent>>(){
            @Override
            public void changed(ObservableValue<? extends EventHandler<? super MouseEvent>> ov,
                    EventHandler<? super MouseEvent> oldValue,
                    EventHandler<? super MouseEvent> newValue) {
                ObservableList<String> options = spinner.getOptions();
System.out.println("Clicked on slabDown");
                if (!options.isEmpty()) {
                    if (spinner.getSelectedIndex() < options.size()) {
                        spinner.selectedIndexProperty().add(1);
                        String newDisplayValue = options.get(spinner.getSelectedIndex());
                        textField.setText(newDisplayValue);
                    } else {
                        System.out.println("Selected index >= options.length");
                } else {
                    System.out.println("Empty options list");
        }); // end up change listener
        onMouseReleasedProperty().addListener(new ChangeListener<EventHandler<? super MouseEvent>>(){
            @Override
            public void changed(ObservableValue<? extends EventHandler<? super MouseEvent>> ov,
                    EventHandler<? super MouseEvent> oldValue,
                    EventHandler<? super MouseEvent> newValue) {
                System.out.println("Clicked on Skin");
        getChildren().add(background);
I would at least expect to see the line 134 printed out. I call this spinner from a simple test application, without any event listeners added there.
Has anyone an idea what might happen here?

Answer 1

Hello, you don't register an event handler, you register a listener on the event handler property. So you don't listen for clicks, you listen for changing the registered click handler. You need to register the handler like this:
imgViewDown.setOnMouseReleased(new EventHandler<MouseEvent>() {
     @Override public void handle(MouseEvent event) {
          // your handler
This way you set the mouse release event handler which will be called on click. This code, by the way, would fire your listeners (the onMouseReleased property has changed).