My select select statement seems not to work...

Question

Hello experts,
I am having trouble with my select statement below. Here is what I need to do:
1. loop at itab it_equz.
2. get single asset number(ANLNR) and description(SHTXT) from table ITOB where EQUNR =_equz-equnr.
3. get single asset number(ANLN1), asset subclass(ANLN2 and subnumber(ORD42 from table ANLA where its asset(anln1) equals to the asset fetched by ITOB. (no. 2 step) and DEAKT eq '00000000'
4. Now, I would get all fields(select single) in table ANLC where ANLN1 equals to asset fetched by ANLA and ANLN2 equals to ANLN2 fetched by ANLA and AFABE eq '01'.
5.endloop.
Now, the problem is that I can't seem to get the right values in table ANLC. Now, my boss said that the values that I must get in ANLC must not be deactivated. So I did that by getting the required fields(no 3 step) in table ANLA where its DEAKT is equal to '00000000'.
Now, my select statement for ANLC seems not to work properly since I have the proper where conditions. Anyway, below is my select statement that I did:
LOOP AT it_equz.  "no 1 step
SELECT SINGLE anlnr shtxt FROM itob   "no 2 step
          INTO (it_itob-anlnr, it_itob-shtxt)
          WHERE equnr = it_equz_dum1-hequi.
MOVE it_itob-anlnr TO it_finaltab-asset_dum.
            MOVE it_itob-anlnr TO it_finaltab-asset.
            MOVE it_itob-shtxt TO it_finaltab-description.
SELECT SINGLE bukrs anln1 anln2 ord42   "no 3 step
            FROM anla                                  
            INTO (it_anla-bukrs, it_anla-anln1, it_anla-anln2,
                  it_anla-ord42)
            WHERE anln1 = it_finaltab-asset
              AND bukrs IN r_iwerk
              AND deakt = '00000000'.
MOVE it_anla-ord42 TO it_finaltab-asset_sub.
              WRITE it_finaltab-asset TO v_asset.
              CONCATENATE v_asset '-' it_anla-anln2
              INTO it_finaltab-asset_subnum.
SELECT SINGLE bukrs anln1 gjahr afabe knafa kansw  "no 4 step
                          answl kaafa nafal aafav aafag
                          nafap aafap nafav nafag FROM anlc
                      INTO (it_anlc-bukrs, it_anlc-anln1, it_anlc-gjahr,
                            it_anlc-afabe, it_anlc-knafa, it_anlc-kansw,
                           it_anlc-answl, it_anlc-kaafa, it_anlc-nafal,
                           it_anlc-aafav, it_anlc-aafag, it_anlc-nafap,
                           it_anlc-aafap, it_anlc-nafav, it_anlc-nafag)
                        WHERE anln1 EQ it_finaltab-asset
                          AND anln2 EQ it_anla-anln2
                          AND bukrs EQ it_anla-bukrs
                          AND afabe EQ '01'.
it_finaltab-accq_cost = it_anlc-kansw + it_anlc-answl.
            IF p_posdep = 'X'.
              it_finaltab-acc_dep = it_anlc-knafa +
                                    it_anlc-nafav +
                                    it_anlc-nafag +
                                    it_anlc-kaafa +
                                    it_anlc-aafav +
                                    it_anlc-aafag.
            ELSE.
              it_finaltab-acc_dep = it_anlc-knafa +
                                    it_anlc-nafav +
                                    it_anlc-nafag +
                                    it_anlc-kaafa +
                                    it_anlc-aafav +
                                    it_anlc-aafag +
                                    it_anlc-nafap +
                                    it_anlc-aafap.
            ENDIF.
APPEND it_finaltab. CLEAR it_finaltab.
          APPEND it_equz_dum2. CLEAR it_equz_dum2.
          CLEAR it_itob. CLEAR it_anla. CLEAR it_anlc.
endloop.

Answer 1

Hi,
  Please avoid selection in loop. it will lead to major performance issue.
avoid move statements ; instead use assignment.
1st :- select the entire data into internal table
eg:-
SELECT anlnr shtxt FROM itob
INTO table it_itob
for all entries in it_equz
WHERE equnr = it_equz-hequi.
1st select
2nd select.
2nd :- now loop on ur internal table to get the desired result.
it is good to work with internal table rather than select statements in loop.
Regards