Need Help to see why the performance is not good

Question

Hi,
We have an application that all process are developed in PL/SQL on Oracle 9i Database :
Oracle9i Enterprise Edition Release 9.2.0.6.0 - 64bit Production
PL/SQL Release 9.2.0.6.0 - Production
Why I have created this package. the application is a production management on chemical industries. I need to sometimes trace the Manufacturing order execution to eventually answer some incoherent data. If I analyze directly the data in the Table is not always responding because the origin of problem can be provide of some execution that perform some calculation.
In the procedure or function a use my package PAC_LOG_ERROR.PUT_LINE(xxxxxx) to save the information. This command save the information in the memory before. At the end of the procedure or function a perform the insert with the COMMIT calling PAC_LOG_ERROR.LOGS or PAC_LOG_ERROR.ERRORS on the catch exception.
This package is always call. On each routines performed I execute it. In the trace log of the database we have see a problem we the procedure GET_PROC_NAME in the package. We have identify that is called more that 800x and increase the performance. Who increase is this select command :
    SELECT * INTO SOURCE_TEXT
    FROM (SELECT TEXT FROM all_source
        WHERE OWNER = SOURCE_OWNER AND
              NAME=SOURCE_NAME AND
              TYPE IN ('PROCEDURE','FUNCTION','PACKAGE BODY') AND
              LINE <= SOURCE_LINE AND SUBSTR(TRIM(TEXT),1,9) IN ('PROCEDURE','FUNCTION ')
        ORDER BY LINE DESC)
    WHERE ROWNUM = 1;I use it to get the procedure or function name where my log proc is called. I now that I can pass in parameters, but I have think to use an automatic method, that can help to not have some problem with others developer team to make a copy/past and not update the parameters. Because the Log info is read by the Help Desk and if we have an error on the information, it not a good help.
COULD YOU PLEASE HELP ME TO OPTIMIZE OR SAID THE BETTER METHOD TO DO IT ?
Here my package :
create or replace
PACKAGE PAC_LOG_ERROR AS
-- Name         : pac_log_error.sql
-- Author       : Calà Salvatore - 02 July 2010
-- Description  : Basic Error and Log management.
-- Usage notes  : To active the Log management execute this statement
--                UPDATE PARAM_TECHNIC SET PRM_VALUE = 'Y' WHERE PRM_TYPE = 'TRC_LOG';
--                COMMIT;
--                To set the period in day before to delete tracability
--                UPDATE PARAM_TECHNIC SET PRM_VALUE = 60 WHERE PRM_TYPE = 'DEL_TRC_LOG';
--                COMMIT;
--                To set the number in day where the ERROR is save before deleted
--                UPDATE PARAM_TECHNIC SET PRM_VALUE = 60 WHERE PRM_TYPE = 'DEL_TRC_LOG';
--                COMMIT;
-- Requirements : Packages PAC_PUBLIC and OWA_UTIL
-- Revision History
-- --------+---------------+-------------+--------------------------------------
-- Version |    Author     |  Date       | Comment
-- --------+---------------+-------------+--------------------------------------
-- 1.0.0   | S. Calà       | 02-Jul-2010 | Initial Version
-- --------+---------------+-------------+--------------------------------------
--         |               |             |
-- --------+---------------+-------------+--------------------------------------
  PROCEDURE INITIALIZE;
  PROCEDURE CLEAN;
  PROCEDURE RESETS(IN_SOURCE IN VARCHAR2 DEFAULT NULL);
  PROCEDURE PUT_LINE(TXT IN VARCHAR2);
  PROCEDURE ERRORS(REF_TYPE IN VARCHAR2 DEFAULT 'SITE', REF_VALUE IN VARCHAR2 DEFAULT '99', ERR_CODE IN NUMBER DEFAULT SQLCODE, ERR_MSG IN VARCHAR2 DEFAULT SQLERRM);
  PROCEDURE LOGS(REF_TYPE IN VARCHAR2 DEFAULT 'SITE', REF_VALUE IN VARCHAR2 DEFAULT '99');
END PAC_LOG_ERROR;
create or replace
PACKAGE BODY PAC_LOG_ERROR
AS
  /* Private Constant */
  CR    CONSTANT CHAR(1)  := CHR(13);  -- Retour chariot
  LF    CONSTANT CHAR(1)  := CHR(10);  -- Saut de ligne
  CR_LF CONSTANT CHAR(2)  := LF || CR; --Saut de ligne et retour chariot
  TAB   CONSTANT PLS_INTEGER := 50;
  sDelay   CONSTANT PLS_INTEGER := 30;
  /* Private Record */
  TYPE REC_LOG IS RECORD(
    ERR_DATE TIMESTAMP WITH TIME ZONE DEFAULT CURRENT_TIMESTAMP,
    ERR_TXT  VARCHAR2(4000)
  /* Private Type Table */
  TYPE TAB_VALUE IS TABLE OF REC_LOG INDEX BY PLS_INTEGER;
  TYPE TAB_POINTER IS TABLE OF TAB_VALUE INDEX BY VARCHAR2(80);
  /* Private Variables Structures */
  LOG_TRC PARAM_TECHNIC.PRM_VALUE%TYPE;
  LIST_PARAM TAB_POINTER;
  /* Private Programs */
  FUNCTION GET_PROC_NAME( SOURCE_OWNER IN all_source.OWNER%TYPE
                         ,SOURCE_NAME  IN all_source.NAME%TYPE
                         ,SOURCE_LINE  IN all_source.LINE%TYPE) RETURN VARCHAR2
  AS
    SOURCE_TEXT  all_source.TEXT%TYPE;
    TYPE RECORD_TEXT IS TABLE OF all_source.TEXT%TYPE;
    RETURN_TEXT     RECORD_TEXT;
  BEGIN
    SELECT * INTO SOURCE_TEXT
    FROM (SELECT TEXT FROM all_source
        WHERE OWNER = SOURCE_OWNER AND
              NAME=SOURCE_NAME AND
              TYPE IN ('PROCEDURE','FUNCTION','PACKAGE BODY') AND
              LINE <= SOURCE_LINE AND SUBSTR(TRIM(TEXT),1,9) IN ('PROCEDURE','FUNCTION ')
        ORDER BY LINE DESC)
    WHERE ROWNUM = 1;
    IF SOURCE_TEXT IS NOT NULL OR  SOURCE_TEXT != '' THEN
      SOURCE_TEXT := TRIM(SUBSTR(SOURCE_TEXT,1,INSTR(SOURCE_TEXT,'(')-1));     
      SOURCE_TEXT := LTRIM(LTRIM(TRIM(SOURCE_TEXT),'PROCEDURE'),'FUNCTION');
      SOURCE_TEXT := SOURCE_NAME||'.'|| TRIM(SOURCE_TEXT);
    ELSE
      SOURCE_TEXT := 'ANONYMOUS BLOCK';
    END IF;
    RETURN SOURCE_TEXT;
  END GET_PROC_NAME;
  PROCEDURE SELECT_MASTER(REF_TYPE IN VARCHAR2, PARAM_VALUE IN VARCHAR2, SITE OUT VARCHAR2, REF_MASTER OUT VARCHAR2)
  AS
  BEGIN
      REF_MASTER := '';
      SITE := '99';
      CASE UPPER(REF_TYPE)
        WHEN 'PO' THEN -- Process Order
          SELECT SITE_CODE INTO SITE FROM PO_PROCESS_ORDER WHERE PO_NUMBER = PARAM_VALUE;
        WHEN 'SO' THEN -- Shop Order
          SELECT P.SITE_CODE,P.PO_NUMBER INTO SITE,REF_MASTER FROM SO_SHOP_ORDER S
          INNER JOIN PO_PROCESS_ORDER P ON P.PO_NUMBER = S.PO_NUMBER
          WHERE S.NUMOF = PARAM_VALUE;
        WHEN 'SM' THEN -- Submixing
          SELECT SITE_CODE,NUMOF INTO SITE,REF_MASTER FROM SO_SUBMIXING WHERE IDSM = PARAM_VALUE;
        WHEN 'IDSM' THEN -- Submixing
          SELECT SITE_CODE,NUMOF INTO SITE,REF_MASTER FROM SO_SUBMIXING WHERE IDSM = PARAM_VALUE;
        WHEN 'PR' THEN -- Pourring
          SELECT B.SITE_CODE,P.NUMOF INTO SITE,REF_MASTER FROM SO_POURING P
          INNER JOIN SO_SUBMIXING B ON B.IDSM=P.IDSM
          WHERE P.IDSM = PARAM_VALUE;
        WHEN 'NUMSMP' THEN -- Pourring
          SELECT SITE_CODE,NUMOF INTO SITE,REF_MASTER FROM SAMPLE WHERE NUMSMP = TO_NUMBER(PARAM_VALUE);
--        WHEN 'MSG' THEN -- Messages
--          SELECT SITE_CODE,PO_NUMBER INTO SITE,REF_MASTER FROM CMS_INTERFACE.MAP_ITF_PO WHERE MSG_ID = PARAM_VALUE;
        ELSE
          SITE := sys_context('usr_context', 'site_attribute');
      END CASE;
  EXCEPTION
    WHEN OTHERS THEN
      REF_MASTER := '';
      SITE := sys_context('usr_context', 'site_attribute');
  END SELECT_MASTER;
  PROCEDURE ADD_LIST_PROC
  AS
  PRAGMA AUTONOMOUS_TRANSACTION;
  BEGIN
    MERGE INTO LOG_PARAM A
    USING (SELECT OWNER, TYPE
                 ,NAME PROC
                 , CASE NAME WHEN SUBNAME THEN NULL
                             ELSE SUBNAME
                   END SUBPROC
           FROM (
              SELECT owner,TYPE,UPPER(NAME) NAME,UPPER(trim(substr(substr(trim(text),1,instr(trim(text),'(')-1),instr(substr(trim(text),1,instr(trim(text),'(')-1),' ')))) SUBNAME
                     FROM ALL_SOURCE where owner in ('CMS_ADM','CMS_INTERFACE')
                                         and type in ('FUNCTION','PROCEDURE','PACKAGE BODY')
                                         and (instr(substr(trim(text),1,instr(trim(upper(text)),'(')-1),'FUNCTION') = 1 or instr(substr(trim(text),1,instr(trim(upper(text)),'(')-1),'PROCEDURE')=1)
           )-- ORDER BY OWNER,PROC,SUBPROC NULLS FIRST
    ) B
    ON (A.OWNER = B.OWNER AND A.TYPE = B.TYPE AND A.PROC=B.PROC AND NVL(A.SUBPROC,' ') = NVL(B.SUBPROC,' '))
    WHEN NOT MATCHED THEN
      INSERT (OWNER,TYPE,PROC,SUBPROC) VALUES (B.OWNER,B.TYPE,B.PROC,B.SUBPROC)
    WHEN MATCHED THEN
      UPDATE SET ACTIVE = ACTIVE;
    DELETE LOG_PARAM A
    WHERE NOT EXISTS (SELECT OWNER, TYPE
                 ,NAME PROC
                 , CASE NAME WHEN SUBNAME THEN NULL
                             ELSE SUBNAME
                   END SUBPROC
           FROM (
              SELECT owner,TYPE,NAME,upper(trim(substr(substr(trim(text),1,instr(trim(text),'(')-1),instr(substr(trim(text),1,instr(trim(text),'(')-1),' ')))) SUBNAME
                     FROM ALL_SOURCE where owner in ('CMS_ADM','CMS_INTERFACE')
                                         and type in ('FUNCTION','PROCEDURE','PACKAGE BODY')
                                         and (instr(substr(trim(text),1,instr(trim(text),'(')-1),'FUNCTION') = 1 or instr(substr(trim(text),1,instr(trim(text),'(')-1),'PROCEDURE')=1)
           ) WHERE A.OWNER = OWNER AND A.TYPE = TYPE AND A.PROC=PROC AND NVL(A.SUBPROC,' ') = NVL(SUBPROC,' '));
    COMMIT;
  EXCEPTION
    WHEN OTHERS THEN
      NULL;
  END ADD_LIST_PROC;
  PROCEDURE INITIALIZE
  AS
  BEGIN
    LIST_PARAM.DELETE;
    CLEAN;
--    ADD_LIST_PROC;
  EXCEPTION
    WHEN OTHERS THEN
      NULL;
  END INITIALIZE;
  PROCEDURE CLEAN
  AS
    PRAGMA AUTONOMOUS_TRANSACTION;
    dtTrcLog DATE;
    dtTrcErr DATE;
  BEGIN
    BEGIN
      SELECT dbdate-NUMTODSINTERVAL(to_number(PRM_VALUE),'DAY') INTO dtTrcLog
      FROM PARAM_TECHNIC WHERE PRM_TYPE = 'DEL_TRC_LOG';
    EXCEPTION
      WHEN OTHERS THEN
        dtTrcLog := dbdate -NUMTODSINTERVAL(sDelay,'DAY');
    END;
    BEGIN
      SELECT dbdate-NUMTODSINTERVAL(to_number(PRM_VALUE),'DAY') INTO dtTrcErr
      FROM PARAM_TECHNIC WHERE PRM_TYPE = 'DEL_TRC_ERR';
    EXCEPTION
      WHEN OTHERS THEN
        dtTrcErr := dbdate -NUMTODSINTERVAL(sDelay,'DAY');
      END;
    DELETE FROM ERROR_LOG WHERE ERR_TYPE ='LOG' AND ERR_DATE < dtTrcLog;
    DELETE FROM ERROR_LOG WHERE ERR_TYPE ='ERROR' AND ERR_DATE < dtTrcErr;
    COMMIT;
  EXCEPTION
    WHEN OTHERS THEN
      NULL; -- Do nothing if error occurs and catch exception
  END CLEAN;
  PROCEDURE RESETS(IN_SOURCE IN VARCHAR2 DEFAULT NULL)
  AS
    SOURCE_OWNER all_source.OWNER%TYPE;
    SOURCE_NAME      all_source.NAME%TYPE;
    SOURCE_LINE      all_source.LINE%TYPE;
    SOURCE_TEXT  all_source.TEXT%TYPE;
    SOURCE_PROC  VARCHAR2(32727);
  BEGIN
    OWA_UTIL.WHO_CALLED_ME(owner    => SOURCE_OWNER,
                           name     => SOURCE_NAME,
                           lineno   => SOURCE_LINE,
                           caller_t => SOURCE_TEXT);
    IF SOURCE_PROC IS NULL THEN
      SOURCE_PROC := SUBSTR(GET_PROC_NAME(SOURCE_OWNER,SOURCE_NAME,SOURCE_LINE),1,125);
    ELSE
      SOURCE_PROC := IN_SOURCE;
    END IF;
    LIST_PARAM.DELETE(SOURCE_PROC);
  EXCEPTION
    WHEN OTHERS THEN
      NULL;
  END RESETS;
  PROCEDURE PUT_LINE(TXT IN VARCHAR2)
  AS
    PRAGMA AUTONOMOUS_TRANSACTION;
    SOURCE_OWNER     all_source.OWNER%TYPE;
    SOURCE_NAME     all_source.NAME%TYPE;
    SOURCE_LINE     all_source.LINE%TYPE;
    SOURCE_TEXT all_source.TEXT%TYPE;
    SOURCE_PROC VARCHAR2(128); 
  BEGIN
    IF TXT IS NULL OR TXT = '' THEN
      RETURN;
    END IF;
    OWA_UTIL.WHO_CALLED_ME(owner    => SOURCE_OWNER,
                           name     => SOURCE_NAME,
                           lineno   => SOURCE_LINE,
                           caller_t => SOURCE_TEXT);
    SOURCE_PROC := GET_PROC_NAME(SOURCE_OWNER,SOURCE_NAME,SOURCE_LINE);
    IF LIST_PARAM.EXISTS(SOURCE_PROC) THEN
      LIST_PARAM(SOURCE_PROC)(LIST_PARAM(SOURCE_PROC).COUNT+1).ERR_TXT := TXT;
    ELSE 
      LIST_PARAM(SOURCE_PROC)(1).ERR_TXT := TXT;
    END IF;
  EXCEPTION
    WHEN OTHERS THEN
      NULL;   
  END PUT_LINE;
  PROCEDURE LOGS(REF_TYPE IN VARCHAR2 DEFAULT 'SITE', REF_VALUE IN VARCHAR2 DEFAULT '99')
  AS
    PRAGMA AUTONOMOUS_TRANSACTION;
    MASTER_VALUE ERROR_LOG.ERR_MASTER%TYPE;
    SITE PARAMTAB.SITE_CODE%TYPE;
    SOURCE_OWNER     all_source.OWNER%TYPE;
    SOURCE_NAME     all_source.NAME%TYPE;
    SOURCE_LINE     all_source.LINE%TYPE;
    SOURCE_TEXT all_source.TEXT%TYPE;
    SOURCE_PROC VARCHAR2(128);
    ERR_KEY NUMBER;
  BEGIN
--    NULL;
    OWA_UTIL.WHO_CALLED_ME(owner    => SOURCE_OWNER,
                           name     => SOURCE_NAME,
                           lineno   => SOURCE_LINE,
                           caller_t => SOURCE_TEXT);
    SOURCE_PROC := SUBSTR(GET_PROC_NAME(SOURCE_OWNER,SOURCE_NAME,SOURCE_LINE),1,128);
    LIST_PARAM.DELETE(SOURCE_PROC);
--    SELECT NVL(MAX(ACTIVE),'N') INTO LOG_TRC FROM LOG_PARAM WHERE TRIM(UPPER((PROC||'.'||SUBPROC))) = TRIM(UPPER(SOURCE_PROC))
--                                      AND OWNER =SOURCE_OWNER AND TYPE = SOURCE_TEXT ;
--    IF LOG_TRC = 'N' THEN
--      LIST_PARAM.DELETE(SOURCE_PROC);
--      RETURN;
--    END IF;   
--    SELECT_MASTER(REF_TYPE => UPPER(REF_TYPE), PARAM_VALUE => REF_VALUE, SITE => SITE, REF_MASTER => MASTER_VALUE);
--    ERR_KEY := TO_CHAR(LOCALTIMESTAMP,'YYYYMMDDHH24MISSFF6');
--    FOR AIX IN 1..LIST_PARAM(SOURCE_PROC).COUNT LOOP
--      INSERT INTO ERROR_LOG (ERR_KEY, ERR_SITE,ERR_SLAVE  ,ERR_MASTER  ,ERR_TYPE ,ERR_PROC,ERR_DATE,ERR_TXT)
--      VALUES (ERR_KEY,SITE,REF_VALUE,MASTER_VALUE,'LOG',SOURCE_PROC,LIST_PARAM(SOURCE_PROC)(AIX).ERR_DATE ,LIST_PARAM(SOURCE_PROC)(AIX).ERR_TXT);
--    END LOOP; 
--    UPDATE SESSION_CONTEXT SET SCX_ERR_KEY = ERR_KEY WHERE SCX_ID = SYS_CONTEXT('USERENV','SESSIONID');
--    LIST_PARAM.DELETE(SOURCE_PROC);
--    COMMIT;
  EXCEPTION
    WHEN OTHERS THEN
      LIST_PARAM.DELETE(SOURCE_PROC);
  END LOGS;
  PROCEDURE ERRORS(REF_TYPE IN VARCHAR2 DEFAULT 'SITE', REF_VALUE IN VARCHAR2 DEFAULT '99', ERR_CODE IN NUMBER DEFAULT SQLCODE, ERR_MSG IN VARCHAR2 DEFAULT SQLERRM)
  AS
    PRAGMA AUTONOMOUS_TRANSACTION;
    MASTER_VALUE ERROR_LOG.ERR_MASTER%TYPE;
    SITE         PARAMTAB.SITE_CODE%TYPE;
    SOURCE_OWNER all_source.OWNER%TYPE;
    SOURCE_NAME      all_source.NAME%TYPE;
    SOURCE_LINE      all_source.LINE%TYPE;
    SOURCE_TEXT  all_source.TEXT%TYPE;
    SOURCE_PROC  VARCHAR2(4000);
    ERR_KEY NUMBER := TO_CHAR(LOCALTIMESTAMP,'YYYYMMDDHH24MISSFF6');
  BEGIN
    OWA_UTIL.WHO_CALLED_ME(owner    => SOURCE_OWNER,
                           name     => SOURCE_NAME,
                           lineno   => SOURCE_LINE,
                           caller_t => SOURCE_TEXT);
    SOURCE_PROC := SUBSTR(GET_PROC_NAME(SOURCE_OWNER,SOURCE_NAME,SOURCE_LINE),1,125);
    SELECT_MASTER(REF_TYPE => UPPER(REF_TYPE), PARAM_VALUE => REF_VALUE, SITE => SITE, REF_MASTER => MASTER_VALUE);
   IF LIST_PARAM.EXISTS(SOURCE_PROC) THEN
      FOR AIX IN 1..LIST_PARAM(SOURCE_PROC).COUNT LOOP
        INSERT INTO ERROR_LOG (ERR_KEY,ERR_SITE,ERR_SLAVE,ERR_MASTER,ERR_PROC,ERR_DATE,ERR_TXT,ERR_CODE,ERR_MSG)
        VALUES (ERR_KEY,SITE,REF_VALUE,MASTER_VALUE,SOURCE_PROC,LIST_PARAM(SOURCE_PROC)(AIX).ERR_DATE, LIST_PARAM(SOURCE_PROC)(AIX).ERR_TXT,ERR_CODE,ERR_MSG);
      END LOOP; 
     LIST_PARAM.DELETE(SOURCE_PROC);
    ELSE
      INSERT INTO ERROR_LOG (ERR_KEY,ERR_SITE,ERR_SLAVE,ERR_MASTER,ERR_PROC,ERR_DATE,ERR_TXT,ERR_CODE,ERR_MSG)
      VALUES (ERR_KEY,SITE,REF_VALUE,MASTER_VALUE,SOURCE_PROC,CURRENT_TIMESTAMP,'Error info',ERR_CODE,ERR_MSG);
    END IF;
    UPDATE SESSION_CONTEXT SET SCX_ERR_KEY = ERR_KEY WHERE SCX_ID = sys_context('usr_context', 'session_id');
    COMMIT;
  EXCEPTION
    WHEN OTHERS THEN
      LIST_PARAM.DELETE(SOURCE_PROC);
  END ERRORS;
END PAC_LOG_ERROR;

Answer 1

This package is always call. On each routines performed I execute it. In the trace log of the database we have see a problem we the procedure GET_PROC_NAME in the package. We have identify that is called more that 800x and increase the performance. Who increase is this select command :
    SELECT * INTO SOURCE_TEXT
    FROM (SELECT TEXT FROM all_source
        WHERE OWNER = SOURCE_OWNER AND
              NAME=SOURCE_NAME AND
              TYPE IN ('PROCEDURE','FUNCTION','PACKAGE BODY') AND
              LINE <= SOURCE_LINE AND SUBSTR(TRIM(TEXT),1,9) IN ('PROCEDURE','FUNCTION ')
        ORDER BY LINE DESC)
    WHERE ROWNUM = 1;Complex SQL like inline views and views of views can overwhelm the cost-based optimizer resulting in bad execution plans. Start with getting an execution plan of your problem query to see if it is inefficient - look for full table scans in particular. You might bet better performance by eliminating the IN and merging the results of 3 queries with a UNION.