No data found error on Pl/SQL

Question

Hi All,
I write Pl/SQL that have package(procedure) to call some function like this :
Main Procedure
Call Function SubA
Function SubA
BEGIN
begin
select sale_by
into v_saleby
from myTable
where....
end;
return(nvl(v_saleby,0));
END;
so, I execute this package(procedure) and no record return and error message
show no data found ,I think it caused by Function SubA that select clause return
no record , How can I solve this problem???
Then I try to modify again to trap error with exception in the code shown below
;Function SubB
Function SubB
BEGIN
begin
select sale_by
into v_saleby
from myTable
where....
end;
return(nvl(v_saleby,0));
EXCEPTION
WHEN No_DATA_FOUND
THEN v_saleby := 0;
return(nvl(v_saleby,0));
END;
What position of exception should I place to?
Thank you..
Mcka

Answer 1

just wondering why you said your method is not working. it also works...
SQL> SELECT * FROM emp;
     EMPNO ENAME      JOB              MGR HIREDATE         SAL       COMM     DEPTNO
      7369 SMITH      CLERK           7902 17-DEC-80        800                    20
      7499 ALLEN      SALESMAN        7698 20-FEB-81       1600        300         30
      7521 WARD       SALESMAN        7698 22-FEB-81       1250        500         30
      7566 JONES      MANAGER         7839 02-APR-81       2975                    20
      7654 MARTIN     SALESMAN        7698 28-SEP-81       1250       1400         30
      7698 BLAKE      MANAGER         7839 01-MAY-81       2850                    30
      7782 CLARK      MANAGER         7839 09-JUN-81       2450                    10
      7788 SCOTT      ANALYST         7566 19-APR-87       3000                    20
      7839 KING       PRESIDENT            17-NOV-81       5000                    10
      7844 TURNER     SALESMAN        7698 08-SEP-81       1500          0         30
      7876 ADAMS      CLERK           7788 23-MAY-87       1100                    20
     EMPNO ENAME      JOB              MGR HIREDATE         SAL       COMM     DEPTNO
      7900 JAMES      CLERK           7698 03-DEC-81        950                    30
      7902 FORD       ANALYST         7566 03-DEC-81       3000                    20
      7934 MILLER     CLERK           7782 23-JAN-82       1300                    10
      7858 Tonny
15 rows selected.
  1  CREATE FUNCTION fn_emp(pEmpNo NUMBER)
  2  RETURN NUMBER IS
  3   v_sal NUMBER;
  4  BEGIN
  5   SELECT sal INTO v_sal FROM emp WHERE empno = pEmpNo;
  6   RETURN v_sal;
  7  EXCEPTION
  8   WHEN NO_DATA_FOUND THEN
  9    RETURN 0;
10* END;
SQL> /
Function created.
  1  DECLARE
  2   l_retval NUMBER;
  3  BEGIN
  4   l_retval := fn_emp(7782);
  5   DBMS_OUTPUT.PUT_LINE(l_retval);
  6* END;
SQL> /
2450
PL/SQL procedure successfully completed.
  1  DECLARE
  2   l_retval NUMBER;
  3  BEGIN
  4   l_retval := fn_emp(1000);
  5   DBMS_OUTPUT.PUT_LINE(l_retval);
  6* END;
SQL> /
0
PL/SQL procedure successfully completed.