ON INSERT stored proc's for sequence handling

Hi all,
We're piping records into our DBase from a java front app. (code spew below). Apparently it is better to handle the sequences on the DBase (or back) side, as opposed to the way we've done it, on the app (front) side.
Can anyone point me towards a suitable ON INSERT stored procedure to handle this?
Thanks for any help.
public void createDish (String dishName, String dishDescription,
double cost, char standard, char active, char vege/*boolean standard, boolean active, boolean vege*/)
throws SQLException, ClassNotFoundException {
String newName = checkString(dishName);
String newDesc = checkString(dishDescription);
query = conn.createStatement();
query.executeUpdate("INSERT INTO Dishes (Dish_ID, Dish_Name, Dish_Description,"
+ " Dish_Cost, Standard, Active, Vegetarian) VALUES (dishes_id_seq.nextval, '" + newName
+ "', '" + newDesc + "', '" + cost + "', '" + standard + "', '"
+ active + "', '" + vege + "')");
yeah, yeah...I know there's no try..catch, I'm on it.
:D

Yes you should not concatenate the variable values in the SQL string like that. It does not scale and can lead to security problems from SQL Injection, I think as Jim J said you need a prepared statement. Your SQL string should look something like
"INSERT INTO Dishes (Dish_ID, Dish_Name, Dish_Description,"
+ " Dish_Cost, Standard, Active, Vegetarian) VALUES (?, ?, ?, ?, ?, ?, ?);"

Similar Messages

Should I do this with Java Code or Stored Procs ? (for best performance)

Hi All,
I need to decide where should I implement my business logic, in Java code or Stored procs.
Here is the requirement :
- One Order has 70 products (Order_Table )
- Can be duplicate products, so I have to do summarize / grouping by product
- For every product, I have to check, if it is entitled for a Bonus product, then I have to Insert one to Bonus_Table.
- This is done when/after the transaction is SAVED (COMMIT)
The question is, which one has better PERFORMANCE :
(1) Create a rowsetIterator on the Order details (70 products) and call a stored procedure to do the logic for every single product (so that the Insert to Bonus_Table done in stored proc). means the stored proc will be called 70 times.
OR
(2) After the transaction is COMMITted, call the stored procs ONCE to do the logic for all the products at once.
OR
(3) I do all the logic with Java Code within ADF
Given the requirement above, which approach is most efficient / best performance ?
Thank you very much,
xtanto

Problem with this is that you ask 100 people and you probably get 100 different answers. ;o)
Many would say that you push as much business logic into the database with your data; others might say you only put data in your database and your business logic is kept on the application server.
In reality your would probably have a mix of both and your decision would probably be influenced by your own background ...
Can't be more precise than that.
Grant

How to compare the table, constraint, stored proc, view between 2 schema ?

Hi All,
We have two schema : app_test & app_prod :
app_test is where user run acceptance test, and where we make correction etc
app_prod is where user prepare data for going live/production.
Now we need to make sure that :
table structure
stored proc
view
function
sequence
constraint ...
Is the SAME between the two schema : Is there any script that can automate the process ?
Thank you very much,
xtanto

You may use TOAD, OEM, and use "ALL_" views to compare.
And also, take a look into the duplicate thread on this forums.
How to compare two oracle database schemas
You can also check in the google for any free tools for this !!
Regards,
Sabdar Syed.

How to declare a cursor with stored proc?

Hi All,
Can we declare a cursor with stored proc?
For Example -
CREATE PROCEDURE DDL_proc() LANGUAGE SQLSCRIPT AS
    CURSOR c_cursor1 (v_isbn VARCHAR(20)) FOR CALL SYS.GET_OBJECT_DEFINITION(<SCHEMA_NAME>, <TABLE_NAME>).;
     BEGIN
          FOR cur_row as c_cursor1 DO
          END FOR;
     END;
Could you please have a look on the same?
Thank you,
Vijeesh

Oracle PL/SQL also has a select into statement which is described in the same manual the link takes you to part of.
select column_list
into variable_list
from table(s)
where conditions
The PL/SQL Users Guide is something you are going to want to have gone over cover to cover before you start converting because so that you make the best choices for how to rewrite the code: select into, explicit cursor, implicit cursor, for loop, simple loop, while loop, collections,bulk load, etc ....
HTH -- Mark D Powell --

** How to use TO_DATE function in Stored Proc. for JDBC in ABAP-XSL mapping

Hi friends,
I use ABAP-XSL mapping to insert records in Oracle table. My Sender is File and receiver is JDBC. We use Oracle 10g database. All fields in table are VARCHAR2 except one field; this is having type 'DATE'.
I use Stored procedure to update the records in table. I have converted my string into date using the Oracle TO_DATE function. But, when I use this format, it throws an error in the Receiver CC. (But, the message is processed successfully in SXMB_MONI).
The input format I formed like below:
<X_EMP_START_DT hasQuot="No" isInput="1" type="DATE">
Value in Payload is like below.
<X_EMP_START_DT hasQuot="No" isInput="1" type="DATE">TO_DATE('18-11-1991','DD-MM-YYYY')</X_EMP_START_DT>
Error in CC comes as below:
Error processing request in sax parser: Error when executing statement for table/stored proc. 'SP_EMP_DETAILS' (structure 'STATEMENT'): java.lang.NumberFormatException: For input string: "TO_DATE('18"
Friends, I have tried, but unable to find the correct solution to insert.
Kindly help me to solve this issue.
Kind Regards,
Jegathees P.
(But, the same is working fine if we use direct method in ABAP-XSL ie. not thru Stored Procedure)

Hi Sinha,
Thanks for your reply.
I used the syntax
<xsl:call-template name="date:format-date">
<xsl:with-param name="date-time" select="string" />
<xsl:with-param name="pattern" select="string" />
</xsl:call-template>
in my Abap XSL. But, its not working correctly. The problem is 'href' function to import "date.xsl" in my XSLT is not able to do that. The system throws an error. Moreover, it is not able to write the command 'extension-element-prefixes' in my <xsl:stylesheet namespace>
May be I am not able to understand how to use this.
Anyway, I solved this problem by handling date conversion inside Oracle Stored Procedure. Now, its working fine.
Thank you.

Error when executing statement for table/stored proc

Hi All,
      I am getting this error when executing IDOC to JDBC (Stored Procedure) Scenario.
     In my stored procedure I have three insert statements to insert rows in to 3 tables.
    This stored procedure is working fine for two insert statements i.e,
         For this I have created data type for stored procedure with 10 elements and executed the scenario and was successfully running.
    when I added 3rd insert statement to stored procedure ie., when i added 5 more elements to the datatype (totally 15 elements) it starts giving the bellow error in Message Monitoring.
<i><b>Exception caught by adapter framework: Error processing request in sax parser: Error when executing statement for table/stored proc. 'COGRP_TMP_PROC_1' (structure 'Statements'): java.sql.SQLException: General error</b></i>
<i><b>Delivery of the message to the application using connection JDBC_http://sap.com/xi/XI/System failed, due to: com.sap.aii.af.ra.ms.api.RecoverableException: Error processing request in sax parser: Error when executing statement for table/stored proc. 'COGRP_TMP_PROC_1' (structure 'Statements'): java.sql.SQLException: General error</b></i>
   Note:- I have run the stored procedure with three insert statements in Sql Server, and also by calling an external program also, and was working fine.
<i><b> Note : Is there any structure needs to be follow when working with IDOC to Stored procedure.</b></i>
I am struck up with the error, can any body resolve this issue.
Thanks in Advance,
Murthy

Hi narasimha,
                  This seems to be any error due to incorrect query formation.In your receiver jdbc channel set the parameter logSQLstatement = true.you can find this parameter in the advanced mode. Using this parameter you will be able to see the sql query which is generated at runtime in the audit log in RWB.
Regards,
Pragati

File to JDBC :Error when executing statement for table/stored proc.

Hi,
I am getting following error when i am trying to insert data into z-table using JDBC recr adapter.
Error while parsing or executing XML-SQL document: Error processing request in sax parser: Error when executing statement for table/stored proc. 'ZTEST' (structure 'STATEMENT'): java.sql.SQLException: <u>[Microsoft][SQLServer 2000 Driver for JDBC][SQLServer]Invalid object name '<b>ZTEST</b>'.</u>
But the database table name 'ZTEST' exists in the system.
XML structure:
<?xml version="1.0" encoding="UTF-8"?>
<ns0:MT_RECR xmlns:ns0="http://urn:srini/FileToJDBC">
   <STATEMENT>
      <TEST action="INSERT">
         <table>ZTEST</table>
         <access>
            <ROLLNO>123</ROLLNO>
            <FIRSTNAME>ABC</FIRSTNAME>
            <LASTNAME>XYZ</LASTNAME>
         </access>
      </TEST>
   </STATEMENT>
</ns0:MT_RECR>
Regards,
Srinivas

Hi,
I have changed my MT str but still getting the same error.Is it possible to insert/ update a z-table using JDBC adapter.
XML str:
<?xml version="1.0" encoding="UTF-8"?>
<ns0:MT_RECR xmlns:ns0="http://urn:srini/FileToJDBC">
   <STATEMENT>
      <ZTEST action="INSERT">
         <access>
            <ROLLNO>123</ROLLNO>
            <FIRSTNAME>abc</FIRSTNAME>
            <LASTNAME>XYZ</LASTNAME>
         </access>
      </ZTEST>
   </STATEMENT>
</ns0:MT_RECR>
Regards,
Srinivas

Handling result form Stored Proc in java program

Folks, I have a question on how to handle results from Stored Procedures with the java.sql API. I execute a stored proc from a java program using the statement:
statement.execute();
where 'statement' is of type Statement. Then I get the results:
ResultSet rs = query.getResultSet();
The above returns me a ResultSet object. Now, my stored proc is such that it will return an integer in case of errors (as error code), and, if no error,it'll return the result set. Because I wouldn't know if the stored proc is returning an integer or a result set, how do I get the result of the stored proc in the java program? 'query.getResultSet()' would get me only an object of type ResultSet. What if the stored proc is returning an integer (i.e. when an error occurs)?
Thanks.

GSP wrote:
Thanks to all for your replies. I do not have access to modify the stored procedure. I can just use it in my java program. The stored proc first validates its input parameters. If it finds them invalid, then it returns an appropriate error code (which is an integer) depending on which input param is found invalid. If all the input parameters are found valid, then it fetches the rows from the DB tables & returns them as result set. Now my question is: say if I give a statement as this in my java program:
ResultSet rs = query.getResultSet();
what if the stored proc returns an error code (Since the above statement gets only ResultSet object, how will it handle if the stored proc returns an int)? Is there any alternative?
Ok, so there is a piece of missing data.
Store procs, conceptuatlly can return data in a variety of ways.
So the first step is to determine how the data is being returned.
Unless you know that there is no way to determine how to use it in java.

Getting error while invoking relational physical DS for sybase stored proc

*com.bea.dsp.das.exception.DASException: com.bea.dsp.wrappers.rdb.exceptions.RDBWrapperException: {bea-err}RDBW0004: Error executing SQL query: [BEA][Sybase JDBC Driver][Sybase]SELECT INTO command not allowed within multi-statement transaction+.*
I have created a physical DS function using "relational" in the wizard and connecting to sybase ASE stored procedure that is in unchained mode. I had configured the JDBC pool using BEA sybase non-XA 12.x driver.
When i run the physical DS (or logical DS), i get the above error. The sybase srever(and stored proc) is hosted by an external system and right now i do not have access/contacts to change anything.
After hours spent googling, it appears that the fix may possibly be setting "set chained off" before calling the stored proc. To achieve that, i tried the below two methods but nothing seems to work:
- In the JDBC URL, set property via ?chained=off (also tried false instead of "off")
- In Admin console/JDBC connection pool configuration/initSQL tried "SQL SET CHAINED OFF" and "SET CHAINED OFF"
My ODSI version is 10gR3
Oracle Workshop for WebLogic
Version: 10.3
Build id: 1137967
I tried using java physical DS and get the same error. I wrote a test stored proc in my local PC sybase ASE and it runs fine. But i connected as "sa".
I would like to exhaust all possible options from my side before making the long process of getting something changed in the external sybase DB like setting the proc mode to "anymode".
Please help.
Thank you.

mikereiche wrote:
Did the test stored proc use "SELECT INTO"?Yes. But it did not do much(code below)
>
Was the test stored proc tagged the same as the one that fails (chained/unchained?)Yes. "sp_procxmode" confirms that the test stored proc is in "unchained" transaction mode.
>
Can you get jdbc code that successfully calls the stored proc using the datasource?Yes, my colleague was trying the jdbc code and i was trying in the workshop with relational. She has left for the day so will post tomorrow. Please note that this is only for the test stored proc. The java jdbc also gets the same error for the "real" stored proc.
>
BTW - if you used "SET CHAINED OFF" as initSql, unless you have a table named SET, the sql will fail and the datasource will not be created. So that casts some doubt on whether the other setting "SQL SET CHAINED OFF" was applied.
Also - the connections are reset to default when they are returned to the connection pool, so I think "SQL SET CHAINED OFF" should be used as the "Test Table Name" and Test On Reserve should be checked.Tried it now, but it does not work. I'm getting the same error.
test stored proc:
create procedure dbo.getCustomerMulti @cid_inp varchar(40)
as
begin
select dbo.Customer.FirstName, dbo.Customer.cid, dbo.Customer.LastName, dbo.Customer.DateCreated, dbo.Customer.id into #temp from dbo.Customer
select dbo.Customer.FirstName, dbo.Customer.cid, dbo.Customer.LastName, dbo.Customer.DateCreated, dbo.Customer.id from dbo.Customer where cid LIKE @cid_inp + '%'
end
Thank you.

Using Statement rather than CallableStatement for stored proc execution

Cleary, if you need to extract output parameters from a stored procedure, then you must use a CallableStatement to execute it. However, if your stored procedure just returns a basic ResultSet, or performs a database update, is there any penalty to using a regular Statement to execute the stored procedure?
For example -
String sql = "exec testprocedure 'param1' 'param2'";
Statement stmt = conn.createStatement();
ResultSet rs = stmt.executeQuery( sql );
vs.
CallableStatement cs = conn.prepareCall( "{call testprocedure(?,?)}" );
cs.setString( 1, "param1" );
cs.setString( 2, "param2" );
ResultSet rs = cs.executeQuery();
Any thoughts?

Any thoughts?You would have to look at the actual driver code for a sure answer.
But for any real database (which a stored proc suggests) I doubt there would be any difference at all. It would resolve to the same call.

How can you set the max row for a 'open cursor' in a stored proc?

I would like to know how can you set the maximum amount of row returned in a resultset coming from a stored proc?
You can do it via JDBC with cStatement.setMaxRows(10); but it works only for select that you do via JDBC...
I would like the same functionality using open cursor inside a stored proc...
Thanks...

is "where ROWNUM <= 10" the equivalent of "cStatement.setMaxRows(10);" because the ROWNUM as problem with the ORDER BY clause and the setMaxRows() as no problem...

BPEL process to Insert XML into DB using pl/sql stored proc

Hi,
We have created a BPEL process in which we are taking input request and store it into Oracle Database using PL/SQL proc.
We have been unsuccessful in doing so because the data stored in table has root element missing.
Has any body done this (insert xml into DB using pl/sql stored proc) successfully ?
We can so this successfully if we do not use stored procedure and store data directly in table.
Regards

I have done this, stored it as a CLOB.
Also I received the payload as an opaque schema, so I had to convert the message from binary into string.
This way the root element doesn't get removed.
cheers
James

Error when executing statement for table/stored proc DB2 - Data Truncation

Hi,
I have one call sp in XI with n parameters int and two parameters out.
well, to implement the interface gives the following error
com.sap.aii.af.ra.ms.api.DeliveryException: Error processing request in sax parser: Error when executing statement for table/stored proc. 'SPSAPAR9' (structure 'Statement'): java.sql.SQLException: The number of parameter values set or registered does not match the number of parameters
Thanks for your help
Ximena
Edited by: Ximena Gonzalez on Feb 19, 2008 11:50 AM
Edited by: Ximena Gonzalez on Feb 20, 2008 12:17 PM

My Error is change
Error while parsing or executing XML-SQL document: Error processing request in sax parser: Error when executing statement for table/stored proc. 'SAPPRG.SPSAPAR9' (structure 'Statement'): java.sql.DataTruncation: Data truncation
but de change DT SP
<?xml version="1.0" encoding="UTF-8" ?>
<ns1:AlistReqDet2_MT xmlns:ns1="urn:proxl:tmuc:proxl01:AlistReqItems">
<Statement>
<SPSAPAR9 action="EXECUTE">
<table>SAPPRG.SPSAPAR9</table>
<ISAPNU1 isInput="TRUE" type="STRING">0080000353</ISAPNU1>
<ISAPEM1 isInput="TRUE" type="STRING">'LU'</ISAPEM1>
<ISAPC05 isInput="TRUE" type="STRING">15353</ISAPC05>
<ISAPSEC isInput="TRUE" type="STRING">10</ISAPSEC>
<ISAPLOT isInput="TRUE" type="STRING">'lats'</ISAPLOT>
<ISAPCA1 isInput="TRUE" type="STRING">10</ISAPCA1>
<ISAPCA2 isInput="TRUE" type="STRING">10</ISAPCA2>
<ISAPKIL isInput="TRUE" type="STRING">10</ISAPKIL>
<ISAPES1 isInput="TRUE" type="STRING">'T'</ISAPES1>
<ISAPSW isOutput="TRUE" type="STRING" />
</SPSAPAR9>
</Statement>
</ns1:AlistReqDet2_MT>

Stored proecedure tutorial for insert, delete, update,select

I want to integrate the stored procedure in my project
i am using jsp,
any one suggest me, stored proecedure tutorial for insert, delete, update,select
thanx.

Whether you are using JSP or not should not affect your decision (though I would recommend checking out the MVC pattern, and recommend against doing data access code from your JSP's).
You simply need one tutorial on how to invoke a stored procedure. The stored procedure you write can have INSERT, SELECT, UPDATE, DELETE, whatever. You simply have to master the concepts involved in java.sql.CallableStatement. (And then you can get more fancy with vendor-specific extensions).
However, I am a bit confused. You want a tutorial on stored procedures, but then you indicate very normal DML statements like INSERT, UPDATE and DELETE. All of these (queries, DML and stored procedures) fall under the general umberella of JDBC. So, it is always a good place to start with a plain ole JDBC tutorial.
java.sun.com/docs/books/tutorial/jdbc/index.html
www.onjava.com/pub/a/onjava/2003/08/13/stored_procedures.html
- Saish

New Stored Proc For Patch 20 ? SBO_SP_PostTransactionNotice

Does anyone know more information about this stored proc and at what stage it is fired?
I assume it is after an object has been "Added, Updated, closed etc..."
and this will allow us to then perform some actions
Is this correct
Please Help

Hi all,
Just adding some info. The SAP Note 1039449 says the following:
<i>Three new stored procedures were added to the database:
1. SBO_SP_TransactionSupport
2. SBO_SP_PostTransactionNotice
3. SBO_SP_PostTransactionSupport
The stored procedures SBO_SP_TransactionSupport and
SBO_SP_PostTransactionSupport are encoded and cannot be edited by the user.
The stored procedure SBO_SP_PostTransactionNotice is open for editing like
the SBO_SP_TransactionNotification stored procedure.
These stored procedures are executed before and after each transaction in
SAP Business One to ensure the correctness of the transaction.</i>
Still can't find time to test it, but if I understand well (actually I'm hoping this), we can now use the TN to correctly rollback a transaction, and the SBO_SP_PostTransactionNotice to correctly notify about transactions. Any test about this topic will very welcome.
Regards,
Ian

ON INSERT stored proc's for sequence handling

Similar Messages

Maybe you are looking for