Only else statement works

Question

Morning,
Would someone please look this over? I can't seem to get it to work properly. What I am trying to do is insert the substr into another table if it is found otherwise insert a default date. Right now only the default date is inserting into the table temphone1 for every row even though there are many strings that should have been also inserted.
oracle 11g redhat linux.
declare
cursor c_1 is
select * from raw_data
where rownum < 500;
begin
for c_rec in c_1
loop
if regexp_substr(c_rec.date_time,'^(0?[1-9]|1[0-2])/(0?[1-9]|[1-2][0-9]|3[0-1])/([[:digit:]]{4})') is not null
then
update temphone1 set new_time= regexp_substr(c_rec.date_time,'^(0?[1-9]|1[0-2])/(0?[1-9]|[1-2][0-9]|3[0-1])/([[:digit:]]{4})');
else
update temphone1 set new_time = to_date('23/NOV/2008','DD/MON/YYYY');
end if;
commit;
end loop;
end;
Thank you in advance that you can give me.
regards,
al

Answer 1

Hi, Al,
afaltyn wrote:
Morning,
Would someone please look this over? I can't seem to get it to work properly. What I am trying to do is insert the substr into another table if it is found otherwise insert a default date. Right now only the default date is inserting into the table temphone1 for every row even though there are many strings that should have been also inserted.
oracle 11g redhat linux.
declare
cursor c_1 is
select * from raw_data
where rownum < 500;
begin
for c_rec in c_1
loop
if regexp_substr(c_rec.date_time,'^(0?[1-9]|1[0-2])/(0?[1-9]|[1-2][0-9]|3[0-1])/([[:digit:]]{4})') is not null
then
update temphone1 set new_time= regexp_substr(c_rec.date_time,'^(0?[1-9]|1[0-2])/(0?[1-9]|[1-2][0-9]|3[0-1])/([[:digit:]]{4})');
else
update temphone1 set new_time = to_date('23/NOV/2008','DD/MON/YYYY');
end if;
commit;
end loop;
end;
/Never write, let alone post, unformatted code.
Indent the code to show the scope of statements such as BEGIN, LOOP and IF.
When posting any formatted text (not just code) on this site, type these 6 characters:
\(small letters only, inside curly brackets) before and after each section of formatted text, to preserve spacing.
Whenever you have a problem, please post a little sample data (CREATE TABLE and INSERT statements, relevant columns only) from all tables.
Also post the results you want from that data, and an explanation of how you get those results from that data, with specific examples.
If you're asking about a DML statement, such as UPDATE, the CREATE TABLE and INSERT statements should re-create the tables as they are before the DML, and the results  will be the contents of the changed table(s) when everything is finished.
Always say which version of Oracle you're using.
Is temphohne1.new_time a DATE?  If so, don't try to assign a VARCHAR2 value to it, like you're doing here:update temphone1 set new_time= regexp_substr(c_rec.date_time,'^(0?[1-9]|1[0-2])/(0?[1-9]|[1-2][0-9]|3[0-1])/([[:digit:]]{4})');
Is temphohne1.new_time a VARCHAR2?  If so, don't try to assign a DATE value to it, like you're doing here:update temphone1 set new_time = to_date('23/NOV/2008','DD/MON/YYYY');
You probably want to add WHERE clauses to both UPDATE statements.  As posted, each of them is updating every row in temphone1.  Perhaps you want something likeUPDATE temphone1
SET      new_time = '23/NOV/2008'     -- Assuming new_time is a string
WHERE     column_1 = c_1.column_a;