ORA-01722 Exception -help needed

Question

CREATE OR REPLACE PROCEDURE BILLING_NOTIFY.ComposeTextPopUPMessageinMC (
pi_NAME IN varchar2,
pi_SCN IN varchar2,
pi_ACCOUNTBALANCE IN varchar2,
pi_OFFERAMOUNT IN varchar2,
pi_DUEDATE IN varchar2,
pi_FREQ IN number
IS
po_error_code NUMBER;
e_exp EXCEPTION;
v_MsgTemplate varchar2(5000);
BEGIN
select MsgTemplate into v_MsgTemplate from notification_MessageTemplate where MsgTypeId=1;
insert into notification_message (clientId,messageId,payload,updated,frequency)
VALUES(pi_SCN,1,Replace(Replace(Replace(Replace(
Replace(v_MsgTemplate,'(Name)',upper(pi_NAME)),
'(SCN)',cast(pi_SCN as varchar2(15))),
'(AccountBalance)',cast(floor(pi_ACCOUNTBALANCE) as varchar2(15))),
'(OfferAmount)',cast(floor(pi_OFFERAMOUNT)as varchar2(15))),
'(LastChargedDate)',to_char(pi_DUEDATE,'MM-DD-YYYY')),
sysdate,pi_FREQ);
COMMIT;
END;
These are my INPUT values:
PI_NAME := 'RAJ';
PI_SCN := '200500';
PI_ACCOUNTBALANCE := '123';
PI_OFFERAMOUNT := '122';
PI_DUEDATE := '12-12-2005';
PI_FREQ := 1;
The value of v_MsgTemplate is
'Dear (Name)
Subscriber ID: (SCN)
Your account balance is Rs.(AccountBalance)
Please recharge minimum of Rs.(OfferAmount) before (LastChargedDate)
To recharge please call BIG TV Customer Care on 1800 200 9002.
Thank You.'
My SP Comoles without any errors,but when i try to run the SP using the above mentioned values am getting the following errors.
ORA-01722: invalid number
ORA-06512: at "BILLING_NOTIFY.COMPOSETEXTPOPUPMESSAGEINMC", line 23
ORA-06512: at line 17
Pls help me to correct my error.

Answer 1

Though cast is good option but it has also some limitations, too.
See ->
satyaki>
satyaki>select * from v$version;
BANNER
Oracle Database 10g Enterprise Edition Release 10.2.0.1.0 - Prod
PL/SQL Release 10.2.0.1.0 - Production
CORE    10.2.0.1.0      Production
TNS for Linux: Version 10.2.0.1.0 - Production
NLSRTL Version 10.2.0.1.0 - Production
Elapsed: 00:00:00.00
satyaki>
satyaki>
satyaki>
satyaki>with peter
  2     as
  3       (
  4         select '12.DEC.2008' cola from dual
  5       )
  6     select cast(cola as date) d_t
  7     from peter;
D_T
12-DEC-08
Elapsed: 00:00:01.05
satyaki>
satyaki>ed
Wrote file afiedt.buf
  1  with peter
  2     as
  3       (
  4         select '12.DEC-2008' cola from dual
  5       )
  6     select cast(cola as date) d_t
  7*    from peter
satyaki>/
D_T
12-DEC-08
Elapsed: 00:00:00.00
satyaki>
satyaki>ed
Wrote file afiedt.buf
  1  with peter
  2     as
  3       (
  4         select '12/DEC-2008' cola from dual
  5       )
  6     select cast(cola as date) d_t
  7*    from peter
satyaki>/
D_T
12-DEC-08
Elapsed: 00:00:00.00
satyaki>ed
Wrote file afiedt.buf
  1  with peter
  2     as
  3       (
  4         select '12DEC2008' cola from dual
  5       )
  6     select cast(cola as date) d_t
  7*    from peter
satyaki>/
D_T
12-DEC-08
Elapsed: 00:00:00.00
satyaki>ed
Wrote file afiedt.buf
  1  with peter
  2     as
  3       (
  4         select '200815.12' cola from dual
  5       )
  6     select cast(cola as date) d_t
  7*    from peter
satyaki>/
   select cast(cola as date) d_t
ERROR at line 6:
ORA-01861: literal does not match format string
Elapsed: 00:00:00.01
satyaki>
satyaki>ed
Wrote file afiedt.buf
  1  with peter
  2     as
  3       (
  4         select '20081512' cola from dual
  5       )
  6     select cast(cola as date) d_t
  7*    from peter
satyaki>/
   select cast(cola as date) d_t
ERROR at line 6:
ORA-01861: literal does not match format string
Elapsed: 00:00:00.00
satyaki>So, better to use format mask using to_date.
Regards.
Satyaki De.