Performance for a Specific Query:

Question

Hi, i am using a multi-threaded java application to execute a stored procedure with bulks of data grouped in an array. I use oracle 9i and this is the SP definition:
create or replace
PROCEDURE IE_SP_SET_BANS_TO_RECLASSIFY(
MIN_AMOUNT IN NUMBER ,
MIN_PAY_ADJ_DATE IN DATE,
RECLA_CANDIDATES IN IE_RECLA_CANDIDATE_TBL )
AS
BEGIN
FOR idx IN 1.. RECLA_CANDIDATES.COUNT
LOOP
INSERT INTO IE_RESUMEN_RECLA
SELECT BA.BAN,
BA.BILL_CYCLE,
BA.COL_NEXT_STEP_NO ,
BA.COL_NEXT_STEP_DATE,
BA.COL_WAIVER_IND ,
BA.STATUS_ACTV_RSN_CODE ,
BA.COL_ASSIGNED_COLL,
BA.COL_PATH_CODE ,
BA.COL_CATEGORY_NO ,
BA.ACCOUNT_TYPE ,
BA.ACCOUNT_SUB_TYPE ,
ADJ.ENT_SEQ_NO,
ADJ.ACTV_DATE,
ADJ.ACTV_AMT,
ADJ.SUBSCRIBER_NO,
' ' AS SOURCE,
ADJ.DESIGNATION,
'ADJ' AS IDENT
FROM CDLAPPC.ADJUSTMENT ADJ
INNER JOIN CDLAPPC.BILLING_ACCOUNT BA
ON(BA.BAN = ADJ.BAN)
WHERE ADJ.BAN = RECLA_CANDIDATES(idx).ban
AND ADJ.BALANCE_IMPACT_CODE = 'I'
AND TRUNC(ADJ.SYS_CREATION_DATE) >= MIN_PAY_ADJ_DATE
AND NVL(ADJ.ACTV_AMT,0) >= MIN_AMOUNT
AND ROWNUM = 1;
IF(SQL%ROWCOUNT = 0) THEN
INSERT INTO IE_RESUMEN_RECLA
SELECT BA.BAN,
BA.BILL_CYCLE,
BA.COL_NEXT_STEP_NO ,
BA.COL_NEXT_STEP_DATE,
BA.COL_WAIVER_IND ,
BA.STATUS_ACTV_RSN_CODE ,
BA.COL_ASSIGNED_COLL,
BA.COL_PATH_CODE ,
BA.COL_CATEGORY_NO ,
BA.ACCOUNT_TYPE ,
BA.ACCOUNT_SUB_TYPE ,
P.ENT_SEQ_NO,
P.DEPOSIT_DATE,
P.ORIGINAL_AMT,
P.SUBSCRIBER_NO,
P.SOURCE_ID,
P.DESIGNATION,
'PAY' AS IDENT
FROM CDLAPPC.PAYMENT P
INNER JOIN CDLAPPC.BILLING_ACCOUNT BA
ON(BA.BAN = P.BAN)
WHERE P.BAN = RECLA_CANDIDATES(idx).ban
AND TRUNC(P.SYS_CREATION_DATE) >= MIN_PAY_ADJ_DATE
AND NVL(P.ORIGINAL_AMT,0) >= MIN_AMOUNT
AND ROWNUM = 1;
END IF;
END LOOP ;
END IE_SP_SET_BANS_TO_RECLASSIFY;
I want to improve it's efficiency but i still do not know how. But possible solutions are:
-i know that a FORALL loop would improve my insert speed but in this case there is a condition so i don't know how to implement it in a forall.
-I want to avoid doing the inner join with billing_account for the query but i do not know if providing the billing_account details in the input table would make it more efficient, is not a lot of data per row, but i am sending 10k rows per SP call, also i am not sure if there will be a lot of context switching with PL/SQL and SQL in case i do that.
Any help would be appreciated, thanks.

Answer 1

Some of the suggestions I can make for improving the Queries are
1) Try using Indexed columns whereever possible , specially when you are joining tables. If there is no index on column that you are using to join ,then either try to use columns which have an index or create a new index on columns if required.
2) Try to see the Explain Plan for the select statements you are uisng. If you are using TOAD, try to use the tool's feature to generate different possible combinations of queries with the least cost. You need to supply TOAD with the problematic SQL statement, it will automatically generate different combinations of SQL statements and then you can choose the one with the least cost or the one with the best Explain plan results.
Hope this helps.
Regards
IQ