Performance query in sql

Question

  
This query takes 1 mins to execute, Please suggesr if we can improve more on performance
  SELECT P.ProgramId
                  ,P.Tier4Id
                ,7 AS MetricId
                ,(convert(DATETIME, CONVERT(VARCHAR, Month(s.DATE)) + '/1/' + CONVERT(VARCHAR, Year(s.DATE)))) AS DATE
                ,CASE
                    WHEN SUM(ISNULL(S.ITD_BCWS_PMB, 0)) <> 0
                        THEN ROUND(SUM(ISNULL(S.ITD_BCWP_PMB, 0)) / SUM(ISNULL(S.ITD_BCWS_PMB, 0)), 2)
                    ELSE NULL
                    END AS Value
                ,SUM(ISNULL(S.ITD_BCWP_PMB, 0)) AS BCWP
            FROM Staging.SPI_CPI_WBS S
            INNER JOIN Core.Projects PJ ON S.ProjectId = PJ.ProjectId AND PJ.IsActive = 1
            INNER JOIN Core.ProgramFinancials PF ON PF.ProgramId = S.ProgramId AND Year(PF.DATE) = Year(S.DATE) AND PF.IsYearly = 1
            INNER JOIN Core.v_WBS_Tier_Structure_SPICPI P ON S.WBSId = P.WBSId AND P.ProgramId = S.ProgramId
            WHERE S.LSKINdicator = 1 AND S.ProjectId IS NOT NULL
                /*AP3-820 Check for BCWP > 0*/
                AND ISNULL(S.ITD_BCWP_PMB, 0) > 0 AND (P.ProgramStatus = 1 OR isnull(PF.Spend, 0) != 0)
            GROUP BY P.ProgramId
                ,s.DATE
                ,P.Tier4Id
            HAVING SUM(ISNULL(S.ITD_BCWP_PMB, 0)) > 0
Smash126

Answer 1

Hi This entire query i am posting see if any more optimization can be done please
 UPDATE DW.ProgramScores_T4_P    
 SET     
  SPI=null    
  ,SPI_H=null    
  ,CPI=null    
  ,CPI_h=null    
  , M_SPI = null    
  ,M_SPI_H = null    
  ,M_CPI = null    
  ,M_CPI_H = null    
 where Date  between dateadd(mm,-12,getdate()) and getdate()       
-- SPI CPI - Programscores    
MERGE DW.ProgramScores_T4_P DW    
USING      
SELECT   isnull(SPI.ProgramId, CPI.ProgramId) AS ProgramId    
  ,isnull(SPI.DATE, CPI.DATE) AS DATE    
     ,isnull(SPI.Tier4Id,CPI.Tier4Id) as Tier4Id     
  ,SPI    
  ,SPI_H    
  ,CPI    
  ,CPI_H    
  ,CASE     
   WHEN isnull(SPI.DATE, CPI.DATE) BETWEEN dateadd(mm, - 12, getdate()) AND getdate()    
    THEN 1    
   ELSE 0    
   END AS Datediff    
  ,Month(isnull(SPI.DATE, CPI.DATE)) AS Month    
  ,Year(isnull(SPI.DATE, CPI.DATE)) AS Year    
FROM (    
 SELECT SPI.ProgramId    
  ,SPI.Metricid    
  ,Tier4Id    
  ,DATE    
  ,SPI    
  ,SPI_H    
 FROM (    
  SELECT ProgramId    
   ,Tier4Id    
   ,A.MetricId    
   ,DATE    
   ,Value AS SPI    
    CASE     
     WHEN [Value] IS NULL OR [IsGoalOriented] = (0) OR [IsGoalOriented] IS NULL /*OR MBM.fn_CheckGoalsAvailability(A.MetricId) = 0 */    
      THEN (5)    
     ELSE CASE     
       WHEN [Value] >= [LCLG] AND [Value] <= [UCLG] OR [Value] >= [LCLG] AND [UCLG] IS NULL    
        THEN (2)    
       ELSE CASE     
         WHEN [Value] >= [LCLY] AND [Value] <= [UCLY]    
          THEN (3)    
         ELSE (4)    
         END    
       END    
     END    
    ) AS SPI_H    
  FROM (    
   SELECT P.ProgramId    
      ,P.Tier4Id    
    ,7 AS MetricId    
    ,(convert(DATETIME, CONVERT(VARCHAR, Month(s.DATE)) + '/1/' + CONVERT(VARCHAR, Year(s.DATE)))) AS DATE    
    ,CASE     
     WHEN SUM(ISNULL(S.ITD_BCWS_PMB, 0)) <> 0    
      THEN ROUND(SUM(ISNULL(S.ITD_BCWP_PMB, 0)) / SUM(ISNULL(S.ITD_BCWS_PMB, 0)), 2)    
     ELSE NULL    
     END AS Value    
    ,SUM(ISNULL(S.ITD_BCWP_PMB, 0)) AS BCWP    
   FROM Staging.SPI_CPI_WBS S    
   INNER JOIN Core.Projects PJ ON S.ProjectId = PJ.ProjectId AND PJ.IsActive = 1    
   INNER JOIN Core.ProgramFinancials PF ON PF.ProgramId = S.ProgramId AND Year(PF.DATE) = Year(S.DATE) AND PF.IsYearly = 1    
   INNER JOIN Core.v_WBS_Tier_Structure_SPICPI P ON S.WBSId = P.WBSId AND P.ProgramId = S.ProgramId    
   WHERE S.LSKINdicator = 1 AND S.ProjectId IS NOT NULL    
    /*AP3-820 Check for BCWP > 0*/    
    AND ISNULL(S.ITD_BCWP_PMB, 0) > 0 AND (P.ProgramStatus = 1 OR isnull(PF.Spend, 0) != 0)    
   GROUP BY P.ProgramId    
    ,s.DATE    
    ,P.Tier4Id    
   HAVING SUM(ISNULL(S.ITD_BCWP_PMB, 0)) > 0    
   ) A    
  INNER JOIN MBM.Metrics M ON M.MetricId = A.MetricId AND M.IsActive = 1    
  ) SPI    
 ) SPI    
LEFT JOIN (    
 SELECT CPI.ProgramId    
       --,WBSId    
  ,Tier4Id    
  --,Tier3Id    
  --,Tier2Id    
  ,CPI.Metricid    
  ,DATE    
  ,CPI    
  ,CPI_H    
 FROM (    
  SELECT ProgramId    
      --,WBSId    
    ,Tier4Id    
    --,Tier3Id    
    --,Tier2Id    
   ,A.MetricId    
   ,DATE    
   ,Value AS CPI    
    CASE     
     WHEN [Value] IS NULL OR [IsGoalOriented] = (0) OR [IsGoalOriented] IS NULL /*OR MBM.fn_CheckGoalsAvailability(A.MetricId) = 0 */    
      THEN (5)    
     ELSE CASE     
       WHEN [Value] >= [LCLG] AND [Value] <= [UCLG] OR [Value] >= [LCLG] AND [UCLG] IS NULL    
        THEN (2)    
       ELSE CASE     
         WHEN [Value] >= [LCLY] AND [Value] <= [UCLY]              THEN (3)    
         ELSE (4)    
         END    
       END    
     END    
    ) AS CPI_H    
  FROM (    
   SELECT P.ProgramId    
   --,S.WBSId    
    ,P.Tier4Id    
    --,WBS.Tier3Id    
    --,WBS.Tier2Id    
    ,8 AS MetricId    
    ,(convert(DATETIME, CONVERT(VARCHAR, Month(s.DATE)) + '/1/' + CONVERT(VARCHAR, Year(s.DATE)))) AS DATE    
    ,CASE     
     WHEN SUM(ISNULL(S.ITD_ACWP, 0)) <> 0    
      THEN ROUND(SUM(ISNULL(S.ITD_BCWP_PMB, 0)) / SUM(ISNULL(S.ITD_ACWP, 0)), 2)    
     ELSE NULL    
     END AS Value    
    ,SUM(ISNULL(S.ITD_BCWP_PMB, 0)) AS BCWP    
   FROM Staging.SPI_CPI_WBS S    
   INNER JOIN Core.Projects PJ ON S.ProjectId = PJ.ProjectId AND PJ.IsActive = 1    
   --INNER JOIN Core.Programs P ON P.ProgramId = S.ProgramId and P.Isactive=1    
   INNER JOIN Core.ProgramFinancials PF ON PF.ProgramId = S.ProgramId AND Year(PF.DATE) = Year(S.DATE) AND PF.IsYearly = 1    
   --inner join Core.WBS_CAM_TIERS_Structure WBS ON S.WBSId = WBS.WBSId    
   INNER JOIN Core.v_WBS_Tier_Structure_SPICPI P ON S.WBSId = P.WBSId AND P.ProgramId = S.ProgramId    
   WHERE S.LSKINdicator = 1 AND S.ProjectId IS NOT NULL    
    /*AP3-820 Check for BCWP > 0*/    
    AND ISNULL(S.ITD_BCWP_PMB, 0) > 0 AND (P.ProgramStatus = 1 OR isnull(PF.Spend, 0) != 0)    
   GROUP BY P.ProgramId    
    ,s.DATE    
    --,S.WBSId    
    ,P.Tier4Id    
       --,WBS.Tier3Id    
       --,WBS.Tier2Id    
   HAVING SUM(ISNULL(S.ITD_BCWP_PMB, 0)) > 0 /*AP3-688 & AP3-702 Check for BCWP > 0 */    
   ) A    
  INNER JOIN MBM.Metrics M ON M.MetricId = A.MetricId AND M.IsActive = 1    
  ) CPI    
 WHERE CPI IS NOT NULL    
 ) CPI     
  ON CPI.ProgramId = SPI.ProgramId AND CPI.DATE = SPI.DATE AND     
     CPI.Tier4Id = SPI.Tier4Id --AND  CPI.Tier3Id = SPI.Tier3Id AND  CPI.Tier2Id = SPI.Tier2Id    
)SPICPI     
  on SPICPI.ProgramId = DW.ProgramId and Datediff(dd,SPICPI.Date,DW.Date) = 0  and     
     SPICPI.Tier4Id = DW.Tier4Id --and SPICPI.Tier3Id = DW.Tier3Id and SPICPI.Tier2Id = DW.Tier2Id    
WHEN MATCHED AND (SPICPI.Datediff = 1) THEN    
update SET DW.SPI = SPICPI.SPI,    
     DW.SPI_H = SPICPI.SPI_H,    
     DW.CPI = SPICPI.CPI,    
     DW.CPI_H = SPICPI.CPI_H,    
     DW.UpdatedDate = getdate()    
WHEN NOT MATCHED THEN    
insert (ProgramId,Tier4Id, Date,SPI,SPI_H,CPI,CPI_H,CreatedDate)    
values(SPICPI.ProgramId,SPICPI.Tier4Id,SPICPI.Date,SPICPI.SPI,SPICPI.SPI_H, SPICPI.CPI,SPICPI.CPI_H,getdate());    
Smash126