PL/SQL 10g - Cannot Insert Values from PL/SQL

Question

Hi People,
BACKGROUND (if required):
I'm trying to write a message threading algorithm for uni, I believe it works so far, it's just matching the subjects at the moment I want to expand it to include email addresses but that will be at a later date.
A brief run down, at the moment, a user can generate a list of email addresses to filter the corpus with, these are then inserted (via Java) into the table Sender. These addresses are then used in an IF statement, however they are only used if the table sender is populated. The messges that are identified as threads have their Message ID inserted into another table but they also have their values printed to the DBMS output.
QUESTION:
What I need help with is although the values print out to the DBMS Output after a great deal of time, normally after the DBMS buffer has maxed out (thus the statement ends in error). The values printed are not inserted into the table.
Any help on solving this or optimising if would be greatly appreciated, I'm new to PL/SQL i'm afraid so it's probably a really messy statement.
If this is a badly worded question and I need to supply more information then I gladly will, however i'm not 100% on what information is relevant at the moment.
Below is the statement in question.
Thanks and Regards,
K
LOOP
IF sender_cur1%FOUND THEN
IF sub_One = Sub_two and sub_One_MID != sub_Two_MID and Sub_One_Sender = send_user_cur THEN
INSERT INTO MATCHING_SUB (MID) VALUES (sub_Two_MID);
dbms_output.put_line('MID is: ' || sub_Two_MID);
END IF;
ELSE
IF sub_One = Sub_two and sub_One_MID != sub_Two_MID THEN
INSERT INTO MATCHING_SUB (MID) VALUES (sub_Two_MID);
dbms_output.put_line('MID is: ' || sub_Two_MID);
END IF;
END IF;
Edited by: user8967525 on 01-Mar-2010 07:27
Edited by: user8967525 on 01-Mar-2010 08:08

Answer 1

cd,
I will most certainly try.
I have a table of emails that I am attempting to thread by means of comparing the subjects together (for now). However ultimately I want to be able to bring in the recipients as well. However this can be ignored for now.
The main variables from the Messages table are:
MID(number) - 0 - 245000
SENDER(VARCHAR) - Email Address
SUBJECT_CLN6 - VARCAHR - Cleaned email subject.
I am creating two instancs of a cursor that contains the subjects and MID's from Messages. I am then looping through cur1 comparing the value against all values in cur2, this continues until all values in cur1 have been compared against cur2. I use the MID to ensure that I am not comparing the same Message. Furthermore I am also filtering the Emails by Sender (if the table has been populated by the user, via a java applet, otherwise if just uses the subject). The variable Send_User_Cur takes takes its values from the Table called Sender, whilst sub_one_sender takes its values from the column Sender in Messages.
The proposed output of this at the moment is to just have the MID's (and later all the relevant columns, however just for now MID) of all the threaded emails, inserted into the table MATCH_THREAD, such that they can be called upon later for further processing and most likely called from a java applet at some point as well.
I've pasted the entire code below. I understand that it looks a bit messy on the preview and for that I apologise.
Thanks all!
Kev
DECLARE
CURSOR sub_cur1 IS
SELECT MID, Sender, trim(subject_cln6) from MESSAGES;
sub_One MESSAGES.subject_cln6%TYPE;
sub_One_MID MESSAGES.MID%type;
sub_One_Sender MESSAGES.SENDER%type;
CURSOR sub_cur2 IS
SELECT MID, trim(subject_cln6) from Messages;
sub_Two MESSAGES.subject_cln6%TYPE;
sub_Two_MID MESSAGES.MID%type;
CURSOR sender_cur1 IS
SELECT SENDER_ID FROM SENDER;
Send_User_Cur SENDER.SENDER_ID%type;
counter number := 0;
MID_t MESSAGES.MID%TYPE;
i number := 0;
j number := 0;
BEGIN
SELECT count(subject) INTO counter
FROM MESSAGES;
OPEN sub_cur1;
OPEN sub_cur2;
OPEN sender_cur1;
FETCH sub_cur1 INTO sub_One_MID, Sub_One_Sender, Sub_One;
FETCH sender_cur1 INTO Send_User_Cur;
WHILE sub_cur1%FOUND
LOOP
IF sub_cur2%ISOPEN THEN
FETCH sub_cur2 INTO sub_Two_MID, SUB_Two;
dbms_output.put_line('OPEN');
ELSE
OPEN sub_cur2;
FETCH sub_cur2 INTO sub_Two_MID, SUB_Two;
--dbms_output.put_line('OPENED and FETCHED');
END IF;
LOOP
IF sender_cur1%FOUND THEN
IF sub_One = Sub_two and sub_One_MID != sub_Two_MID and Sub_One_Sender = send_user_cur THEN
INSERT INTO MATCH_THREAD (MID) VALUES (sub_Two_MID);
commit;
END IF;
ELSE
IF sub_One = Sub_two and sub_One_MID != sub_Two_MID THEN
INSERT INTO MATCH_THREAD (MID) VALUES (sub_Two_MID);
commit;
END IF;
END IF;
FETCH sub_cur2 INTO sub_Two_MID, SUB_Two;
i := i + 1;
EXIT WHEN i = counter;
END LOOP;
CLOSE sub_cur2;
FETCH sub_cur1 INTO sub_One_MID, Sub_One_Sender, SUB_One;
i := 0;
dbms_output.put_line('sub_One_MID: ' || sub_one_mid);
END LOOP;
CLOSE sub_cur1;
CLOSE sub_cur2;
END;