Pl/sql block updating orderId, itemID

Question

lol here i am again!
This time its like this:
i have a table (orderId, itemId, CustomerId, productId, quantity, start_date, end_date, oldRef)
here are some of the values:
2477, 1, 201, 111, 1,19-MAR-93,14-APR-93
2477,2,201,112,1,19-MAR-93,14-APR-93
2478,1,201,113,1,19-MAR-93,14-APR-93
2478,2,201,110,19-Mar-93,14-APR-93
Now as you can see that order_Id is different however order_date and ship_date both match. Now what i want to do is to give them a new orderId, re-arrange itemId if ship_date and order_date match for each customer so the ex above should come out like this:
1, 1, 201, 111, 1,19-MAR-93,14-APR-93
1,2,201,112,1,19-MAR-93,14-APR-93
1,3,201,113,1,19-MAR-93,14-APR-93
1,4,201,110,19-Mar-93,14-APR-93
I have created a pl/sql block. It has a cursor that loops around each row of table. Then it stores orderdate, shipdate and customerId. it also has a itemId variable and orderDate variable. OrderDate variable takes its value from orderId sequence and itemId is just a number that increments itself.
NOW when orderdate,shipdate&customerId are the same, i just update the itemId, if they differ or customer_id changes i get a new order_id, update the variables (orderdate,shipdate,customerid,itemId) but for some reason i dont think it is working!!
DECLARE
     cursor c1 is
          SELECT
          FROM
               ph2_item
          order by
               customer_id,
               ship_date,
               order_date
          for update;
     new_order_id     number(8,0) := 0;
     new_item_id     number(4,0) := 1;
     temp_odate      date := '11-JUN-08';
     temp_sdate     date:= '11-JUN-08';
     temp_cId     number(8,0) := 1;
BEGIN
     FOR rec in c1 LOOP
          IF  rec.customer_id = temp_cId  THEN
               IF (rec.order_date <> temp_odate OR
               rec.ship_date <> temp_sdate) THEN
                    new_item_id:= 1;
                                SELECT  orderid.nextVal into new_order_id from dual;
                    temp_odate :=rec.order_date;
                    temp_sdate :=rec.ship_date;
               END IF;
          ELSE
               new_item_id:= 1;
               SELECT  orderid.nextVal into new_order_id from dual;
               temp_cid := rec.customer_id;
               temp_odate :=rec.order_date;
               temp_sdate :=rec.ship_date;
          END IF;
          update ph2_item
          set order_id = new_order_id, item_id = new_item_id
          where current of c1;
          new_item_id := new_item_id + 1;
     END LOOP;
END;
commit;PS> this is not a real life database and just a college assignment!
just corrected a mistake in one of the example code i posted
Message was edited by:
user646562

Answer 1

well it does seem to give the right results ie. orderId is changed and itemId is rearranged! however the college has an online marker and when i try to submit the code, it says that the max(order_id) of the resulting table (ph2_item) is wrong, the sum(item_id) is wrong and the no of distinct orders is wrong.. this means i am either consolidating orders whne i shouldnt, and this in turns make my item_id wrong..
also there is one more criteria i should have mentioned but i forgot and that is even if the order_date and ship_date is the same as another order, we will only consolidate them if the customer in question has multiple sites.
here is the updated pl/sql block taking into account this criteria (using if/else statement)
DECLARE
     cursor c1 is
          SELECT
          FROM
               ph2_item
          order by
               order_date,
               customer_id
          for update;
     new_order_id     number(8,0) := 0;
     new_item_id     number(4,0) := 1;
     temp_odate date := '11-JUN-08';
     temp_sdate     date:= '11-JUN-08';
     temp_cId     number(8,0) := 1;
     totalSites     number(2,0);
BEGIN
     FOR rec in c1 LOOP
          select site_count into totalsites from customer_sites where customer_id = rec.customer_id;
          --dbms_output.put_line(rec.customer_id ||' ' || totalsites);
          if totalsites > 1 THEN
               IF rec.customer_id = temp_cId THEN
                    IF (rec.ship_date <> temp_sdate AND rec.order_date <> temp_odate) AND rec.ship_date is null THEN
                         new_item_id:= 1;
     SELECT orderid.nextVal into new_order_id from dual;
                         temp_odate :=rec.order_date;
                         --temp_sdate :=rec.ship_date;
                    END IF;
               ELSE
                    new_item_id:= 1;
                    SELECT orderid.nextVal into new_order_id from dual;
                    temp_cid := rec.customer_id;
                    temp_odate :=rec.order_date;
                    --temp_sdate :=rec.ship_date;
               END IF;     
          ELSE
               new_item_id:= 1;
               SELECT orderid.nextVal into new_order_id from dual;
               temp_cid := rec.customer_id;
               temp_odate :=rec.order_date;
               --temp_sdate :=rec.ship_date;
          END IF;      
          update ph2_item
          set order_id = new_order_id, item_id = new_item_id
          where current of c1;
          new_item_id := new_item_id + 1;
     END LOOP;
END;