PL/SQL procedure to kill inactive session

Question

Hi all ,
Please i am trying to write a procedure to kill inactive sessions of the shema 'TESTSCHEMA' .This is my first procedure , am not use to pl/sql but i went through many turtorial but have some errors at compliation .when i try to compile the procedure the errors are as below :
15:50:28 Start Find Objects [TESTSCHEMA@TESTDB_UNIX(2)] ...
15:50:28 End Find Objects [TESTSCHEMA@ TESTDB_UNIX(2)]
15:50:32 Start Compiling 1 object(s) ...
15:50:32 Executing ALTER PROCEDURE fib_dead_cnx_cleanup COMPILE ...
15:50:32 [13:2] PL/SQL: ORA-00933: SQL command not properly ended
15:50:32 [9:3] PL/SQL: SQL Statement ignored
15:50:32 [18:12] PLS-00103: Encountered the symbol "(" when expecting one of the following:
15:50:32 constant exception <an identifier>
15:50:32 <a double-quoted delimited-identifier> table LONG_ double ref
15:50:32 char time timestamp interval date binary national character
15:50:32 nchar
15:50:32 The symbol "<an identifier>" was substituted for "(" to continue.
15:50:32 [18:21] PLS-00103: Encountered the symbol "LOOP" when expecting one of the following:
15:50:32 := ; not null default character
15:50:32 The symbol "; was inserted before "LOOP" to continue.
15:50:32 [27:8] PLS-00103: Encountered the symbol "ALTER" when expecting one of the following:
15:50:32 begin case declare exit for goto if loop mod null pragma
15:50:32 raise return select update while with <an identifier>
15:50:32 <a double-quoted delimited-identifier> <a bind variable> <<
15:50:32 close current delete fetch lock insert open rollback
15:50:32 savepoint set sql execute commit forall merge pipe
15:50:32 Compilation complete - 5 error(s) found
15:50:32 End Compiling 1 object(s)
below is the procedure code :
CREATE OR REPLACE
PROCEDURE fib_dead_cnx_cleanup
AS
l_serial     CHAR(100);
l_sid CHAR (100);
l_sid_serial CHAR(100);
l_count      NUMBER(10,0);
CURSOR session_cur IS
          SELECT sid,serial#,sid||','||serial# as sid_serial
     FROM v$session
     WHERE username='EBBFCAT' and schemaname='TESTSCHEMA'
     and status='INACTIVE'
BEGIN
     BEGIN
     l_count := 0;
               OPEN session_cur;
                    WHILE ( 1 = 1) LOOP
                         BEGIN
                              FETCH session_cur INTO l_sid ,l_serial,l_sid_serial ;
                                   EXIT WHEN session_cur%NOTFOUND ;
                              BEGIN
                                   alter system kill session 'l_sid_serial' ;
                              END;     
                         END;
                    END;
               CLOSE session_cur;
     END;
END FIB_DEAD_CNX_CLEANUP;
Thanks

Answer 1

Hi,
Never write, let alone post, unformatted code.
When posting any formatted text on this site, type these 6 characters:
&#123;code&#125;
(small letters only, inside curly brackets) before and after sections of formatted text, to preserve spacing.
Among the benefits of formatting: you can indent to show the extent of blocks, such as BEGIN-END.
Different types of blocks need modifiers after the end, such as "END *IF* " and " END *LOOP* ". If each opening statement (BEGIN, IF, LOOP) is directly above its corresponding END, then it's easy to check if you got the right modifier.
Here's what you code looks like with some formatting, and a couple of corrections added. Look for -- comments.
CREATE OR REPLACE
PROCEDURE fib_dead_cnx_cleanup
AS
     l_serial     CHAR(100);
     l_sid          CHAR (100);
     l_sid_serial     CHAR(100);
     l_count          NUMBER(10,0);
     CURSOR session_cur IS
            SELECT  sid
            ,       serial#
            ,       sid     || ','
                                  || serial#     as sid_serial
            FROM     v$session
            WHERE      username     = 'EBBFCAT'
            and     schemaname     = 'TESTSCHEMA'
            and     status          = 'INACTIVE';          -- need semicolon here
BEGIN
     BEGIN                                   -- Why?
          l_count := 0;
          OPEN session_cur;
          WHILE ( 1 = 1)
          LOOP
                BEGIN                         -- Why?
                     FETCH  session_cur
                     INTO   l_sid
                     ,          l_serial
                     ,          l_sid_serial ;
                           EXIT WHEN session_cur%NOTFOUND ;
                     BEGIN                    -- Why?
                         alter system kill session 'l_sid_serial' ;    -- Not a PL/SQL command
                           END;
                      END;
            END LOOP;                         -- LOOP ends with END LOOP
            CLOSE session_cur;
        END;
END      FIB_DEAD_CNX_CLEANUP;Take baby steps.
I've been wrtiing PL/SQL for 20 years, and I would never write that much code at once. If you're a beginner, all the more reason to start small. Write as little as possible, test, debug and test again (if necessary). When you have someting working, add 2 or 3 more lines and test again.
It looks like you have three BEGIN statements that don't serve any purpose. You should get rid of them (and their corresponding END statements, of course).
One error I did not fix: ALTER SYSTEM is not a PL/SQL statement. It's a SQL statement. You can run a SQL statement inside PL/SQL by using dynamic SQL, where you construct a string containing the SQL statement, and then use dbms_sql or EXECUTE IMMEDIATE to run it.
Edited by: Frank Kulash on Aug 18, 2009 12:37 PM