Please validate my logic performance point of view:

Question

Please validate my logic performance point of view:
logic I wrote :
   LOOP AT i_mara INTO wa_mara.
*-----For material description, go to makt table.
      SELECT SINGLE maktx
        FROM makt
        INTO l_maktx
       WHERE matnr = lwa_mara-matnr
         AND SPRAS = 'E'.
      IF sy-subrc = 0.
        wa_mara-MAKTX = l_maktx.
      ENDIF.        " IF sy-subrc = 0.
*-----For Recurring Inspection, go to marc table.
      SELECT prfrq
        FROM marc
        INTO l_prfrq
        UP TO 1 ROWS
       WHERE matnr = lwa_mara-matnr.
      ENDSELECT.
      IF sy-subrc = 0.
        wa_mara-prfrq = l_prfrq.
      ENDIF.          " IF sy-subrc = 0.
      MODIFY TABLE i_mara FROM wa_mara
             TRANSPORTING maktx.
      CLEAR : wa_mara.
   ENDLOOP.   " LOOP AT i_mara INTO wa_mara.
Or is it better below : ?
To SELECT all the maktx values from makt and all prfrq values from marc
in two internal tables and
Loop at i_mara.
  LOOP at all maktx itab
and pass corresponding maktx values into i_mara table
and pass corresponding prfrq values into i_mara table
ENDLOOP.
OR
is there any better performance logic you suggest ?
THANKS IN ADVANCE.

Answer 1

ok this is very funny so if someone gets a good way to code he should wait till he gets 1198 points till he write a performance wiki
so that means ppl who has high SDN points only can write wiki
for your information wiki definition is
[http://en.wikipedia.org/wiki/Wiki |http://en.wikipedia.org/wiki/Wiki]
its all about contribution and sharing.
did you try that code on a production or a Quality server. If you did you wont say that coz the results i have shown in that blog is what i my self tested on a Quality system of our client.
and for your information i did my internship at a SAP AFS consultancy firm and i created the account at that time. I have joined that company and now working as a developer over there.
if you have worked on a client system development on SD and MM you will know that most of the time
we use header and item tables like
likp,lips
vbak,vbap
vbrk,vbrp
most of the time we come across nested loops with smiler kind of condition.
in this Q he has MATNR as reference.
if you see it properly you can see both tables are sorted.
and the select statement is for all entries.
for your information there can be a delivery document item with out a header if you are aware of DB concepts in that case there will be a foreign key error.
ok lets think about a situation like that even in that case if there ant any header data then simply the client wont request for that record.( you would know if you have worked with clients )
last but not least i dont care about my points rate at SDN i just wanted to share what i know coz anyway i have a very good job here. dont try to put down ppl just because they are new.
Thomas Zloch  : i never told its my code i saw it some where then i checked and i bogged it so that i can get it when i want and i saw it in se30 ( its not se38 ) but i know most of ABAP developers dont check it much so i just wanted to help.
Rui Pedro Dantas   : ya your correct we dont need to use it most of the time since sorted table is easy but there are programs which works with bulky data load we can use it in places like that. Thanks for talking the truth
Nafran
sorry if i said anything to hurt anyone.