PLSQL for a search form -- based off of the issue tracker tutorial

Question

Here is the basic query that returns the results that I need: (works in toad)
SELECT i.id,
i.date_modified,
i.last_name,
i.first_name,
i.email_address,
i.job_title,
c.br_disc as branch,
d.loc_num as branch_num,
i.change_agent,
i.super_name as supervisor
FROM SAP_USER_INFO i,
SAP_BRANCH_LOCATION c,
SAP_BRANCH_LOC_NUM d
WHERE
i.branch_name = c.ID
and
d.loc_num = 1444
Now here is my plsql:
DECLARE
q VARCHAR2(32767); -- query
w VARCHAR2(4000) ; -- where clause
we VARCHAR2(1) := 'N'; -- identifies if where clause exists
BEGIN
q := 'select "i"."ID", '||
' "i"."LAST_NAME", '||
' "i"."FIRST_NAME", '||
' "i"."ORGANIZATION", '||
' "i"."JOB_TITLE", '||
' "i"."SUPER_NAME" as supervisor, '||
' "i"."SUPER_EMAIL", '||
' "i"."BRANCH_NAME" as BRANCH_NAME, '||
' "c"."BR_DISC" as "BRANCH", '||
' "d"."LOC_NUM" as "BRANCH_NUMBER" '||
' FROM "#OWNER#"."SAP_USER_INFO" "i", '||
' "#OWNER#"."SAP_BRANCH_LOCATION" "c", '||
' "#OWNER#"."SAP_BRANCH_LOC_NUM" "d" ';
IF :P19_AGENT_NAME != '-1'
THEN
w := ' CHANGE_AGENT = :P19_AGENT_NAME ' ;
we := 'Y';
END IF;
IF :P19_BRANCH_NUMBER != '-1'
THEN
IF we = 'Y'
THEN
w := w || ' AND BRANCH_NUMBER = :P19_BRANCH_NUMBER AND BRANCH_NAME = "c"."id" ';
ELSE
w := ' BRANCH_NAME = c.id AND BRANCH_NUMBER = :P19_BRANCH_NUMBER';
we := 'Y';
END IF;
END IF;
IF we = 'Y'
THEN q := q || ' WHERE '|| w;
END IF;
RETURN q;
END;
Please forgive me as I'm very new to plsql. I keep getting errors on the where clause. Does anyone see a formatting problem jump out at them?
failed to parse SQL query:
ORA-00904: "c"."id": invalid identifier

Answer 1

Larry,
Thanks for the reply. That seemed to work but I have found that my query is not doing what i thought that it would. So i've included a sub select. Do you know off the top of your head how I should handle a "(". If you look at this line:
' FROM ( SELECT "i"."id", '||
I don't know if I need to handle that ( in a diffrent way.
This is what I'm at now:
DECLARE
q VARCHAR2(32767); -- query
w VARCHAR2(4000) ; -- where clause
we VARCHAR2(1) := 'N'; -- identifies if where clause exists
BEGIN
q := 'SELECT "id", '||
' "date_modified", '||
' "last_name", '||
' "first_name", '||
' "email_address", '||
' "job_title", '||
' "branch", '||
' "branch_num", '||
' "supervisor" '||
' FROM ( SELECT "i"."id", '||
' "i"."date_modified", '||
' "i"."last_name", '||
' "i"."first_name", '||
' "i"."email_address", '||
' "i"."job_title", '||
' "c"."BR_DISC" as "branch", '||
' "d"."LOC_NUM" as "branch_num", '||
' "i"."super_name" as "supervisor" '||
' FROM "SAP_USER_INFO" "i", '||
' "SAP_BRANCH_LOCATION" "c", '||
' "SAP_BRANCH_LOC_NUM" "d" '||
' WHERE "i"."BRANCH_NAME" = "c"."ID" '||
' AND "i"."BRANCH_NUMBER" = "d"."ID" ) ';
IF :P20_AGENT_NAME != '-1'
THEN
w := ' CHANGE_AGENT = :P20_AGENT_NAME ' ;
we := 'Y';
END IF;
IF :P20_BRANCH_NUMBER != '-1'
THEN
IF we = 'Y'
THEN
w := w || ' AND "d"."LOC_NUM" = :P20_BRANCH_NUMBER ';
ELSE
w := ' "d"."LOC_NUM" = :P20_BRANCH_NUMBER AND "i"."BRANCH_NAME" = "c"."ID"';
we := 'Y';
END IF;
END IF;
IF we = 'Y'
THEN q := q || ' WHERE '|| w;
END IF;
RETURN q;
END;
The Error that returns is:
1 error has occurred
Query cannot be parsed within the Builder. If you believe your query is syntactically correct, check the ''generic columns'' checkbox below the region source to proceed without parsing. ORA-00904: "i"."super_name": invalid identifier
Message was edited by:
Mike.R