Poor Extraction - ABAP Code

Question

Hi SDNers
We have a performance problem in our BW system which is due to poor extraction: 300,000 records take about 4 hours to extract.  I have traced this and found that a SELECT SINGLE statement is used in LOOP-ENDLOOP construction and when a record is found, it is processed in around 10ms (which seems fairly OK).  However, when a record isn't found, the access takes upwards of 200ms and sometimes as much as 11 seconds!  Long accesses also occasionally take hundreds of milliseconds, even when a record was found.
From an SQL point of view, the stats are up-to-date and the access is supported by a fully qualified and appropriate secondary index therefore, I wondered if the following code could be improved.  Should we be SELECTing SINGLE within a loop?  Here's the code:-
loop at DATA_PACKAGE.
    move-corresponding DATA_PACKAGE to itab.
      Select SINGLE AC_DOC_NO from /BI0/AFIAR_O0300
      into zAC_DOC_NUM
       where COMP_CODE = DATA_PACKAGE-COMP_CODE
          AND ORG_DOC_NO = DATA_PACKAGE-BILL_NUM
          AND FI_AWTYP = 'VBRK'.
     IF SY-SUBRC = 0.
    DATA_PACKAGE-BILL_NUM = zAC_DOC_NUM.
     append itab.
     ELSE.
     DELETE DATA_PACKAGE.
     ENDIF.
endloop.
As you may have guessed, I'm not an ABAPer!
Thanks for the help guys!!!
Des

Answer 1

Hi,
you should do the following:
data: it_ods type hashed table of /bi0/afiar_o0300
with unique key comp_code org_doc_no fi_awtyp,
wa_ods type /bi0/afiar_o0300.
may be you need to define the table with non unique key.
select * into table it_ods
from /bi0afiar_o0300 for all entries in data_package
where COMP_CODE = DATA_PACKAGE-COMP_CODE
AND ORG_DOC_NO = DATA_PACKAGE-BILL_NUM
AND FI_AWTYP = 'VBRK'.
loop at DATA_PACKAGE.
move-corresponding DATA_PACKAGE to itab.
Instead of your select.
*Select SINGLE AC_DOC_NO from /BI0/AFIAR_O0300
*into zAC_DOC_NUM
*where COMP_CODE = DATA_PACKAGE-COMP_CODE
*AND ORG_DOC_NO = DATA_PACKAGE-BILL_NUM
*AND FI_AWTYP = 'VBRK'.
read table it_ods into wa_ods
with table key comp_code = data_package-comp_code
org_doc_no = data_package-bill_num
fi_awtyp = 'VBRK'.
IF SY-SUBRC = 0.
DATA_PACKAGE-BILL_NUM = zAC_DOC_NUM.
append itab.
ELSE.
DELETE DATA_PACKAGE.
ENDIF.
endloop.
Additionally make sure that there is an index on comp_code, org_doc_no and fi_awtyp on your ods.
regards
Siggi