Primary Key Issue With Creating Tables

Question

Hi,
I have the following scripts to create my two tables in oracle 10g, i was wondering wether or not i had correctly set up my primary key or if there is a better way of doing it than the way i have.
Here are my two scripts for my tables:
CREATE TABLE CUSTOMER (
fname varchar2(15) NOT NULL,
lname varchar2(20) NOT NULL,
age varchar2(3) NOT NULL,
custAreaCode number(5) NOT NULL,
custNumber number(6) NOT NULL,
constraint cust_pk PRIMARY KEY (custAreaCode),
constraint cust_pk2 PRIMARY KEY (custNumber),
constraint age_chk CHECK (age >=18 AND age <150)
CREATE TABLE PHONECALL (
startDateTime smalldatetime NOT NULL,
custAreaCode number(5) NOT NULL, ---Reference PK From Customer Table
custNumber number(6) NOT NULL, ---Reference PK From Customer Table
dialledAreaCode number(5) NOT NULL,
dialledNumber number(6) NOT NULL,
crgPerMinute number number (3,1) NOT NULL,
endDateTime smalldatetime NOT NULL));
I am not sure if i have referenced the primary keys correctly in the PHONECALL table.
Thanks in advance :)

Answer 1

Hi,
You want like this below ? I think that smalltime data type is not a valid type. Other thing, this is not a rule, but I advice you to put the primary key columns as the first columns of your table. One question: There is no PK on the phonecall table ?
SGMS@ORACLE10> create table customer (
  2  custareacode number(5) not null,
  3  custnumber number(6) not null,
  4  fname varchar2(15) not null,
  5  lname varchar2(20) not null,
  6  age varchar2(3) not null,
  7  constraint cust_pk primary key (custareacode),
  8  constraint cust_uk unique (custnumber),
  9  constraint age_chk check (age >=18 and age <150)
10  );
Table created.
SGMS@ORACLE10> create table phonecall (
  2  custareacode number(5) not null constraint fk_phone_cusarecode_customer references customer,
  3  custnumber number(6) not null constraint fk_phone_custnumber_customer references customer,
  4  startdatetime date not null,
  5  dialledareacode number(5) not null,
  6  diallednumber number(6) not null,
  7  crgperminute number (3,1) not null,
  8  enddatetime date not null);
Table created.
SGMS@ORACLE10> select table_name,constraint_name,constraint_type from user_constraints
2 where table_name in ('CUSTOMER','PHONECALL') and constraint_type in ('P','U','R');
TABLE_NAME                     CONSTRAINT_NAME                C
CUSTOMER                       CUST_PK                        P
CUSTOMER                       CUST_UK                        U
PHONECALL                      FK_PHONE_CUSARECODE_CUSTOMER   R
PHONECALL                      FK_PHONE_CUSTNUMBER_CUSTOMER   RCheers