Problem about inserting records ? ?

Question

hello ,
i want to insert record in table abc which have 3 column
i want to insert 2 values from xyz table and one values is from variable
i write following query
vMYQUERY :='INSERT INTO abc(NO, TYPE, SUB_TRAN) SELECT '||vSR_NO||',TYPE,SUB_TRAN FROM xyz ;
EXECUTE IMMEDIATE vMYQUERY;
is it correct ?
pankaj

Answer 1

Did it work?
You could try the USING clause;
SQL> create table abc(NO number, TYPE varchar2(10), SUB_TRAN varchar2(10))
Table created.
SQL> create table xyz(NO number, TYPE varchar2(10), SUB_TRAN varchar2(10))
Table created.
SQL> insert into xyz values(0,' col1', 'col2')
PL/SQL executed.
SQL> declare
   vmyquery varchar2(100);
   vsr_no number := 99;
begin
   vmyquery :='INSERT INTO abc(NO, TYPE, SUB_TRAN) SELECT :1,TYPE,SUB_TRAN FROM xyz' ;
   EXECUTE IMMEDIATE vmyquery USING vsr_no;
end;
PL/SQL procedure successfully completed.
SQL> select * from abc
        NO TYPE       SUB_TRAN 
        99  col1      col2     
1 row selected.