Problem for drawimage

Question

i want to draw a image random and they are not stick together but i try that code it only have one image show up.how to do draw a image and they are not stick together too?
and i have one more question how to make a image stand on other image . because i want to make a person walk on a floor.
import java.awt.*;
import java.awt.event.*;
import java.awt.geom.Ellipse2D;
import java.awt.image.BufferedImage;
import javax.swing.*;
import javax.swing.event.*;
public class Downstair  {
    Playscreen graphicComponent;
    JPanel centerPanel;
    private JPanel getCenterPanel() {
        graphicComponent = new Playscreen();
        CardLayout cards = new CardLayout();
        centerPanel = new JPanel(cards);
        centerPanel.add("Menu", getMenuPanel());
        centerPanel.add("Game", graphicComponent);
        return centerPanel;
    private JPanel getMenuPanel() {
        // Create components.
        String[] gameMenulist = {"New Game","Abouts","how to play","Options","Exit"};
        JList menulist= new JList(gameMenulist);
        ListSelectionModel menulistModel = menulist.getSelectionModel();
        //menulist setting
        menulist.setLayoutOrientation(JList.HORIZONTAL_WRAP);
        menulist.setVisibleRowCount(-1);
        menulist.setBackground(Color.BLACK);
        menulist.setForeground(Color.WHITE);
        menulist.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
        menulist.addListSelectionListener(new ListListener());
        JPanel panel = new JPanel() {
            Image bg = new ImageIcon("image/bgimg.jpg").getImage();
            protected void paintComponent(Graphics g) {
                super.paintComponent(g);
                g.drawImage(bg, 0, 0, this);
        panel.setBackground(Color.white);
        panel.setOpaque(true);  // default value
        panel.setLayout(new GridBagLayout());
        GridBagConstraints a = new GridBagConstraints();
        // The anchor constraint requires a non-zero weight
        // constraint in the direction it is going, ie,
        // weightx for horizontal values such as EAST,
        // WEST, LINE_START, LINE_END.
        a.anchor = GridBagConstraints.PAGE_END;
        panel.add(menulist, a);
        return panel;
    public static void main(String[] args) {
        Downstair app = new Downstair();
        JFrame mainframe = new JFrame();
        mainframe.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        mainframe.getContentPane().add(app.getCenterPanel());
        mainframe.setSize(600, 600);
        mainframe.setVisible(true);
    private class ListListener implements ListSelectionListener {
        public void valueChanged(ListSelectionEvent e) {
            if(!e.getValueIsAdjusting()) {
                JList list = (JList)e.getSource();
                int index = list.getSelectedIndex();
                switch(index) {
                    case 0:
                        CardLayout cards = (CardLayout)centerPanel.getLayout();
                        cards.show(centerPanel, "Game");
                        break;
                    case 4:
                        System.exit(0);
                        break;
                    default:
                        System.out.println("unexpected type: " + index);
class Playscreen extends JPanel {
     ImageIcon playbg;
     ImageIcon playerIcon;
     ImageIcon[] stair;
     int floor;
     int live;
     int randomX;
     int randomY;
     int randompic;
     public Playscreen(){
          playbg = new ImageIcon("image/bgimg.jpg");
          playerIcon = new ImageIcon("image/ball.gif")[10];
          stair = new ImageIcon("image/stair.jpg");
          randomX = (int)( ( Math.random() * 400 ) + 1 );
          randomY = (int)( ( Math.random() * 400 ) + 1 );
          randompic = (int)( ( Math.random() * 10 ) + 10 );
          setBackground(Color.white);
          setOpaque(true);
     protected void paintComponent(Graphics g) {
          super.paintComponent(g);
          g.drawImage(playbg.getImage(), 0, 0, this);
          for(int numpic= 0; numpic < 10 ; numpic++){
               g.drawImage(playerIcon.getImage(), randomX, randomY, this);
}Message was edited by:
nickgoldgodl

Answer 1

fileNames = new String[20];
20 images is a lot for this small space.
Recall one of comments from reply 5:
About the method setRects: If there are too many rectangles or if they are too big
or if the graphic component is too small this method may not be able to find a legal
location for one of the rectangles.
What this means is this: if an acceptable location cannot be found for any of the rects
(which are used to place the images) your app will freeze while setRect goes on in an
infinite loop.
import java.awt.*;
import java.awt.event.*;
import java.util.Random;
import javax.swing.*;
import javax.swing.event.*;
public class Downstair  {
    Playscreen playScreen;
    Pseudo pseudo;
    JPanel rightPanel;
    private JPanel getCenterPanel() {
        // Instantiate components.
        playScreen = new Playscreen();
        pseudo = new Pseudo();
        // Layout right panel.
        rightPanel = new JPanel(new CardLayout());
        rightPanel.add("Menu", getMenuPanel());
        rightPanel.add("Game", playScreen);
        // Layout center panel.
        JPanel centerPanel = new JPanel(new BorderLayout());
        centerPanel.add(pseudo,     BorderLayout.LINE_START);
        centerPanel.add(rightPanel, BorderLayout.CENTER);
        return centerPanel;
    private JPanel getMenuPanel() {
        // Create components.
        String[] gameMenulist = {"New Game","Abouts","how to play","Options","Exit"};
        JList menulist= new JList(gameMenulist);
        ListSelectionModel menulistModel = menulist.getSelectionModel();
        //menulist setting
        menulist.setLayoutOrientation(JList.HORIZONTAL_WRAP);
        menulist.setVisibleRowCount(-1);
        menulist.setBackground(Color.BLACK);
        menulist.setForeground(Color.WHITE);
        menulist.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
        menulist.addListSelectionListener(new ListListener());
        JPanel panel = new JPanel() {
            Image bg = new ImageIcon(//"image/bgimg.jpg").getImage();
                                     "images/geek-----.gif").getImage();
            protected void paintComponent(Graphics g) {
                super.paintComponent(g);
                g.drawImage(bg, 0, 0, this);
        panel.setBackground(Color.white);
        panel.setOpaque(true);
        panel.setLayout(new GridBagLayout());
        GridBagConstraints a = new GridBagConstraints();
        a.anchor = GridBagConstraints.PAGE_END;
        panel.add(menulist, a);
        return panel;
    public static void main(String[] args) {
        Downstair app = new Downstair();
        JFrame mainframe = new JFrame();
        mainframe.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        mainframe.getContentPane().add(app.getCenterPanel());
//        mainframe.setSize(600, 600);
        mainframe.pack();
        mainframe.setVisible(true);
    private class ListListener implements ListSelectionListener {
        public void valueChanged(ListSelectionEvent e) {
            if(!e.getValueIsAdjusting()) {
                JList list = (JList)e.getSource();
                int index = list.getSelectedIndex();
                switch(index) {
                    case 0:
                        CardLayout cards = (CardLayout)rightPanel.getLayout();
                        cards.show(rightPanel, "Game");
                        break;
                    case 4:
                        System.exit(0);
                        break;
                    default:
                        System.out.println("unexpected type: " + index);
class Playscreen extends JPanel {
     ImageIcon playbg;
     ImageIcon playerIcon;
     ImageIcon[] stair;
     int floor;
     int live;
     Point loc = new Point(100,100);
     int dx = 3;
         int dy = 3;
     Rectangle[] rects;
     Random seed = new Random();
     String[] fileNames;
     boolean firstTime = true;
     public Playscreen(){
          String img = //"stair.jpg";
                         "../images/geek-----.gif";
          fileNames = new String[5];
          playbg = new ImageIcon(//"image/bgimg.jpg");
                                   "../images/Bird.gif");
          playerIcon = new ImageIcon(//"image/player.gif");            
                                       "../images/Cat.gif");
          setBackground(Color.white);
          setOpaque(true);
          registerKeys();
          setFocusable(true);
          for(int f = 0; f < fileNames.length; f++){
               fileNames[f] = img;
          rects = new Rectangle[fileNames.length];
          stair = new ImageIcon[fileNames.length];
          for(int j = 0; j < rects.length; j++) {
                 stair[j] = new ImageIcon(//"Image/" + fileNames[j]);
                                           "../images/" + fileNames[j]);
                 rects[j] = new Rectangle(stair[j].getIconWidth(),
                                           stair[j].getIconHeight());
     protected void paintComponent(Graphics g) {
          super.paintComponent(g);
          g.drawImage(playbg.getImage(), 0, 0, this);
          g.drawImage(playerIcon.getImage(), loc.x, loc.y, this);
          if(firstTime) {
                 setRects();
                 firstTime = false;
          for(int j = 0; j < stair.length; j++) {
                     g.drawImage(stair[j].getImage(), rects[j].x, rects[j].y, this);
    public Dimension getPreferredSize() {
        return new Dimension(600,500);
     private void setRects() {
             Point p;
            int count = 0;
             for(int j = 0; j < rects.length; j++) {
                 do {
                         p = getRandomLocationFor(rects[j]);
                          rects[j].setLocation(p);
                        System.out.println("count for " + j + " = " + count++);
                     } while(!notTouching(j));
         private boolean notTouching(int index) {
            for(int j = 0; j < index; j++) {
                 if(rects[j].intersects(rects[index]))
                      return false;
             return true;
     private Point getRandomLocationFor(Rectangle r) {
             Point p = new Point();
             p.x = seed.nextInt(getWidth()  - r.width );
             p.y = seed.nextInt(getHeight() - r.height);
             return p;
     private void registerKeys() {
             int c = JComponent.WHEN_IN_FOCUSED_WINDOW;
             getInputMap(c).put(KeyStroke.getKeyStroke("UP"), "UP");
             getActionMap().put("UP", upAction);
             getInputMap(c).put(KeyStroke.getKeyStroke("LEFT"), "LEFT");
             getActionMap().put("LEFT", leftAction);
            getInputMap(c).put(KeyStroke.getKeyStroke("DOWN"), "DOWN");
             getActionMap().put("DOWN", downAction);
             getInputMap(c).put(KeyStroke.getKeyStroke("RIGHT"), "RIGHT");
             getActionMap().put("RIGHT", rightAction);
     private Action upAction = new AbstractAction() {
             public void actionPerformed(ActionEvent e) {
         private Action leftAction = new AbstractAction() {
                 public void actionPerformed(ActionEvent e) {
                      loc.x -= dx;
                      repaint();
         private Action downAction = new AbstractAction() {
             public void actionPerformed(ActionEvent e) {
         private Action rightAction = new AbstractAction() {
             public void actionPerformed(ActionEvent e) {
                      loc.x += dx;
                      repaint();
class Pseudo extends JPanel {
    JButton ok = new JButton("Okay");
    public Pseudo() {
        setLayout(new GridBagLayout());
        GridBagConstraints gbc = new GridBagConstraints();
        gbc.gridwidth = GridBagConstraints.REMAINDER;
        add(new JLabel("Pseudo Panel", JLabel.CENTER), gbc);
        gbc.weighty = 1.0;
        add(ok, gbc);
        setBorder(BorderFactory.createLineBorder(Color.red));
    public Dimension getPreferredSize() {
        return new Dimension(200,100);
}