Problem in creating function and it is too much urgent!!

Question

I am a new to Oracle function,
And i am facing the following problem,plz make reply.......
CREATE OR REPLACE FUNCTION
get_working_period(JOINING_DATE IN DATE,EMPLOYEE_ID IN VARCHAR2)
RETURN date is
STATUS date;
ID varchar2(10);
PSTATUS DATE;
BEGIN
Select JOINING_DATE
into STATUS
from EMPLOYEE
where ID=EMPLOYEE_ID;
IF STATUS<SYSDATE
THEN
PSTATUS:=(SYSDATE-STATUS);[Problem is here,is it correct or any other way,plz reply]     
END IF;     
RETURN PSTATUS;
END get_working_period;
Regards --
Mamun

Answer 1

[Problem is here,is it correct or any other way,plz reply] One thing I hate is looking at other people's code and trying to understand what they mean. Particularly when its author is "a new to Oracle function" and so I can't rely on them understanding the conventions. It would be nice if people just told us what their code was supposed to do.
From the name of the function - get_working_period - I presume your trying to derive the number of days the given employee has been working for the company. The clue there is number of days. That's a numeric data type not a date. So PSTATUS ought to be a NUMBER and your function ought to return a NUMBER.
Cheers, APC
Blog : http://radiofreetooting.blogspot.com/