Problem with downloading a PDF file from a webserver run on Linux

Question

Hi,
I've written a simple functionality that manages file attachments.
Everything works fine (attaching, downloading, deleting) when the webserver runs on Windows.
However when I deployed the code to the Resin webserver run on Linux and use the Win browser to connect to the app, the downloading of PDF file doesn't work (uploading and downloading of txt, doc, xls, jpg files is OK).
The downloaded PDF file is almost twice as big as original (~28KB when original is ~12KB) and it can't be open.
I guess it is the problem of writing to the output stream of HttpServletResponse but I can't localize the problem.
Here is the code I use for downloading file:
private boolean downloadFile(HttpServletResponse response, String filePath,
               String originalFilename) {
     File file = new File(filePath);
     String contentType = URLConnection
               .guessContentTypeFromName(originalFilename);
     // If the content type is unknown set the default value.
     if (contentType == null) {
          contentType = "application/octet-stream";
     BufferedInputStream input = null;
     BufferedOutputStream output = null;
     try {
          input = new BufferedInputStream(new FileInputStream(file));
          int contentLength = input.available();
          response.reset();
          response.setContentLength(contentLength);
          response.setContentType(contentType);
          response.setHeader("Content-disposition", "attachment; 
                       filename=\""+ originalFilename + "\"");
            output = new BufferedOutputStream(response.getOutputStream());
          int bufSize = 10000;
          byte[] buf = new byte[bufSize];
          int bytesNo = 0;               
          while ((bytesNo = input.read(buf, 0, bufSize)) != -1) {
               output.write(buf, 0, bytesNo);
          output.flush();
          input.close();
          output.close();
     } catch (IOException e) {
          log.debug(e.getMessage());
          e.printStackTrace();
}Can you point any problem?
Thanks in advance,
Ala

Answer 1

matali wrote:
          int bufSize = 10000;
          byte[] buf = new byte[bufSize];
          int bytesNo = 0;               
          while ((bytesNo = input.read(buf, 0, bufSize)) != -1) {
               output.write(buf, 0, bytesNo);
This piece is completely wrong and doesn't work for files bigger than 10000 bytes. Replace it by
byte[] buffer = new byte[10240]; // 10KB exactly.
int length = 0;
while ((length = input.read(buffer)) > 0) { // Read next 10KB of input to buffer.
    output.write(buffer, 0, length); // Write specified length of buffer to output.
}Or just use output.write(input.read()) in a loop of the contentLength as you're alredy using BufferedInputStream/BufferedOutputStream.
Another thing, the method is declared to return a boolean, but it actually doesn't? I would just let it throw an exception in case of failure instead of returning a boolean and let the calling method handle the exception.