Procedure creation error..help required .

Question

Hai
I have created the procedure like this.
The work of this procedure is to update the
progress and calculate the percentage of completion.
I have marked the problem part down.
The problem is ..
there can be n number of planfields in a single SP.
and each planfield can contain n number of index and each index can contain n number of ids.
I need to check for a particular SP, whether all indexes and ids are completed.
if completed, i am talking a value of completion for other table.
After checking thru the loop..
I am calculating the completion percent.
Here the first cursor return the SP
and for that SP i need to open a cursor for index count.
Can anyone suggest me how to solve this problem.
CREATE OR REPLACE PROCEDURE "P_PROGRESS" (lDate IN DATE) IS
P_SCOPE varchar2(12);
PR_SCOPE VARCHAR2(12);
P_VALUE NUMBER(12);
TC_VALUE NUMBER(12);
TR_VALUE NUMBER(12);
P3_VALUE NUMBER(12);
FQA_VALUE NUMBER(12);
P1_VALUE NUMBER(12);
P2_VALUE NUMBER(12);
counter number(10);
FQ_VALUE VARCHAR2(12);
F_VALUE VARCHAR2(12);
DU_DATE DATE;
SP VARCHAR2(20);
pr_counter number(12);
dsm_counter number(12);
pre_value number(12);
P_H_VALUE NUMBER(12);
P_O_VALUE NUMBER(12);
P_SPNO NUMBER(10);
CURSOR CUR_SPNO IS
SELECT DISTINCT SPNO FROM V_PRODUCTION_INFO;
/*Problem part*/
CURSOR CUR_OBJ(P_SNO NUMBER) IS
SELECT DISTINCT SPNO,PLANFIELD,PLANINDEX FROM V_PRODUCTION_INFO WHERE SPNO = P_SNO;
BEGIN
OPEN CUR_SPNO;
SELECT COUNT(1) INTO COUNTER FROM PRODUCTION_STATUS WHERE
TO_CHAR(PRODN_DATE,'DD-MON-YYYY') = ldate;
IF COUNTER > 0 THEN
DELETE FROM PRODUCTION_STATUS WHERE PRODN_DATE = ldate;
END IF;
P_H_VALUE :=0;
P1_VALUE := 0;
P2_VALUE := 0;
P_O_VALUE := 0;
LOOP
FETCH CUR_SPNO INTO SP;
EXIT WHEN CUR_SPNO%NOTFOUND;
Problem Part
FOR P_SPNO IN CUR_OBJ(SP)
LOOP
SELECT DISTINCT STATUS into pre_counter FROM BEWAG_WORKALLOCATION WHERE SPEISEGEB_NR=CUR_OBJ.SPNO AND PF_PLANFELDNUMMER =CUR_OBJ.PLANFIELD AND PLANFELDINDEX = CUR_OBJ.PLANINDEX AND STATUS = 'CLOSED' AND ITEM_CODE = '355' AND UNIT = 'PI' ORDER BY STATUS;
IF STATUS = 'CLOSED' THEN
SELECT SCOPE INTO P1_VALUE FROM V_PRE_PRODUCTION_SCOPE WHERE STAGE ='PREHV';
END IF;
P_H_VALUE := P_H_VALUE + P1_VALUE;
SELECT COUNT(DISTINCT WORKAREA) into pre_counter FROM BEWAG_WORKALLOCATION WHERE SPEISEGEB_NR=CUR_OBJ.SPNO AND PF_PLANFELDNUMMER =CUR_OBJ.PLANFIELD AND PLANFELDINDEX = CUR_OBJ.PLANINDEX AND STATUS = 'CLOSED' AND ITEM_CODE = '365' AND UNIT='OBJ';
select count(distinct o.objectid) into dsm_counter from pfidx c,comp_2300 o where planfeldnummer = cur_sp.planfield
and planfeldindex = CUR_OBJ.PLANINDEX and not (c.xro_koo * 10000 < o.xlow or c.xlu_koo * 10000 > o.xhigh or c.yro_koo * 10000 < o.ylow or c.ylu_koo * 10000 > o.yhigh) order by o.objectid;
if pre_counter = dsm_counter then
     SELECT DISTINCT STATUS into pre_counter FROM BEWAG_WORKALLOCATION WHERE SPEISEGEB_NR=CUR_OBJ.SPNO AND PF_PLANFELDNUMMER =CUR_OBJ.PLANFIELD AND PLANFELDINDEX = CUR_OBJ.PLANINDEX AND STATUS = 'CLOSED' AND ITEM_CODE = '355' AND UNIT = 'PI' ORDER BY STATUS;
     IF STATUS = 'CLOSED' THEN
     SELECT SCOPE INTO P2_VALUE FROM V_PRE_PRODUCTION_SCOPE WHERE STAGE ='PREOV';
     END IF;
     P_O_VALUE := P_O_VALUE + P2_VALUE;
end if;
END LOOP;
CLOSE CUR_OBJ;
P_VALUE := P_H_VALUE + P_O_VALUE;
Problem Part ends here
SELECT MAX(SCOPE) INTO P_SCOPE FROM V_PRODUCTION_SCOPE WHERE SPNO = SP AND PROCESS ='Phase II';
IF P_SCOPE IS NOT NULL and P_SCOPE <> 'null' AND P_SCOPE <> '0' THEN
SELECT NVL(ROUND(NVL(P_VALUE/P_SCOPE) / P_SCOPE*100,2),0) INTO P_VALUE FROM DUAL;
END IF;
SELECT MAX(SCOPE) INTO P_SCOPE FROM V_PRODUCTION_SCOPE WHERE SPNO = SP AND PROCESS ='Phase II';
IF P_SCOPE IS NOT NULL and P_SCOPE <> 'null' AND P_SCOPE <> '0' THEN
PR_SCOPE := P_SCOPE;
SELECT NVL(ROUND((NVL(SUM(ACHIEVED),0) / P_SCOPE) * 100,2),0) INTO TC_VALUE FROM V_PRODUCTION_INFO WHERE SPNO = SP AND STAGE = 'Template Creation' AND TO_CHAR(ACT_DATE,'DD-MON-YYYY') <= ldate;
SELECT NVL(ROUND((NVL(SUM(ACHIEVED),0) / P_SCOPE) * 100,2),0) INTO TR_VALUE FROM
V_PRODUCTION_INFO WHERE SPNO = SP AND STAGE = 'Trasse' AND TO_CHAR(ACT_DATE,'DD-MON-YYYY') <= ldate;
ELSE
PR_SCOPE := '0';
TC_VALUE := 0;
TR_VALUE := 0;
END IF;
SELECT MAX(SCOPE) INTO P_SCOPE FROM V_PRODUCTION_SCOPE WHERE SPNO = SP AND PROCESS ='Phase III';
IF P_SCOPE IS NOT NULL and P_SCOPE <> 'null' AND P_SCOPE <> '0' THEN
SELECT NVL(ROUND((NVL(SUM(ACHIEVED),0) / P_SCOPE) * 100,2),0) INTO P3_VALUE FROM V_PRODUCTION_INFO WHERE SPNO = SP AND
STAGE = 'Phase III' AND TO_CHAR(ACT_DATE,'DD-MON-YYYY') <= ldate;
ELSE
P3_VALUE := 0;
END IF;
SELECT COUNT(DISTINCT PLANFIELD) INTO FQ_VALUE FROM BEWAG_MASTER WHERE SPNO = SP;
IF FQ_VALUE IS NOT NULL AND FQ_VALUE <> 'null' AND FQ_VALUE <> '0' THEN
SELECT COUNT(DISTINCT PLANFIELD) INTO F_VALUE FROM FQA_ACCEPTANCE WHERE SPNUMBER = SP;
FQA_VALUE := ROUND((F_VALUE / FQ_VALUE) * 100,2);
ELSE
FQA_VALUE := 0;
END IF;
IF SP <> 'null' THEN
SELECT MAX(PLANNED_DATE) INTO DU_DATE FROM SP_COMPLETION_DATE WHERE SPNUMBER = SP;
IF DU_DATE IS NULL THEN
DU_DATE := '';
END IF;
END IF;
INSERT INTO PRODUCTION_STATUS(PRODN_DATE,SPNUMBER,PRODN_SCOPE,PREPRODN_STATUS,TEMPPRODN_STATUS,TRASSEPRODN_STATUS,PIIIPRODN_STATUS,FQAPRODN_STATUS,DUE_DATE) VALUES(ldate,SP,PR_SCOPE,P_VALUE,TC_VALUE,TR_VALUE,P3_VALUE,FQA_VALUE,DU_DATE);
COMMIT;
END LOOP;
CLOSE CUR_SPNO;
END P_Y_PROGRESS;

Answer 1

With all due respect, you're having a laugh if you think we're going to wade through your spaghetti code and not very well explained business requirement. We do this for fun. Having said that, maximum respect to anyone who does have the patience to figure it out.
In the meanwhile, I offer you this possible solution, which being pure SQL is I think easy to understand and doesn't need commenting (unlike some code I could mention).
Cheers, APC
CREATE TABLE x1 (plan_no number, plan_field number, plan_index number
                  , index_id number, status VARCHAR2(10))
INSERT INTO x1 values (1, 1, 1, 1, 'OPEN')
INSERT INTO x1 values (1, 1, 1, 2, 'OPEN')
INSERT INTO x1 values (1, 1, 1, 3, 'OPEN')
INSERT INTO x1 values (1, 1, 1, 4, 'OPEN')
INSERT INTO x1 values (1, 1, 1, 5, 'OPEN')
INSERT INTO x1 values (1, 1, 1, 6, 'OPEN')
INSERT INTO x1 values (1, 1, 2, 1, 'OPEN')
INSERT INTO x1 values (1, 1, 2, 2, 'CLOSED')
INSERT INTO x1 values (1, 1, 2, 3, 'CLOSED')
INSERT INTO x1 values (1, 1, 2, 4, 'CLOSED')
INSERT INTO x1 values (1, 1, 2, 5, 'CLOSED')
INSERT INTO x1 values (1, 3, 1, 1, 'CLOSED')
INSERT INTO x1 values (1, 3, 1, 2, 'CLOSED')
INSERT INTO x1 values (1, 4, 1, 1, 'OPEN')
INSERT INTO x1 values (1, 4, 1, 2, 'CLOSED')
INSERT INTO x1 values (1, 4, 2, 1, 'OPEN')
INSERT INTO x1 values (1, 4, 2, 2, 'CLOSED')
INSERT INTO x1 values (1, 4, 2, 3, 'OPEN')
INSERT INTO x1 values (1, 4, 2, 4, 'CLOSED')
SELECT plan_no, plan_field, plan_index, 100 * (tot_cl/tot_idx) as pct_closed FROM (
SELECT plan_no, plan_field, plan_index, count(*) AS tot_idx, sum(decode(status, 'CLOSED', 1, 0)) AS tot_cl
FROM   x1
GROUP BY plan_no, plan_field, plan_index )
   PLAN_NO PLAN_FIELD PLAN_INDEX PCT_CLOSED
         1          1          1          0
         1          1          2         80
         1          3          1        100
         1          4          1         50
         1          4          2         50
5 rows selected.