Procedure optimization

Question

Hi, I made a oracle procedure which takes 30 mins to get executed, i tried a lot but could optimize it further. Each table used has avg data of 40,000 records, the code which i have written is
CREATE OR REPLACE PROCEDURE ESPF_ABPP.Testingperform AS
routing1 varchar2(140);
val varchar2(40);
routingid varchar2(150);
so_id VARCHAR2(10);
so_line_id VARCHAR2(10);
items varchar2(20);
operationseqn number(10);
ind varchar(20);
operation varchar2(40);
x number;
y number;
z number;
j number;
seq number;
sq number;
len number;
BEGIN
DELETE FROM sridhar_stg_routing_operation;
COMMIT;
FOR c1 IN (SELECT vbeln,
posnr,
routeind,REPLACE(process_path,'--','-') AS process_path
FROM sridhar_STG_ZPP03_PROC_PATH
WHERE process_path IS NOT NULL)
LOOP
operationseqn:=10;
c1.process_path:=c1.process_path||'-';
routing1:=c1.process_path;
ind:=c1.routeind;
so_id:=c1.vbeln;
so_line_id:=c1.posnr;
SELECT NVL(LENGTH(REPLACE(process_path,'--','-'))-LENGTH(REPLACE(REPLACE(process_path,'--','-'),'-',''))+1,0)
INTO j FROM sridhar_stg_zpp03_proc_path t
WHERE vbeln=c1.vbeln
AND posnr=c1.posnr
AND routeind=c1.routeind;
x:=1;
y:=1;
z:=2;
len:=0;
FOR k IN 1..j
LOOP
val:=substr(routing1,x,instr(substr(routing1,x),'-',1)-1);
len:=len+length(substr(routing1,x,instr(substr(routing1,x),'-',1)));
x:=len+1;
SELECT NVL(matnr,'NA') INTO items
FROM sridhar_stg_vbap RIGHT OUTER JOIN dual ON vbeln=so_id AND posnr=so_line_id;
SELECT NVL(operation_name,'NA') INTO operation
FROM sri_ud_workcenter_master_list RIGHT OUTER JOIN dual ON
work_center_name=val;
IF items IS NOT NULL THEN
routingid:=so_id||'-'||TO_CHAR(so_line_id)||'-'||items;
END IF;
IF val IS NOT NULL THEN
INSERT INTO sridhar_STG_ROUTING_OPERATION(routingid,operation,operationseq,workcenter)
VALUES (routingid||'-'||c1.routeind, operation, operationseqn, val);
commit;
END IF;
operationseqn:=operationseqn+10;
END LOOP;
END LOOP;
COMMIT;
FOR c3 IN (SELECT routingid,max(operationseq) op
FROM sridhar_STG_ROUTING_OPERATION
WHERE substr(routingid,1,10) IN (SELECT vbeln
FROM sridhar_stg_vbak
WHERE auart!='01')
GROUP BY routingid)
LOOP
seq:=10;
seq:=seq+c3.op;
INSERT INTO sridhar_STG_ROUTING_OPERATION(routingid,operation,operationseq,workcenter)
VALUES(c3.routingid,'DSPT',seq,'DSPT1');
COMMIT;
END LOOP;
EXCEPTION
WHEN NO_DATA_FOUND THEN
DBMS_OUTPUT.PUT_LINE('No Data Found');
WHEN OTHERS THEN
DBMS_OUTPUT.PUT_LINE('Error Occured'||SQLCODE||'-'||SQLERRM);
ROLLBACK;
END;
can any one help me in this
regards,

Answer 1

>
When you post, use code tags
>
I think you meant to use curly braces and not brackets. So use \ before and after the actual code.
You can get that to display properly without being interpreted by putting a single backslash before the left curly brace.