Help for optimization of procedure

Question

Hi,
I am having following procedure it is accessing LY_RWPT_SUCCESS table having 2501818 records. i want to insert data into LY_RWPT_cap_SUCCESS with following logic but its taking lot of time .
How we can optimize this query to give better result. pls help.
CREATE OR REPLACE PROCEDURE "LY_PRODUCT_CAPPING_old"(P_MONTH VARCHAR2) IS
--v_sum_rewards number
V_SUM_REWARDS integer;
V_FLAG VARCHAR2(1);
V_AMOUNT integer;
V_REWARD NUMBER;
V_REMARKS VARCHAR2(1000);
cursor c1 is
select *
from LY_RWPT_SUCCESS
where as_of_month = P_MONTH
-- and source_account_number ='000101006399'
order by source_account_number asc,
product_code asc,
transaction_id asc,
transaction_date asc;
begin
DELETE FROM LY_RWPT_CAP_SUCCESS WHERE AS_OF_MONTH = P_MONTH;
for i in c1 loop
V_REWARD := I.REWARDS;
/*select nvl(sum(rewards),0) INTO V_SUM_REWARDS from ly_rwpt_cap_success_temp
where as_of_month = P_MONTH
and product_code = I.PRODUCT_CODE
AND SOURCE_ACCOUNT_NUMBER = I.SOURCE_ACCOUNT_NUMBER
and partial_flag in( 'F','P');*/
if V_REWARD != 0 THEN
select nvl(sum(rewards), 0)
INTO V_SUM_REWARDS
from ly_rwpt_cap_success
where as_of_month = P_MONTH
and product_code = I.PRODUCT_CODE
AND SOURCE_ACCOUNT_NUMBER = I.SOURCE_ACCOUNT_NUMBER
and partial_flag in ('F', 'P');
IF (V_SUM_REWARDS >= I.PRODUCT_CAPPING) THEN
V_REMARKS := i.remarks || ' but receiving ' || ' ' || 0 ||
' points as reached to product capping';
-- V_REMARKS := i.PRODUCT_NAME ||'transaction successfully earned'||' ' ||0 ;
V_FLAG := 'N';
INSERT INTO LY_RWPT_CAP_SUCCESS
VALUES
(I.source_account_number,
I.cust_id,
I.customer_status_code,
I.product_code,
I.value,
I.transaction_date,
I.processing_date,
I.balance,
I.eligible_tag,
0,
I.transaction_id,
I.payee_name,
V_REMARKS,
V_FLAG,
I.as_of_month,
I.product_name,
I.product_capping,
I.CUSTOMER_SEGMENT,
I.RD_ACCOUNT_NBR,
I.MEMBER_CUST_ID);
COMMIT;
ELSIF (V_SUM_REWARDS = 0 AND V_REWARD <= I.PRODUCT_CAPPING) THEN
V_REMARKS := I.REMARKS;
--V_REMARKS := i.PRODUCT_NAME ||'transaction successfully earned'||' ' || V_REWARD ;
V_FLAG := 'F';
INSERT INTO LY_RWPT_CAP_SUCCESS
VALUES
(I.source_account_number,
I.cust_id,
I.customer_status_code,
I.product_code,
I.value,
I.transaction_date,
I.processing_date,
I.balance,
I.eligible_tag,
V_REWARD,
I.transaction_id,
I.payee_name,
V_REMARKS,
V_FLAG,
I.as_of_month,
I.product_name,
I.product_capping,
I.CUSTOMER_SEGMENT,
I.RD_ACCOUNT_NBR,
I.MEMBER_CUST_ID
COMMIT;
ELSIF (i.product_capping < (V_SUM_REWARDS + V_REWARD)) then
V_AMOUNT := ABS(I.PRODUCT_CAPPING - V_SUM_REWARDS);
V_REMARKS := i.remarks || ' but earned ' || ' ' || V_AMOUNT ||
' partial points' || ' as exceeding product capping';
-- V_REMARKS := i.PRODUCT_NAME ||'transaction successfully earned'||' ' || V_AMOUNT ;
V_FLAG := 'P';
INSERT INTO LY_RWPT_CAP_SUCCESS
VALUES
(I.source_account_number,
I.cust_id,
I.customer_status_code,
I.product_code,
I.value,
I.transaction_date,
I.processing_date,
I.balance,
I.eligible_tag,
V_AMOUNT,
I.transaction_id,
I.payee_name,
V_REMARKS,
V_FLAG,
I.as_of_month,
I.product_name,
I.product_capping,
I.CUSTOMER_SEGMENT,
I.RD_ACCOUNT_NBR,
I.MEMBER_CUST_ID);
COMMIT;
ELSIF
(i.product_capping >= (V_SUM_REWARDS + V_REWARD)) then
V_REMARKS := I.REMARKS;
-- V_REMARKS := i.PRODUCT_NAME ||'transaction successfully earned'||' ' || V_REWARD ;
V_FLAG := 'F';
INSERT INTO LY_RWPT_CAP_SUCCESS
VALUES
(I.source_account_number,
I.cust_id,
I.customer_status_code,
I.product_code,
I.value,
I.transaction_date,
I.processing_date,
I.balance,
I.eligible_tag,
V_REWARD,
I.transaction_id,
I.payee_name,
V_REMARKS,
V_FLAG,
I.as_of_month,
I.product_name,
I.product_capping,
I.CUSTOMER_SEGMENT,
I.RD_ACCOUNT_NBR,
I.MEMBER_CUST_ID);
END IF;
COMMIT;
ELSE
V_REMARKS := i.remarks;
-- V_REMARKS := i.PRODUCT_NAME ||'transaction successfully earned'||' '||0 ;
V_FLAG := 'R';
INSERT INTO LY_RWPT_CAP_SUCCESS
VALUES
(I.source_account_number,
I.cust_id,
I.customer_status_code,
I.product_code,
I.value,
I.transaction_date,
I.processing_date,
I.balance,
I.eligible_tag,
0,
I.transaction_id,
I.payee_name,
V_REMARKS,
V_FLAG,
I.as_of_month,
I.product_name,
I.product_capping,
I.CUSTOMER_SEGMENT,
I.RD_ACCOUNT_NBR,
I.MEMBER_CUST_ID);
END IF;
COMMIT;
END LOOP;
END;

Answer 1

Try this
create or replace procedure ly_product_capping_old
   p_month varchar2
is
begin
   insert
     into ly_rwpt_cap_success
   select i.source_account_number,
          i.cust_id,
          i.customer_status_code,
          i.product_code,
          i.value,
          i.transaction_date,
          i.processing_date,
          i.balance,
          i.eligible_tag,
          case when i.reward != 0 then
                  case when nvl(j.rewards, 0) >  i.product_capping then 0
                    when nvl(j.rewards, 0) =  0 and i.rewards <= i.product_capping then i.rewards
                 when i.product_capping <  nvl(j.rewards, 0) + i.rewards then abs(i.product_capping -  nvl(j.rewards, 0))
                 when i.product_capping >= nvl(j.rewards, 0) + i.rewards then i.rewards
               end
               else 0
          end v_reward,
          i.transaction_id,
          i.payee_name,
          case when i.reward != 0 then
                  case when nvl(j.rewards, 0) >  i.product_capping then i.remarks || ' but receiving ' || ' ' || 0 || ' points as reached to product capping'
                    when nvl(j.rewards, 0) =  0 and i.rewards <= i.product_capping then i.remarks
                 when i.product_capping <  nvl(j.rewards, 0) + i.rewards then i.remarks || ' but earned  ' || ' ' || abs(i.product_capping -  nvl(j.rewards, 0)) || ' partial  points' || ' as exceeding product capping';
                 when i.product_capping >= nvl(j.rewards, 0) + i.rewards then i.remarks
               end
            else i.remarks
          end  v_remarks,
          case when i.reward != 0 then
                  case when nvl(j.rewards, 0) >  i.product_capping then 'N'
                    when nvl(j.rewards, 0) =  0 and i.rewards <= i.product_capping then 'F'
                 when i.product_capping <  nvl(j.rewards, 0) + i.rewards then 'P'
                 when i.product_capping >= nvl(j.rewards, 0) + i.rewards then 'F'
               end
            else 'R'
          end v_flag,
          i.as_of_month,
          i.product_name,
          i.product_capping,
          i.customer_segment,
          i.rd_account_nbr,
          i.member_cust_id
     from ly_rwpt_success i
     left
     join (
             select product_code, source_account_number, sum(rewards) rewards
               from ly_rwpt_cap_success
              where as_of_month  = p_month
                and partial_flag in ('F', 'P')
              group
                 by product_code, source_account_number
          ) j
       on i. product_code = j.product_code
      and i.source_account_number = j.source_account_number
    where as_of_month = p_month;
   commit;
end;There could be some semantic errors, if found please correct. And also please specify the column list in the insert statement.
And oh forgot to mention the code is untested :)