Procedure ..Please have a look and give ur suggestion

Question

Hi all,
Please have a below procedure.
Suggest me if I do anything to make it more efficient?
Because I'm very very new to pl/sql .
I have to send this to code review.Before just to make sure everything is good and all logic and everything.
Thanks in advance.
PROCEDURE proc1 (
  in_report_parameter_id   IN      NUMBER,
  in_date_format_mask      IN      VARCHAR2,
  in_start_date_time       IN      TIMESTAMP,
  in_end_date_time         IN      TIMESTAMP
AS
    my_current_date_time TIMESTAMP;            
BEGIN
      my_current_date_time := TRUNC(in_start_date_time);
      DELETE FROM table1;
  LOOP
     EXIT WHEN my_current_date_time >= in_end_date_time;
     INSERT INTO table1 (
                 date_time )
     VALUES (my_current_date_time);
      my_current_date_time := my_current_date_time + numtodsinterval(1, 'DAY');
  END LOOP;
  DELETE FROM table1
     WHERE   TRUNC (date_time) IN
          SELECT TO_TIMESTAMP(report_parameter_value, in_date_format_mask)
            FROM report_parameters
          WHERE report_parameters.report_parameter_id    = in_report_parameter_id
          AND report_parameters.report_parameter_group = edr_rpt_constants_pkg.date_format_mask_group
          AND report_parameters.report_parameter_name  = edr_rpt_constants_pkg.excluded_date_name
END proc1;

Answer 1

Hi,
I meant something like this:
INSERT INTO table1 (date_time)
WITH   all_dates   AS
     SELECT     in_start_date_time
                  + LEVEL - 1     AS dt
     FROM     dual
     CONNECT BY   LEVEL <= 1 + in_end_date_time
                                - in_start_date_time
SELECT     dt
FROM     all_dates
WHERE     dt     NOT IN     (
                   SELECT  TO_TIMESTAMP (report_parameter_value, in_date_format_mask)
                 FROM     report_parameters
               WHERE     report_parameters.report_parameter_id    = in_report_parameter_id
               AND     report_parameters.report_parameter_group = edr_rpt_constants_pkg.date_format_mask_group
               AND     report_parameters.report_parameter_name  = edr_rpt_constants_pkg.excluded_date_name
;If you post CREATE TABLE and INSERT (or CREATE TABLE AS) statements, then I' can test it.
As Tim said, TRUNCATE TABLE is not a PL/SQL command, so to use it in PL/SQL you have to use EXECUTE IMMEDIATE, like this:
EXECUTE IMMEDIATE 'TRUNCATE TABLE  table1';The word TABLE before the table name is required.