Raise FORM_TRIGGER_FAILURE don't work well.

Question

Dear All,
I'm facing a problem that I can't understand well.
I have a screen that contain two fields: Field1 and Field2.
The control I had to add: is to avoid saving duplicate records, and also do not save a record if one of these fields is empty.
I wrote the trigger KEY_COMMIT, where I did:
Line: -----
declare
     x number;
     ret number;
begin
if ( (:Field1 is null ) and (:Field2 is null ) ) then
     ret:=msgbox('Please choos a Field1 and Field2');
               RAISE FORM_TRIGGER_FAILURE;      
else if ( (:Field1 is null ) or (:Field2 is null ) ) then
     ret:=msgbox('Please Enter Field1 and Field2');
               RAISE FORM_TRIGGER_FAILURE;
               else
                    begin
                    select count(*) into x from TABLE1 where xxxxxxxx=:Field1;
                    exception when others then
                         x:=0;
                    end;
                    if x>0 then
                         ret:=msgbox('Field1 Already Registred');
                         :Field2:='';
                                             RAISE FORM_TRIGGER_FAILURE;
                    else
                         commit;
                    end if;
end if;
end if;
end;
Line: -----
The problem in that is when I click on EXIT button, I get this message: " Do you want to save all modifications you made? "
If I click YES => I find in te table TABLE1 that, also the records having one of the above fields empty, are saved.
How Come?
As I know, Raise FORM_TRIGGER_FAILURE must stop the trigger and then, no commit. It's not the case !
Can someone help me in that? Did I wrote the wrong trigger ?
Many Thanks for your help.
Imad QANDOUCI

Answer 1

you wrote an KEY-COMMIT Trigger. But you press KEY-EXIT. Why should KEY-COMMIT Trigger fire on KEY-EXIT?
Put your checks to PRE-INSERT and PRE-UPDATE triggers (to both!). Best, avoid duplicate code by writing a procedure consisting the checks and coll the procedure in the triggers.