RPC E Server Fault SAP B1 8.8

Question

Hi
I have written some code to import various documents, ie invoices, goods in from an ascii file
The customer occasionally gets the RPC E Server fault coming up
I looked in the forums and updated the message bar which seemed to help but for some reason they still seem to get it
Generally on larger import files
The code is fairly simple, I have enclosed a copy of an invoice import below to see if anyone can see any problems
Would a garbage collect help ?
Many thanks
Regards Andy
ps Not sure how to make code readable ?
                 While Not EOF(filenum)   
                    lc = lc + 1
                    'If lc Mod 5 = 0 Then
                    B1Connections.theAppl.SetStatusBarMessage("Importing line " & lc & " ....", BoMessageTime.bmt_Short, False)
                    'form.Items.Item("9").Specific.string = " " & lc
                    'End If
                    If EOF(filenum) Then GoTo end_imp
                    Input(filenum, custid)
                    If EOF(filenum) Then GoTo end_imp
                    Input(filenum, invnum)
                    If EOF(filenum) Then GoTo end_imp
                    Input(filenum, invdate)
                    Input(filenum, adamstockrot)
                    Input(filenum, qty)
                    Input(filenum, unitprice)
                    Input(filenum, salesval)
                    Input(filenum, vc)
                    Input(filenum, prodbandid)
                    Input(filenum, prodid)
                    Input(filenum, ordnum)
                    Input(filenum, credreason)
                    Input(filenum, invtype)
                    Input(filenum, rettostock)
                    Input(filenum, currcode)
                    Input(filenum, exrate)
                    Input(filenum, salescontrref)
                    Input(filenum, wh)
                    Input(filenum, salesanal)
                    Input(filenum, costval)
                    Input(filenum, salestype)
                    Input(filenum, invprodid)
                    Input(filenum, oauserprodid)
                    Input(filenum, qtyinvprod)
                    Input(filenum, rep)
                    custid = "C" & Trim(custid)
                    prodid = "P" & Trim(prodid)
                    ' check stock code exists
                    If credreason < 8 Then
                        recset.DoQuery("select * from oitm where itemcode = '" & prodid & "'")
                        If recset.RecordCount = 0 Then
                            'result = B1Connections.theAppl.MessageBox("Cannot find stock code " & prodid, 1, "Ok", "Cancel Import")
                            'If result = 2 Then Return
                            message("Line " & lc & " Error Cannot find stock code " & prodid)
                            GoTo nline
                        End If
                    End If
                    ' check customer exists
                    recset.DoQuery("select * from ocrd where cardcode = '" & custid & "'")
                    If recset.RecordCount = 0 Then
                        message("Line " & lc & " Cannot find bp " & custid)
                        GoTo nline
                    End If
                    ' see if new document
                    If invnum.Trim <> lastinv.Trim Then
                        ' save document
                        If lastinv.Trim = "" Then GoTo new_ord
                        lastbp = doc.CardCode
                        If doc.Add <> 0 Then
                            B1Connections.diCompany.GetLastError(errcode, errmsg)
                            'result = B1Connections.theAppl.MessageBox("Line " & lc & "-" & errmsg, 1, "Ok", "Cancel Import")
                            'If result = 2 Then Return
                            'Message("Error adding invoice/credit " & lastinvno & " " & errmsg & " file " & plpath)
                            message("Line " & lc & " Error adding pos inv/cr " & lastinv & " " & errmsg)
                            PrintLine(filenum2, docstring)
                        Else
                            'Message("Added invoice/credit " & lastinvno & " period " & period & " file " & plpath)
                            'B1Connections.theAppl.MessageBox("Added document")
                            ' find sap total
                            If Trim(lastdoctype) = "IN" Then recset.DoQuery("SELECT top 1 doctotal,doctotalfc  FROM OINV T0 where cardcode = '" & lastbp & "' order by docnum desc")
                            If Trim(lastdoctype) = "CR" Then recset.DoQuery("SELECT top 1 doctotal,doctotalfc  FROM ORIN T0 where cardcode = '" & lastbp & "' order by docnum desc")
                            If recset.Fields.Item(0).Value > 0 Then saptotal = recset.Fields.Item(0).Value
                            If recset.Fields.Item(1).Value > 0 Then saptotal = recset.Fields.Item(1).Value
                            message("Line " & lc & " Added pos inv/cr " & lastinv & " import total " & doctotal & " sap total " & saptotal)
                            'If Trim(invtype).ToUpper = "IN" Then add_pos_payment(lastinv, lc)
                        End If
new_ord:
                        ' create new doc
                        If invtype = "IN" Then
                            doc = B1Connections.diCompany.GetBusinessObject(BoObjectTypes.oInvoices)
                        Else
                            doc = B1Connections.diCompany.GetBusinessObject(BoObjectTypes.oCreditNotes)
                        End If
                        ' need to check if service invoice
                        'If credreason >= 8 Then
                        'doc.DocType = BoDocumentTypes.dDocument_Service
                        'Else
                        doc.DocType = BoDocumentTypes.dDocument_Items
                        'End If
                        doc.CardCode = custid
                        doc.NumAtCard = invnum
                        doc.DocDate = CDate(invdate)
                        If exrate > 1 Then doc.DocRate = exrate
                        lastinv = invnum
                        doc.UserFields.Fields.Item("U_ORDER_NUMBER").Value = ordnum
                        doc.UserFields.Fields.Item("U_CF_ADAM_CNCY_CODE").Value = currcode
                        doc.UserFields.Fields.Item("U_INVOICE_TYPE").Value = invtype
                        doc.UserFields.Fields.Item("U_CREDIT_REASON").Value = CStr(credreason)
                        addlines = False
                        doctotal = 0
                        lastdoctype = invtype
                        docstring = ""
                    End If
                    ' add lines to document
                    If addlines Then
                        doc.Lines.Add()
                    End If
                    addlines = True
                    'If credreason < 8 Then
                    doc.Lines.ItemCode = prodid
                    doc.Lines.WarehouseCode = wh
                    doc.Lines.WarehouseCode = "01"
                    'End If
                    ' service invoice mod
                    If credreason >= 8 Then
                        doc.Lines.ItemCode = "PCR"
                        If vc = "0" Then doc.Lines.VatGroup = "O2"
                        If vc = "1" Then doc.Lines.VatGroup = "O1"
                        If vc = "2" Then doc.Lines.VatGroup = "O3"
                    End If
                    doc.Lines.Quantity = qty
                    ' map vat code
                    'doc.Lines.VatGroup = vc
                    'If qty > 0 And salesval > 0 Then
                    'doc.Lines.UnitPrice = CDec(salesval / qty)
                    'End If
                    doc.Lines.LineTotal = salesval
                    doctotal = doctotal + salesval
                    ' set user defined fields for line
                    doc.Lines.UserFields.Fields.Item("U_VAT_CODE").Value = vc
                    doc.Lines.UserFields.Fields.Item("U_PRODUCT_BRAND_ID").Value = prodbandid
                    doc.Lines.UserFields.Fields.Item("U_RETURN_TO_STOCK").Value = CStr(rettostock)
                    doc.Lines.UserFields.Fields.Item("U_SALES_CONTRACT_REF").Value = salescontrref
                    doc.Lines.UserFields.Fields.Item("U_COST_VALUE").Value = CStr(costval)
                    doc.Lines.UserFields.Fields.Item("U_SALES_ANALYSIS_ID").Value = salesanal
                    doc.Lines.UserFields.Fields.Item("U_SALES_TYPE").Value = salestype
                    doc.Lines.UserFields.Fields.Item("U_INVOICE_PROD_ID").Value = invprodid
                    doc.Lines.UserFields.Fields.Item("U_SALEPSYS_PROD_ID").Value = oauserprodid
                    doc.Lines.UserFields.Fields.Item("U_QTY_INVOICE_PROD").Value = CStr(qtyinvprod)
                    doc.Lines.UserFields.Fields.Item("U_REP_NUMBER").Value = CStr(rep)
                    ' map gl code
                    ' look for mapping table for group code
                    recset.DoQuery("select U_X_Code from [@CF_GL_2_REP] where U_POS = 'POS' and U_REP = '" & rep & "'")
                    If recset.RecordCount = 1 Then
                        gcode = recset.Fields.Item(0).Value
                        recset.DoQuery("select RevenuesAc,salecostac,ARCMAct,ItmsGrpNam from oitb where ItmsGrpNam = '" & gcode & "'")
                        If recset.RecordCount = 1 Then
                            If Trim(invtype) = "IN" Then
                                doc.Lines.AccountCode = recset.Fields.Item(0).Value
                            Else
                                doc.Lines.AccountCode = recset.Fields.Item(2).Value
                            End If
                            If credreason < 8 Then doc.Lines.COGSAccountCode = recset.Fields.Item(1).Value
                        End If
                    End If
nline:
                End While
end_imp:
Edited by: Andrew Brooker on Nov 8, 2010 9:12 AM
Tried to make code readable,  doesn't seem to help ?

Answer 1

Hello Guys,
So basically let's do a skype conf in this topic, if you have time.......
locate me: janos.nagy.itelligence.
Garbage is managed automatically.... You do not need to release any com objects (memory), because if you are have any transactions  / data changes / cache movements you loose the data...
Please note: the most important is: compiler is able to manage the memory when you have a clear definition....
The problem is always the loop. How to manage the (DI API and other) objects memory inside the loop to not get run to the sky, and hold in a manageable situation. It is not easy, but if you hold some major steps and rules, you are able to manage...
example:
bad
dim foo as object
do
  set foo = new object
loop
why?
Who will release the memory for object? declared outside  from a loop -> initilized inside the loop.... compiler will never free the object, so you will initilaize the previous object always-> eats memory....
correct
'version a
do
  declare foo as object
  set foo = new object
loop
'version b
function update_foo (list of params) as booelan
begin
declare foo as object
set foo = new object
... do operation here
gc,.collect()
end
'now you call update_foo
do
call  update_foo function and pass the params
loop
Some sample cases....
1. Creation of UDF-s / UDT-s  in a cycle:
task:  Never do it in one method or subrutine
- reason cannot release the Garbage in a transaction
- solution create a subrutine and inside code, where  you are able to manage the memory by the compiler automatically
2. update any Objects in a loop:
- never declare document as global for the metjod/subrutin
- reason unable to manage Garbage inside (which object to be released?)
- solution: declare the whole document inside the loop
so Andy,
in your code i see, that the document declared outside the loop, and initialized inside the loop. -> compiler will never release the com object  in a loop
Correct would be: apply sap note i have provided in the message and  and also change the declaration of document somewhere in your code
' create new doc
'-> insert the doc declaration here
so Sebastian,
I did not see your code, but if you separate the UDF creation into a method/subrutine.
if you using method b, the issue never happens....
I have tested a lot, each cases.... these solutions was always giving the correct way......
Regards
János