Running CMD command from process.exec

Question

I've been chopping this code up so forgive me if this is a mess, however I cannot figure out why this command simply will not work. It never seems to attempt to sign the jar files. I've also tried to sign the jar file by using an output stream. I can run the System.out of the payload from the CMD and it works fine.
When this method is executed it seems to loop over like nothing is happening.
private void signJar(String jarPath)
               String payload = "\"c:\\program files\\java\\jdk1.6.0_17\\bin\\jarsigner.exe\" -keystore \"" + ksPath + "\" -storepass " + ksPW + " \"" + jarPath + "\" " + ksAlias;
               try {
                    Process proc = Runtime.getRuntime ().exec("cmd /c " + payload);
                    InputStream inputstream = proc.getInputStream();
                    InputStream errorstream = proc.getErrorStream();
                    InputStreamReader inputstreamreader = new InputStreamReader(inputstream);
                    InputStreamReader errorstreamreader = new InputStreamReader(errorstream);
                    BufferedReader inputreader = new BufferedReader(inputstreamreader);
                    BufferedReader errorreader = new BufferedReader(errorstreamreader);
                    while ((line = inputreader.readLine()) != null) {
                         d.asyncExec(new Runnable() {
                              public void run(){
                    l.setText(line + "\n" + l.getText());
                    while ((line = errorreader.readLine()) != null) {
                         d.asyncExec(new Runnable() {
                              public void run(){
                         l.setText(line + "\n" + l.getText());
                    errorreader.close();
                    inputreader.close();
                    return;
                    catch(IOException e)
                         e.printStackTrace();
                         return;
          }

Answer 1

sabre150 wrote:
You probably have a deadlock since your code falls for at least 2 of the traps described in the 4 sections of [http://www.javaworld.com/javaworld/jw-12-2000/jw-1229-traps.html|http://www.javaworld.com/javaworld/jw-12-2000/jw-1229-traps.html].
Thanks, I checked this out and decided to implement one of the methods he had, however, now I am getting an illegal argument exception. I think it is because of my payload, but I am not sure how to fix it. I know everything is formatted properly to input it in the console manually.
private void signJar(String jarPath)
               String payload = "\"c:\\program files\\java\\jdk1.6.0_17\\bin\\jarsigner.exe\" -keystore \"" + ksPath + "\" -storepass " + ksPW + " \"" + jarPath + "\" " + ksAlias;
               String cmds[] = {"cmd","/c",payload};
               if (cmds.length < 1)
                 System.out.println("USAGE: java GoodWindowsExec <cmd>");
                 System.exit(1);
             try
                 String[] cmd = new String[3];
                     cmd[0] = "cmd.exe" ;
                     cmd[1] = "/C" ;
                     cmd[2] = cmds[2];
                 Runtime rt = Runtime.getRuntime();
                 System.out.println("Execing " + cmd[0] + " " + cmd[1]
                                    + " " + cmd[2]);
                 Process proc = rt.exec(cmd);
                 // any error message?
                 StreamGobbler errorGobbler = new
                     StreamGobbler(proc.getErrorStream(), "ERROR");           
                 // any output?
                 StreamGobbler outputGobbler = new
                     StreamGobbler(proc.getInputStream(), "OUTPUT");
                 // kick them off
                 errorGobbler.start();
                 outputGobbler.start();
                 // any error???
                 int exitVal = proc.waitFor();
                 System.out.println("ExitValue: " + exitVal);       
             } catch (Throwable t)
                 t.printStackTrace();
          }Updated with different code still same error
EDIT: I should pay closer attention and stop trying to copy and paste code. I see where he says you can't use it like the command line...